From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by mx.groups.io with SMTP id smtpd.web08.164.1615836234106108575 for ; Mon, 15 Mar 2021 12:23:54 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=jEY18gel; spf=pass (domain: gmail.com, ip: 209.85.215.173, mailfrom: kuqin12@gmail.com) Received: by mail-pg1-f173.google.com with SMTP id t37so10249979pga.11 for ; Mon, 15 Mar 2021 12:23:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=afcHu35JJR1GUeccC3JJ4DXWJUdaT2EtzsxBZ6nSbBU=; b=jEY18gelpGGgXf7sJKbuaL1WNmgypG6HmIEscu/a5g0fIyG7gsC//Z68LNMpEtBU7D +TeiiMaRzU2tl8i+jBpALdwyCz3NO9PJ69o/+qLmf1sTI8e+vM2yynOu9Mq6pe3zBxI0 xtYFoCucGWvw81F8Dv+u7iVln0rLDk9hn/kesPdYhrnal4uitsXoyZ7NV+TgCVWavonp 0aEpOyoA5OkeoJetZnbT//xh1g7KVn7tZN+kwX+FLaCFVn2Ov5JBRuUf/mYRavaSxxbT E4Gsi6moXWvxRyeI9l5jOFvMtaEzYgmjmaMPAIbhublKdHq3yS3ojre4UT1RJxoQCebr oRcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=afcHu35JJR1GUeccC3JJ4DXWJUdaT2EtzsxBZ6nSbBU=; b=h8kkugsvxHv4Kcw7sn/lCLqXNS4JhO3S2uakR8C2Mos8h2wWFQ6woSN1PdfTdH7Sc5 6qiCteb3CMkSBgUYRBeWpERdgLbbStDCHWsro6gT08H72ZePICT0Djp80toqcVUyXVjj ErAGh57w++QS6k93SEpK9TI5wZcA6/0b3AGp0gXJP3HpivovRt36JzFm8mxnp+EguCh5 aXhDaY2ew5wWbWd5Cyb9J4vNcJWzmR29sUA46ulDII/uJxYRvcU5aTRZHGx1uSMBAFWI LVyZDb37V84eexB+V0GMVhe2AbKm4xsASuqJ2dEu6D6V5lss0HEhnmqNk7YB4OzopFka 4BRQ== X-Gm-Message-State: AOAM530p16wMLOKDyg2Ue11JpdNyzHpRl1wIOU3yHby0eycydNCnQkOx caG12fPdMSAEf2nkxCTFKfg= X-Google-Smtp-Source: ABdhPJz/G6a1N38OCbTeWzVpc/BzlSsa7Kr1pR2L8C4jom+99uFsXLbv3AS1ea3oQwT8g3SpKc6e3g== X-Received: by 2002:a65:4942:: with SMTP id q2mr579755pgs.34.1615836233598; Mon, 15 Mar 2021 12:23:53 -0700 (PDT) Return-Path: Received: from [192.168.50.18] ([50.35.88.161]) by smtp.gmail.com with ESMTPSA id m5sm14421536pfd.96.2021.03.15.12.23.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Mar 2021 12:23:53 -0700 (PDT) Subject: Re: [edk2-staging][PATCH V1 5/5] Socionext: DeveloperBox DSC File: Added library for VariableSmmRuntimeDxe From: "Kun Qin" To: devel@edk2.groups.io, Ard Biesheuvel , Leif Lindholm References: <20210310200738.1220-1-kuqin12@gmail.com> <20210310200738.1220-6-kuqin12@gmail.com> Message-ID: <451f5777-16bc-7096-a0a9-7972cd81b227@gmail.com> Date: Mon, 15 Mar 2021 12:23:53 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210310200738.1220-6-kuqin12@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Ard/Leif, Could you please help review the patch when you have a chance? Thanks in advance. Regards, Kun On 03/10/2021 12:07, Kun Qin wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250 > > This change added NULL MmUnblockMemoryLib instance in DeveloperBox.dsc to > resolve new dependency by VariableSmmRuntimeDxe. The library interface > is consumed by variable module to better support variable runtime cache > feature. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > > Signed-off-by: Kun Qin > --- > Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > index 0a11b796cca5..acaa4cd90fc5 100644 > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > @@ -49,6 +49,8 @@ [LibraryClasses] > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf > !endif > > + MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf > + > [LibraryClasses.common.SEC] > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf >