Re: [PATCH 0/6] MdeModulePkg/VariableSmm: fix MOR / MorLock inconsistency

["Yao, Jiewen" <jiewen.yao@intel.com>]

Thank you, Laszlo, for your patient.

Yes, I also hope to have a real platform to validate, before I give RB. :-)

Maybe some time in next week.

thank you!
Yao, Jiewen


> 在 2017年10月5日，下午3:57，Laszlo Ersek <lersek@redhat.com> 写道：
> 
> Hi Star,
> 
>> On 10/05/17 09:42, Zeng, Star wrote:
>> Laszlo,
>> 
>> If the series is not so urgent to be pushed, I want to take some time(of maybe one or two days) to look at the discussion background and the patches.
>> If it is urgent, go ahead to push the patches if you have got Jiewen's RB.
> 
> Jiewen hasn't given his official R-b yet; he said that the patches
> looked good to him in general.
> 
> Beyond an R-b from Jiewen and/or you and/or Eric, I wouldn't like to
> push the patches until Intel QA (or one of you guys) can regression-test
> the series, on a platform where TcgMor.inf is included -- that is, on a
> platform where the MOR and MorLock variables exist *genuinely*. I don't
> have access to such a platform (OVMF does not support these variables),
> so I couldn't regression-test the series that way.
> 
> The variable driver is very important and it is shipped on all physical
> platforms as well, so we shouldn't push these patches before thorough
> regression-testing. I'd rather delay committing this set and do a bit
> more work in RHEL7 downstream (backports) than have to fix an ugly
> upstream regression in a panic.
> 
> Please take your time and review the patches and the background
> discussion in detail. And, again, I would very much appreciate if you
> guys or someone from Intel QA could fetch the branch and regression-test
> the work, using a platform that supports MOR and MorLock for real.
> 
> Thanks!
> Laszlo
> 
>> -----Original Message-----
>> From: Laszlo Ersek [mailto:lersek@redhat.com] 
>> Sent: Wednesday, October 4, 2017 5:28 AM
>> To: edk2-devel-01 <edk2-devel@lists.01.org>
>> Cc: Dong, Eric <eric.dong@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Ladi Prosek <lprosek@redhat.com>; Zeng, Star <star.zeng@intel.com>
>> Subject: [PATCH 0/6] MdeModulePkg/VariableSmm: fix MOR / MorLock inconsistency
>> 
>> Repo:   https://github.com/lersek/edk2.git
>> Branch: mor_lock_init_at_end_of_dxe
>> 
>> This patch set fixes the issue reported in the following items:
>> 
>> * Inconsistent MOR control variables exposed by OVMF, breaks Windows
>>  Device Guard
>> 
>>  https://bugzilla.redhat.com/show_bug.cgi?id=1496170
>> 
>> * VariableSmm MorLockInit(): create MORLock only if / after MOR exists
>> 
>>  https://bugzilla.tianocore.org/show_bug.cgi?id=727
>> 
>> Patches #1 through #3 are cleanups.
>> 
>> Patch #4 is a small helper patch for patch #5.
>> 
>> Patch #5 is the actual fix, following Jiewen's suggestions from the edk2-devel thread
>> 
>> * [edk2] multiple levels of support for MOR / MORLock
>> 
>>  https://lists.01.org/pipermail/edk2-devel/2017-September/015444.html
>>  https://lists.01.org/pipermail/edk2-devel/2017-October/015530.html
>> 
>> Patch #6 is a workaround for some OSes (minimally Fedora 24-26, and some Debian versions) that create the MOR variable even if the platform doesn't offer it up-front. This patch also follows Jiewen's suggestion from the same edk2-devel thread.
>> 
>> (
>> 
>> BTW, at Paolo's recommendation, I've now reported this kernel issue for Fedora, under
>> 
>> * incorrect downstream-only Platform Reset Attack Mitigation patch in
>>  the F24-F26 kernels
>> 
>>  https://bugzilla.redhat.com/show_bug.cgi?id=1498159
>> 
>> )
>> 
>> I've checked this set for basic regressions, using OVMF, normal boot and
>> S3 suspend/resume:
>> 
>> * Q35, SMM, IA32:
>>  - Fedora 25 -- verified patch #6 specifically
>> 
>> * i440fx, no SMM, X64:
>>  - Fedora 24
>> 
>> * Q35, SMM, IA32X64:
>>  - Fedora 26 -- verified patch #6 specifically
>>  - Windows 7
>>  - Windows 8.1
>>  - Windows 10
>>  - Windows Server 2008 R2
>>  - Windows Server 2012 R2
>> 
>> I didn't / couldn't test this set in the following two environments:
>> 
>> - on platforms where TcgMor.inf is included in the firmware, and the MOR
>>  variable exists genuinely,
>> 
>> - in the nested virt setup where Ladi reported the Device Guard
>>  breakage. (If I understand correctly, ATM this requires additional
>>  host kernel (KVM) patches.)
>> 
>> Test results / feedback from those envs would be appreciated.
>> 
>> Cc: Eric Dong <eric.dong@intel.com>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Cc: Ladi Prosek <lprosek@redhat.com>
>> Cc: Star Zeng <star.zeng@intel.com>
>> 
>> Thanks,
>> Laszlo
>> 
>> Laszlo Ersek (6):
>>  MdeModulePkg/Variable/RuntimeDxe: move SecureBootHook() decl to new
>>    header
>>  MdeModulePkg/Variable/RuntimeDxe: move MOR func. declarations to
>>    header
>>  MdeModulePkg/Variable/RuntimeDxe: introduce MorLockInitAtEndOfDxe()
>>    hook
>>  MdeModulePkg/Variable/RuntimeDxe: permit MorLock deletion for passthru
>>    req
>>  MdeModulePkg/Variable/RuntimeDxe: delay MorLock creation until
>>    EndOfDxe
>>  MdeModulePkg/Variable/RuntimeDxe: delete and lock OS-created MOR
>>    variable
>> 
>> MdeModulePkg/Universal/Variable/RuntimeDxe/Measurement.c             |   2 +
>> MdeModulePkg/Universal/Variable/RuntimeDxe/PrivilegePolymorphic.h    |  89 ++++++++++
>> MdeModulePkg/Universal/Variable/RuntimeDxe/TcgMorLockDxe.c           |  45 +++--
>> MdeModulePkg/Universal/Variable/RuntimeDxe/TcgMorLockSmm.c           | 173 ++++++++++++++++++--
>> MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c                |  51 ------
>> MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.h                |   2 +
>> MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c             |   2 +
>> MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf    |   1 +
>> MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.c             |   2 +
>> MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf           |   4 +
>> MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c   |  16 +-
>> MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf |   1 +
>> 12 files changed, 294 insertions(+), 94 deletions(-)  create mode 100644 MdeModulePkg/Universal/Variable/RuntimeDxe/PrivilegePolymorphic.h
>> 
>> --
>> 2.14.1.3.gb7cf6e02401b
>> 
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel