Re: [RFC 1/6] ConfigPkg: add new package for holding common config fragments

[Laszlo Ersek <lersek@redhat.com>]

On 09/21/17 02:05, Ard Biesheuvel wrote:
> On 20 September 2017 at 10:27, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>> Start with common networking options.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
>> ---
>>  ConfigPkg/Network/Network.dsc.inc | 92 +++++++++++++++++++++++++++++++++++++++
>>  ConfigPkg/Network/Network.fdf.inc | 47 ++++++++++++++++++++
>>  2 files changed, 139 insertions(+)
>>  create mode 100644 ConfigPkg/Network/Network.dsc.inc
>>  create mode 100644 ConfigPkg/Network/Network.fdf.inc
>>
>> diff --git a/ConfigPkg/Network/Network.dsc.inc b/ConfigPkg/Network/Network.dsc.inc
>> new file mode 100644
>> index 0000000000..8c53350deb
>> --- /dev/null
>> +++ b/ConfigPkg/Network/Network.dsc.inc
>> @@ -0,0 +1,92 @@
>> +## @file
>> +#
>> +# Copyright (c) 2017, Linaro ltd. All rights reserved.<BR>
>> +#
>> +#  This program and the accompanying materials are licensed and made available
>> +#  under the terms and conditions of the BSD License which accompanies this
>> +#  distribution. The full text of the license may be found at
>> +#  http://opensource.org/licenses/bsd-license.php
>> +#
>> +#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
>> +#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
>> +#
>> +##
>> +
>> +
>> +################################################################################
>> +#
>> +# Library Class section
>> +#
>> +################################################################################
>> +[LibraryClasses]
>> +  DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf
>> +  IpIoLib|MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf
>> +  NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf
>> +  UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf
>> +
> 
> Now that you have made a clean spot: any reason we shouldn't do
> 
> DpcLib           |MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf
> IpIoLib          |MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf
> NetLib           |MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf
> UdpIoLib         |MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf
> 
> ?

Do you mean the nicer visual layout / alignment?

Thanks
Laszlo