From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D7C0B21E43B6C for ; Fri, 22 Sep 2017 04:18:59 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5FA741F561; Fri, 22 Sep 2017 11:22:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5FA741F561 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-219.rdu2.redhat.com [10.10.120.219]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7A35C6058F; Fri, 22 Sep 2017 11:22:05 +0000 (UTC) To: Ard Biesheuvel , Leif Lindholm Cc: "edk2-devel@lists.01.org" , Andrew Fish , Michael D Kinney , Jordan Justen References: <20170920172755.22767-1-leif.lindholm@linaro.org> <20170920172755.22767-2-leif.lindholm@linaro.org> From: Laszlo Ersek Message-ID: <4523bc60-230a-2343-4c52-7ffa0e20e9f3@redhat.com> Date: Fri, 22 Sep 2017 13:22:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 22 Sep 2017 11:22:07 +0000 (UTC) Subject: Re: [RFC 1/6] ConfigPkg: add new package for holding common config fragments X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Sep 2017 11:19:00 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/21/17 02:05, Ard Biesheuvel wrote: > On 20 September 2017 at 10:27, Leif Lindholm wrote: >> Start with common networking options. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Leif Lindholm >> --- >> ConfigPkg/Network/Network.dsc.inc | 92 +++++++++++++++++++++++++++++++++++++++ >> ConfigPkg/Network/Network.fdf.inc | 47 ++++++++++++++++++++ >> 2 files changed, 139 insertions(+) >> create mode 100644 ConfigPkg/Network/Network.dsc.inc >> create mode 100644 ConfigPkg/Network/Network.fdf.inc >> >> diff --git a/ConfigPkg/Network/Network.dsc.inc b/ConfigPkg/Network/Network.dsc.inc >> new file mode 100644 >> index 0000000000..8c53350deb >> --- /dev/null >> +++ b/ConfigPkg/Network/Network.dsc.inc >> @@ -0,0 +1,92 @@ >> +## @file >> +# >> +# Copyright (c) 2017, Linaro ltd. All rights reserved.
>> +# >> +# This program and the accompanying materials are licensed and made available >> +# under the terms and conditions of the BSD License which accompanies this >> +# distribution. The full text of the license may be found at >> +# http://opensource.org/licenses/bsd-license.php >> +# >> +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, >> +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. >> +# >> +## >> + >> + >> +################################################################################ >> +# >> +# Library Class section >> +# >> +################################################################################ >> +[LibraryClasses] >> + DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf >> + IpIoLib|MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf >> + NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf >> + UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf >> + > > Now that you have made a clean spot: any reason we shouldn't do > > DpcLib |MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf > IpIoLib |MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf > NetLib |MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf > UdpIoLib |MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf > > ? Do you mean the nicer visual layout / alignment? Thanks Laszlo