From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 68C40D800EA for ; Wed, 28 Feb 2024 04:09:42 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=DME5Fl8Yv1sGcXi2Hds0OccQkoLCdr2qAGm1HdCn/xY=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1709093380; v=1; b=e5Ekv0yCaIxtYausQGm6Bkb2GmYcrm5/CiItJ5DKJsW6QXIhsJuqyCunmAC4zxu2RlZmGVm3 +3rRTlab17G4MV7s1AlHXEIeQPLQENhPqrCl0A4M5fBoIeCLUc3+XdcL4Cj1QNpxCeBMZoXj1lb Ek9ZHuEso7+0NOsJ58ZQh4C8= X-Received: by 127.0.0.2 with SMTP id ZuVmYY7687511x9p2CEbe0mx; Tue, 27 Feb 2024 20:09:40 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.6011.1709093380307586011 for ; Tue, 27 Feb 2024 20:09:40 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-516-bw5uv1t-MZWjLXEf51__xQ-1; Tue, 27 Feb 2024 23:09:36 -0500 X-MC-Unique: bw5uv1t-MZWjLXEf51__xQ-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 981531C05AB0; Wed, 28 Feb 2024 04:09:35 +0000 (UTC) X-Received: from [10.39.192.46] (unknown [10.39.192.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 06B792166B33; Wed, 28 Feb 2024 04:09:33 +0000 (UTC) Message-ID: <453c3b30-8ab5-c258-d411-cf108761fd18@redhat.com> Date: Wed, 28 Feb 2024 05:09:32 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH 02/10] OvmfPkg/ResetVector: add ClearOvmfPageTables macro To: devel@edk2.groups.io, kraxel@redhat.com Cc: Tom Lendacky , Jiewen Yao , Oliver Steffen , Erdem Aktas , Michael Roth , Ard Biesheuvel , Min Xu References: <20240222115435.85794-1-kraxel@redhat.com> <20240222115435.85794-3-kraxel@redhat.com> From: "Laszlo Ersek" In-Reply-To: <20240222115435.85794-3-kraxel@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: M940DPW3gJIj81Xl6ZNBy3fLx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=e5Ekv0yC; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On 2/22/24 12:54, Gerd Hoffmann wrote: > Move code to clear the page tables to a nasm macro. > No functional change. >=20 > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/ResetVector/Ia32/PageTables64.asm | 35 ++++++++++++----------- > 1 file changed, 19 insertions(+), 16 deletions(-) >=20 > diff --git a/OvmfPkg/ResetVector/Ia32/PageTables64.asm b/OvmfPkg/ResetVec= tor/Ia32/PageTables64.asm > index 6fec6f2beeea..378ba2feeb4f 100644 > --- a/OvmfPkg/ResetVector/Ia32/PageTables64.asm > +++ b/OvmfPkg/ResetVector/Ia32/PageTables64.asm > @@ -45,6 +45,24 @@ BITS 32 > %define TDX_BSP 1 > %define TDX_AP 2 > =20 > +; > +; For OVMF, build some initial page tables at > +; PcdOvmfSecPageTablesBase - (PcdOvmfSecPageTablesBase + 0x6000). > +; > +; This range should match with PcdOvmfSecPageTablesSize which is > +; declared in the FDF files. > +; > +; At the end of PEI, the pages tables will be rebuilt into a > +; more permanent location by DxeIpl. > +; > +%macro ClearOvmfPageTables 0 > + mov ecx, 6 * 0x1000 / 4 > + xor eax, eax > +.clearPageTablesMemoryLoop: > + mov dword[ecx * 4 + PT_ADDR (0) - 4], eax > + loop .clearPageTablesMemoryLoop > +%endmacro > + > ; > ; Modified: EAX, EBX, ECX, EDX > ; Ah, this made me read up on local labels: https://www.nasm.us/xdoc/2.16.01/html/nasmdoc3.html#section-3.9 Should we rather call the label ..@clearPageTablesMemoryLoop ? According to the documentation, that seems to be the safest / most robust label type to be used inside macros. Reviewed-by: Laszlo Ersek Thanks Laszlo > @@ -69,22 +87,7 @@ SetCr3ForPageTables64: > OneTimeCall GetSevCBitMaskAbove31 > =20 > ClearOvmfPageTables: > - ; > - ; For OVMF, build some initial page tables at > - ; PcdOvmfSecPageTablesBase - (PcdOvmfSecPageTablesBase + 0x6000). > - ; > - ; This range should match with PcdOvmfSecPageTablesSize which is > - ; declared in the FDF files. > - ; > - ; At the end of PEI, the pages tables will be rebuilt into a > - ; more permanent location by DxeIpl. > - ; > - > - mov ecx, 6 * 0x1000 / 4 > - xor eax, eax > -clearPageTablesMemoryLoop: > - mov dword[ecx * 4 + PT_ADDR (0) - 4], eax > - loop clearPageTablesMemoryLoop > + ClearOvmfPageTables > =20 > ; > ; Top level Page Directory Pointers (1 * 512GB entry) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116080): https://edk2.groups.io/g/devel/message/116080 Mute This Topic: https://groups.io/mt/104506789/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-