From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 14F55941934 for ; Tue, 14 Nov 2023 15:12:17 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=t7TJmQowpmSsfjnpXT20qPZNoNw6QqqJeZ7dWz9kqhk=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699974736; v=1; b=FjYNTNdwkewlTGjs8p9jzV/7EZhBcMm89gq0cfF/preobjnXw1OttVbE/+3Ztpg4G3LEr+M+ bZDm9enKnnlcvP9m06+cNOeKvo//voet9s5EzruTCPJPowkxFSPzO7aC1o6y4ATeYaMh/R1KVST ASe6MAdmTc0NR8JKSlPcBSN8= X-Received: by 127.0.0.2 with SMTP id ECqoYY7687511xFfrioVM0p7; Tue, 14 Nov 2023 07:12:16 -0800 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.113]) by mx.groups.io with SMTP id smtpd.web10.14924.1699974735720209591 for ; Tue, 14 Nov 2023 07:12:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A9l+1w/lRIgpjmuQ2vxCl3OLdHQRpaW+cbADO/RFUhthPeTVED8N0qSykjz4+Vt/nkz9Vn+YZBNz/EvjA0hfJuDvFB0w6afwRndoYi8oc6vRJxH4qNsWD9xR0JQtrR959q3+XuzigCmQNtwudbJTAuvMfkwKhrU45+9gSlG0W3Z4a/gbgQOLeNOEOTAY+m3QSCqbNcA3k45zGQZ0qFmm5DSJCxfHofYbh9eUEExmsLS+BF7vr8xV+40VaUPq1dkewzPkt0JSQlty9shrwcuQv97f8+pLdxB8cg03WdgpR2xG1XBwzNZEF5IOiacz79ZAm5aYhQqwSvYpJ+bT59Zflg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=903ydfhW0MCcwSyOOJxt3Hql1C4/tRHZKIXNvurbnoU=; b=ElazECvZRfxTrCsYNmFD1vU0D6Ho3OULa2B5uaHz4ipal73hBHggdd1sPlWgyJnmhgxVqWKM5nQu4kZZ9DdjCWF965qPzJP33SVNEeK9eLxsF1L0fmpqkSaclG1KUtGnz8DGOx7VXraSyD/XMj0XPUsARegsUqbtC8H8SLoLczRS48VSaMWCBNG9NUTx2IAzNdHCO+C3pAIHkPrpBk/GUhN1RbJ62r6wvvTv3XnUx9e2DNl6EF3eP8FX7NpcTflTfaClaD876q0AWtdU2E/qq0MrW0JjXlTT3QPPmVxNIHK5JcXmGSxndhEJrJbl8HvEENVT/Q1gSEb0gGeSg8Y/Ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) by BL3PR01MB7131.prod.exchangelabs.com (2603:10b6:208:33a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.17; Tue, 14 Nov 2023 15:12:13 +0000 X-Received: from LV3PR01MB8464.prod.exchangelabs.com ([fe80::4c29:e7d7:223d:5187]) by LV3PR01MB8464.prod.exchangelabs.com ([fe80::4c29:e7d7:223d:5187%7]) with mapi id 15.20.7002.015; Tue, 14 Nov 2023 15:12:13 +0000 Message-ID: <45488f96-0251-4cb4-9816-11733aeeb501@os.amperecomputing.com> Date: Tue, 14 Nov 2023 08:12:06 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] edk2 uncrustify update (73.0.8)? To: devel@edk2.groups.io, lersek@redhat.com, Pedro Falcato Cc: Michael Kubacki , Michael Kinney , Andrew Fish , Marcin Juszkiewicz , "Leif Lindholm (Quic)" References: <0107c96b-849a-db48-194b-1a4c1f3b0c78@redhat.com> From: "Rebecca Cran via groups.io" In-Reply-To: X-ClientProxiedBy: CH2PR10CA0004.namprd10.prod.outlook.com (2603:10b6:610:4c::14) To LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV3PR01MB8464:EE_|BL3PR01MB7131:EE_ X-MS-Office365-Filtering-Correlation-Id: 50c711ae-9844-4c19-25fb-08dbe52414a1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: BpMMFWKxyJqa4II8abYtBlgqds/Z6nLgQf3tAbpZ6meXFBAfTmNtDfHE5Ng7rCoVPi6aKXCvKF4rb2+4sacFWPA0h/MT/c6lNiEk+B7EjuqoZZ1SWbvo+Ay6KBYYLFxhPSA7iy2MgvSuw5FGsMYX7hB7wvU4dqE1Yx7J7RWx8uhZ3mAE3UpRV/dEhU+ELtvvP+ktGup71I5+zPt0tV2hLzqwcKv9VVaCzmL39ghiviaONOgYrmkdezIaUBjJ0NNIRE0cDLmVGZSpJ8qU7QBkUlhWCQnvmPGmI/B/Um5W7OsCbSJM92B0AXVEDc/TGxhNdebXABQmABk//c84ye8KxoB04JXcwYDlU0KCRYHNF3JVvSaq6twIZ1u4JTYl9Prk7az3QSN6RB20fVOEqxw/d6uqPktSIyIVII5nQ1oynt9H9A2w28bobLDp1J2L5qGEExn7MX/DnwrqLESVztI+vZWmo6DbVlFByIVvaB3sHUeNMUZbKPerCE6zXsDue09dX4BsvPpN+h1qmnMN2CEtgvOtkvlpwDiex+bsK01+/Duo41RFQGFpTYSy1zenVktKSZ5NyJtYV5iXyfQvM8TDYaY3HoV4Yi+jPiOrPRAYRl77YA2aOU5wYzIkCChbqsUq X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0xUNlVXNjNpbCtRMUYzV0V5bmh6eDl1ZWVNYXVzM2U2a3JMemFleTN6Mm9z?= =?utf-8?B?alpCMUp4MExZc1gydHBObytpdGlQanNNV29mbDM5NmJLUDZqM25NVVVtRVdv?= =?utf-8?B?enpGMWdvUXM5LzFpVmJTYWJ4MTVVcFZaaXBONDBWa3JYNHhlVVZKY0JrZjRB?= =?utf-8?B?bXBiWFlMTlp4NWgwSm1rMWJ5VnM1VExGSkdOblBzaWg2TXFKdXJYNS8rdXhE?= =?utf-8?B?eXc0T2tpOGtSbzJhV0c0VGZyT2VqdU5sd25DQm4wZ2JGdnVnT1VJbVo5a0ZG?= =?utf-8?B?TGJua2ZKVWYrdDkvZHJUbnNjdURUbno4UUsrbXBVR2k0MCtSdFJWTU1XK1p1?= =?utf-8?B?NkpEL2dOMEVtRDMzUXVQNEpsOXJHQ1hUUDJEMEZwZW12NS84UnJIS2hGYXNz?= =?utf-8?B?MndjWjhTYU9WTnZzK2kzYUx1amQxNGVDRCtwNlN4R05VREFZbDlEaStFRW5t?= =?utf-8?B?cEo2M3E4OUZEQ1JYd2U4cTk5eC9MVzZiRW9oV0ZDMzZvbml1dWdmWjFXSjdr?= =?utf-8?B?VzZYUHB6Ry9vb1NjYkJkdUhOWUlNZWRNU0VFU0p2cm5jWllRNzdiZjhQcFZu?= =?utf-8?B?ZzFpQkh6Znh3S2trUnhSV0tlV094L09ZQ3VjRnZCWDNVWTZCRkhiNGxkNTJa?= =?utf-8?B?ZXlYK2VxdGptZStwNDI2TFVwQlFYTnl3U1JrMnFFb0tOWHZOY29vM2ZMbFJ6?= =?utf-8?B?WFNwV2U0eGFPSU9ocDBJQlpEMWw5U1JWME9UQll0UnJid1p1Sy8xSkxkWmRF?= =?utf-8?B?bkZiakQyMDQydU5aejA4czBPaGwyN214d0NmbjR1dGtrNVdTWUJybUl0YzM5?= =?utf-8?B?b21TZVlGRjRmZGEvczF0bmxGcHFYTGtkOFhjb0gxTjJMUUdiUGhKRXo5R3ps?= =?utf-8?B?eFlndE55M0FCUmx1U3REdDgrWHAyU09hRk1IVU1SSSsvTkhESk9Tc1FWbUhn?= =?utf-8?B?MjdQNjlqODFmZDN1WkNRbERTMTNRZ3JkeC9RelZkYkVOUUVOYTZ3TWtmWDgy?= =?utf-8?B?YjBKWTRyVGp3VmtibE5vSnBRclJXdDZJQmhHM05nU3pVOUpxZFREUWMva2x5?= =?utf-8?B?MEhKT3pOek0rYm5nOGl1bXFXb0ZBYXdiSTR2ZExrT2FuODlXM2MrakdGRElB?= =?utf-8?B?N0FKQnFrUXRqZmNzYno3ekhRbHVGYXlCVmpDSkx1OE16MHlRUC9uZ0dvTDZp?= =?utf-8?B?VFU2NUFqbnVUU0ZMMkFEYzhSNjhVUlE3N3dFYlJ6MWR2dG9tUWNhNXd0OThs?= =?utf-8?B?RktkbVByb1VUY3lvdWlMcGdlM04zcDBLcit2SUJJaTZWV1BkVXJKc0xIZ0Jn?= =?utf-8?B?ZlB0UWtqRHQyZkQ1RnVRN2pxWVNrTkdFOURTRU5rekFBSzAvMmxCUFBlc1lN?= =?utf-8?B?NjV4UzZabmNxUjNHdGFodW0wdzFUZzQrSGEzS0VzS2dGRmJ4TDRWdWxCaWlE?= =?utf-8?B?UzJwM3hENGs2WjhGR3VxdndFajVPZmpCTzFRYTlVa2RsT3N1SjFsTm9ZQXVq?= =?utf-8?B?K3JFQXlmZEdTYlhqL01uelNWOTdXVWZQVVl4dk5kYWUvU2NZWDUvMFFrUFJO?= =?utf-8?B?eHRFcitGU00xU0J1U1ZLZHJQZjR2N0ljb3NtekNGZmlSOGgxdFRUR2tEcGoy?= =?utf-8?B?ZEpRK2NpTFlTU3lzNzlJTEZPVHNOWGE0WndaUTFZQmU0RjNXRkNoUHdPNU5i?= =?utf-8?B?dVQ0a2ZxUnVWOGpDa2txL2lOL2NJQlFnZnBpZzR2enNZdkVhZHlqQmRsTXIv?= =?utf-8?B?VGVqeTNsMEZrUldLN3JEUG1aektqWW12MFpyK0h3M3lreG5BeStueHR3d2ZD?= =?utf-8?B?eFpIS3VNcVVMcytZMTZDY2hxUVVxNUVZcTR3ZHlaaU9qSmY2dWllQ1FqRzhE?= =?utf-8?B?RjNqc3MzZlBGRGhFL0VmVmJFbHZzTTF3bk03Umh2MnluakNDS0dpQ2EvQ0w5?= =?utf-8?B?Y0VTbmxxS0VZL1VyUlNYUjNzOWxSVFFDM3BFY00vbjh2Rit5MVJnNVk2LzVj?= =?utf-8?B?MnNhN28zWUhOM1VuZFNnTGh1ZlFvM3BtdzIxMVN5VE5RODJOSnZSRGM1Q1lU?= =?utf-8?B?amxORVhJMnAvZTZ3YXBieUN1QWZlNEszMVlycmxCU1JCcTZrTzdUTGtkb3BQ?= =?utf-8?B?VVY0RzMrYnNZNzlUKzJrN0xsbXV4Znh5ZUpXRXpBYmhwN3MwMExoZFNWSWdj?= =?utf-8?Q?dTvwIaUq+QhmJMjJyw1txRc=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50c711ae-9844-4c19-25fb-08dbe52414a1 X-MS-Exchange-CrossTenant-AuthSource: LV3PR01MB8464.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2023 15:12:13.2057 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: n7Pr7GwrsAaJLB7ZKYeY+2RWRBFljSujcEsbF5sVzqonwlITN2Ff9lWoJixAJyPbAo+YFszzarElpJSvCdoPXhEN5I/5o8OIaO0FVazh3wsMXlg2XPMlkOPSge1+iRXu X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR01MB7131 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 8T62Gjggp8KZf6eTn57Uoza4x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=FjYNTNdw; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 11/14/2023 7:51 AM, Laszlo Ersek via groups.io wrote: > Funnily enough, my stance is quite the opposite. I happen to disagree > with some patterns that uncrustify enforces, but I'm thankful that at > any given state of CI (=3D using any given version of uncrustify), we > can't have any more debates about patch formatting (that is, it's > especially its central nature that I like). I've found uncrustify > relatively easy to use locally, too. There's _one_ place we can still have a debate, but I'm hoping we can=20 easily agree, and update CI to enforce it. I'd like to scrub the tree of all the NT-style function documentation=20 blocks and replace them with Doxygen style. As an example of the NT style, see OvmfPkg/QemuVideoDxe/Gop.c: EFI_STATUS EFIAPI QemuVideoGraphicsOutputQueryMode ( IN EFI_GRAPHICS_OUTPUT_PROTOCOL *This, IN UINT32 ModeNumber, OUT UINTN *SizeOfInfo, OUT EFI_GRAPHICS_OUTPUT_MODE_INFORMATION **Info ) /*++ Routine Description: Graphics Output protocol interface to query video mode Arguments: This - Protocol instance pointer. ModeNumber - The mode number to return information on. Info - Caller allocated buffer that returns=20 information about ModeNumber. SizeOfInfo - A pointer to the size, in bytes, of the=20 Info buffer. Returns: EFI_SUCCESS - Mode information returned. EFI_BUFFER_TOO_SMALL - The Info buffer was too small. EFI_DEVICE_ERROR - A hardware error occurred trying to=20 retrieve the video mode. EFI_NOT_STARTED - Video display is not initialized. Call=20 SetMode () EFI_INVALID_PARAMETER - One of the input args was NULL. --*/ { QEMU_VIDEO_PRIVATE_DATA *Private; QEMU_VIDEO_MODE_DATA *ModeData; ... -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111203): https://edk2.groups.io/g/devel/message/111203 Mute This Topic: https://groups.io/mt/102559740/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-