From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3A335D80C7F for ; Fri, 1 Mar 2024 17:18:25 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=C8LG2rQM4HPI/RT+G2V9eaBB1KRKXix+jY9MqUnv+M4=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1709313503; v=1; b=Ci2HuSZ0dEbzw3lJgui3cprvzgA9GK9HdT6yzV9T2FAty+4XscGyrnhpGyuq5QhRnxcphBeg osQIH77Ft922Rpv7+f/Vj9H4hJ/YmWBpYOZ6TNklwKsdn4ZLGzmPA2E5tohocl2XVXwvCknkDsP oKScFEH8tg+gXDCc3FZGn5uY= X-Received: by 127.0.0.2 with SMTP id crkcYY7687511xEM7gYElvw3; Fri, 01 Mar 2024 09:18:23 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.29220.1709313503276487762 for ; Fri, 01 Mar 2024 09:18:23 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-1vl6RflON4CswijxjEY2nw-1; Fri, 01 Mar 2024 12:18:19 -0500 X-MC-Unique: 1vl6RflON4CswijxjEY2nw-1 X-Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 27A18832C12; Fri, 1 Mar 2024 17:18:18 +0000 (UTC) X-Received: from [10.39.194.215] (unknown [10.39.194.215]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A20C539D6D; Fri, 1 Mar 2024 17:18:16 +0000 (UTC) Message-ID: <454f81b7-a596-1f06-9fbc-77425884a0ce@redhat.com> Date: Fri, 1 Mar 2024 18:18:15 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v2 09/10] OvmfPkg/ResetVector: leave SEV VC handler installed longer To: devel@edk2.groups.io, kraxel@redhat.com Cc: Jiewen Yao , Oliver Steffen , Michael Roth , Erdem Aktas , Min Xu , Ard Biesheuvel , Tom Lendacky References: <20240301074402.98625-1-kraxel@redhat.com> <20240301074402.98625-10-kraxel@redhat.com> <3kazdjorbbsvwsutvfzhbgwpvcauwx65d2oe6j4t7wue3gvrb7@as3lvlcf7rqe> From: "Laszlo Ersek" In-Reply-To: <3kazdjorbbsvwsutvfzhbgwpvcauwx65d2oe6j4t7wue3gvrb7@as3lvlcf7rqe> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: xBOPu8c1r33zwHF17oleIKnKx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Ci2HuSZ0; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On 3/1/24 15:52, Gerd Hoffmann wrote: > Hi, >=20 >>> OneTimeCall CheckSevFeatures >>> + cmp byte[WORK_AREA_GUEST_TYPE], 1 >>> + jnz NoSevIa32 >>> + OneTimeCall SevClearVcHandlerAndStack >>> =20 >>> +NoSevIa32: >>> ; >>> ; Restore initial EAX value into the EAX register >>> ; >> >> Did you miss Tom's review under v1? >> >> https://edk2.groups.io/g/devel/message/116176 >=20 > Saw the mail only after sending out v2, updated my local branch > meanwhile. >=20 >> I'm ready to merge this (adding Tom's R-b, if you, Gerd, confirm that >> that's what you want). >=20 > As stated in the cover letter I think it's better to not (yet) merge > patches 9+10 because BaseMemEncryptSevLib is not ready for 5-level > paging. That way SEV will work fine (in 4-level paging mode) even when > building with PcdUse5LevelPageTable=3DTRUE. Got it! Laszlo >=20 > thanks & take care, > Gerd >=20 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116279): https://edk2.groups.io/g/devel/message/116279 Mute This Topic: https://groups.io/mt/104660115/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-