From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1716621B02822 for ; Tue, 20 Nov 2018 17:50:38 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2018 17:50:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,259,1539673200"; d="scan'208";a="282851106" Received: from shzintpr03.sh.intel.com (HELO [10.253.24.20]) ([10.239.4.100]) by fmsmga006.fm.intel.com with ESMTP; 20 Nov 2018 17:50:36 -0800 To: "Gao, Liming" , Laszlo Ersek , Gary Lin , "edk2-devel@lists.01.org" Cc: "Kinney, Michael D" , star.zeng@intel.com References: <20181120070311.32449-1-glin@suse.com> <04655d89-415d-8442-2751-00d9bb8c37fb@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E36F380@SHSMSX104.ccr.corp.intel.com> From: "Zeng, Star" Message-ID: <45590998-1453-39e1-a9b6-8013fb4861dd@intel.com> Date: Wed, 21 Nov 2018 09:50:05 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E36F380@SHSMSX104.ccr.corp.intel.com> Subject: Re: [PATCH 1/1] MdePkg ACPI: fix the typos in Acpi61.h and Acpi62.h X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 01:50:38 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 2018/11/20 22:37, Gao, Liming wrote: > Reviewed-by: Liming Gao > >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek >> Sent: Tuesday, November 20, 2018 4:52 PM >> To: Gary Lin ; edk2-devel@lists.01.org >> Cc: Kinney, Michael D ; Gao, Liming >> Subject: Re: [edk2] [PATCH 1/1] MdePkg ACPI: fix the typos in Acpi61.h and Acpi62.h >> >> On 11/20/18 08:03, Gary Lin wrote: >>> The GUID for VIRTUAL_CD_REGION_PERSISTENT was using the closing >>> square bracket mistakenly. >>> >>> Cc: Michael D Kinney >>> Cc: Liming Gao >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Gary Lin >>> --- >>> MdePkg/Include/IndustryStandard/Acpi61.h | 2 +- >>> MdePkg/Include/IndustryStandard/Acpi62.h | 2 +- >>> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> Good catch! >> >> Reviewed-by: Laszlo Ersek Reviewed-by: Star Zeng Thanks, Star >> >> Thanks >> Laszlo >> >>> diff --git a/MdePkg/Include/IndustryStandard/Acpi61.h b/MdePkg/Include/IndustryStandard/Acpi61.h >>> index b2276b7d64d5..c66566e58647 100644 >>> --- a/MdePkg/Include/IndustryStandard/Acpi61.h >>> +++ b/MdePkg/Include/IndustryStandard/Acpi61.h >>> @@ -1400,7 +1400,7 @@ typedef struct { >>> #define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGION_VOLATILE { 0x77AB535A, 0x45FC, 0x624B, >> { 0x55, 0x60, 0xF7, 0xB2, 0x81, 0xD1, 0xF9, 0x6E }} >>> #define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_VOLATILE { 0x3D5ABD30, 0x4175, 0x87CE, >> { 0x6D, 0x64, 0xD2, 0xAD, 0xE5, 0x23, 0xC4, 0xBB }} >>> #define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGION_PERSISTENT { 0x5CEA02C9, 0x4D07, 0x69D3, >> { 0x26, 0x9F ,0x44, 0x96, 0xFB, 0xE0, 0x96, 0xF9 }} >>> -#define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_PERSISTENT { 0x08018188, 0x42CD, 0xBB48, >> { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D ]} >>> +#define EFI_ACPI_6_1_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_PERSISTENT { 0x08018188, 0x42CD, 0xBB48, >> { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D }} >>> typedef struct { >>> UINT16 Type; >>> UINT16 Length; >>> diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h b/MdePkg/Include/IndustryStandard/Acpi62.h >>> index 730365b521d1..11ce1c16fb91 100644 >>> --- a/MdePkg/Include/IndustryStandard/Acpi62.h >>> +++ b/MdePkg/Include/IndustryStandard/Acpi62.h >>> @@ -1512,7 +1512,7 @@ typedef struct { >>> #define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGION_VOLATILE { 0x77AB535A, 0x45FC, 0x624B, >> { 0x55, 0x60, 0xF7, 0xB2, 0x81, 0xD1, 0xF9, 0x6E }} >>> #define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_VOLATILE { 0x3D5ABD30, 0x4175, 0x87CE, >> { 0x6D, 0x64, 0xD2, 0xAD, 0xE5, 0x23, 0xC4, 0xBB }} >>> #define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_DISK_REGION_PERSISTENT { 0x5CEA02C9, 0x4D07, 0x69D3, >> { 0x26, 0x9F ,0x44, 0x96, 0xFB, 0xE0, 0x96, 0xF9 }} >>> -#define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_PERSISTENT { 0x08018188, 0x42CD, 0xBB48, >> { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D ]} >>> +#define EFI_ACPI_6_2_NFIT_GUID_RAM_DISK_SUPPORTING_VIRTUAL_CD_REGION_PERSISTENT { 0x08018188, 0x42CD, 0xBB48, >> { 0x10, 0x0F, 0x53, 0x87, 0xD5, 0x3D, 0xED, 0x3D }} >>> typedef struct { >>> UINT16 Type; >>> UINT16 Length; >>> >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel