From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, michael.d.kinney@intel.com,
"ryszard.knop@linux.intel.com" <ryszard.knop@linux.intel.com>,
"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>
Cc: Andrew Fish <afish@apple.com>, Rebecca Cran <rebecca@bsdio.com>,
Philippe Mathieu-Daude <philmd@redhat.com>
Subject: Re: [edk2-devel] [PATCH edk2-CCSS 0/3] Coding Standards: add rule for documenting spurious variable assignments
Date: Wed, 18 Sep 2019 12:18:13 +0200 [thread overview]
Message-ID: <457a219e-9df0-26d5-fa0f-3174692c1d7d@redhat.com> (raw)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5B9DC24E1@ORSMSX113.amr.corp.intel.com>
On 09/17/19 21:10, Michael D Kinney wrote:
> Series Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
>
> I also agree that the macros would be cleaner, easy to review, and
> and fewer lines of code without the comment block. If I objected
> previously, then I have also changed my mind. I agree we can go
> ahead and push the series in its current form and continue the
> discussion on the macros.
Thank you all for the help, I've pushed the series:
d096859f15b9..f5ad35ec2c6d
Cheers,
Laszlo
prev parent reply other threads:[~2019-09-18 10:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 18:38 [PATCH edk2-CCSS 0/3] Coding Standards: add rule for documenting spurious variable assignments Laszlo Ersek
2019-09-05 18:38 ` [PATCH edk2-CCSS 1/3] comments: remove "Horror Vacui" rule Laszlo Ersek
2019-09-05 18:38 ` [PATCH edk2-CCSS 2/3] comments: restrict and clarify applicability of "/*" comments Laszlo Ersek
2019-09-06 8:00 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-05 18:38 ` [PATCH edk2-CCSS 3/3] must comment: add rule for documenting spurious variable assignments Laszlo Ersek
2019-09-06 8:13 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-09 12:25 ` Laszlo Ersek
2019-09-09 13:35 ` Philippe Mathieu-Daudé
2019-09-06 12:26 ` [PATCH edk2-CCSS 0/3] Coding Standards: " Leif Lindholm
2019-09-09 12:35 ` Laszlo Ersek
2019-09-10 15:33 ` Leif Lindholm
2019-09-10 15:44 ` [edk2-devel] " Ryszard Knop
2019-09-11 17:51 ` Laszlo Ersek
2019-09-17 19:10 ` Michael D Kinney
2019-09-18 10:18 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=457a219e-9df0-26d5-fa0f-3174692c1d7d@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox