From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Wed, 18 Sep 2019 03:18:21 -0700
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 6D54A10C0928;
	Wed, 18 Sep 2019 10:18:20 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-2.rdu2.redhat.com [10.10.120.2])
	by smtp.corp.redhat.com (Postfix) with ESMTP id D1CF160872;
	Wed, 18 Sep 2019 10:18:15 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH edk2-CCSS 0/3] Coding Standards: add rule for documenting spurious variable assignments
To: devel@edk2.groups.io, michael.d.kinney@intel.com,
 "ryszard.knop@linux.intel.com" <ryszard.knop@linux.intel.com>,
 "leif.lindholm@linaro.org" <leif.lindholm@linaro.org>
Cc: Andrew Fish <afish@apple.com>, Rebecca Cran <rebecca@bsdio.com>,
 Philippe Mathieu-Daude <philmd@redhat.com>
References: <20190905183820.10312-1-lersek@redhat.com>
 <20190906122623.GS29255@bivouac.eciton.net>
 <54fb3783-7589-feff-e446-1e592686d7d2@redhat.com>
 <20190910153304.GD15201@bivouac.eciton.net>
 <57976eb87976eba0e18f70726ad1813f440e7acf.camel@linux.intel.com>
 <4fcb4e8d-94e6-430d-dac4-450b166c7f1e@redhat.com>
 <E92EE9817A31E24EB0585FDF735412F5B9DC24E1@ORSMSX113.amr.corp.intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <457a219e-9df0-26d5-fa0f-3174692c1d7d@redhat.com>
Date: Wed, 18 Sep 2019 12:18:13 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5B9DC24E1@ORSMSX113.amr.corp.intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.66]); Wed, 18 Sep 2019 10:18:20 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 09/17/19 21:10, Michael D Kinney wrote:
> Series Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> 
> I also agree that the macros would be cleaner, easy to review, and
> and fewer lines of code without the comment block.  If I objected
> previously, then I have also changed my mind.  I agree we can go
> ahead and push the series in its current form and continue the
> discussion on the macros.

Thank you all for the help, I've pushed the series:

d096859f15b9..f5ad35ec2c6d

Cheers,
Laszlo