public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sean" <spbrogan@outlook.com>
To: Michael D Kinney <michael.d.kinney@intel.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v1 2/4] .pytool/Plugin/UncrustifyCheck: Add ignore file support
Date: Fri, 01 Apr 2022 10:45:19 -0700	[thread overview]
Message-ID: <4584.1648835119520240314@groups.io> (raw)
In-Reply-To: <SA2PR11MB493830856A070A45F630E88ED2179@SA2PR11MB4938.namprd11.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 436 bytes --]

In regard to the "nofile.txt"
That parameter is used for reporting which file specified the ignore list.  This was a feature of the gitignore parser that was integrated but that "report" is never used.  Thus, in the additional api I added where I enabled the ignore content in a parameter rather than file, I "shimmed" it using nofile.txt as an indicator that this came from parameter.

Hope that helps explain why.
Thanks
Sean

[-- Attachment #2: Type: text/html, Size: 494 bytes --]

  parent reply	other threads:[~2022-04-01 17:45 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-22  1:58 [PATCH v1 0/4] UncrustifyCheck Ignore Support Michael Kubacki
2022-03-22  1:58 ` [PATCH v1 1/4] .pytool/Plugin/UncrustifyCheck: Update func to return absolute paths Michael Kubacki
2022-03-22 16:07   ` [edk2-devel] " Michael D Kinney
2022-03-22 16:12     ` Michael D Kinney
2022-04-01 16:22       ` Michael Kubacki
2022-03-22  1:58 ` [PATCH v1 2/4] .pytool/Plugin/UncrustifyCheck: Add ignore file support Michael Kubacki
2022-03-22 16:14   ` Michael D Kinney
2022-04-01 16:07     ` [edk2-devel] " Michael Kubacki
2022-04-01 16:50       ` Michael D Kinney
2022-04-01 17:45     ` Sean [this message]
2022-04-03 17:32       ` Michael D Kinney
2022-03-22  1:58 ` [PATCH v1 3/4] OvmfPkg: Revert Uncrustify formatting in VbeShim.h files Michael Kubacki
2022-03-22  6:34   ` Laszlo Ersek
2022-03-22  8:45   ` [edk2-devel] " Gerd Hoffmann
2022-03-22  1:58 ` [PATCH v1 4/4] OvmfPkg: Do not check VbeShim.h formatting with Uncrustify Michael Kubacki
2022-03-22  6:35   ` Laszlo Ersek
2022-03-22  8:46   ` [edk2-devel] " Gerd Hoffmann
2022-03-22 16:14 ` [PATCH v1 0/4] UncrustifyCheck Ignore Support Michael D Kinney
2022-04-01 16:04   ` [edk2-devel] " Michael Kubacki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4584.1648835119520240314@groups.io \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox