Re: [edk2-devel] [edk2-platforms] Enable GitHub PR, protected branches, and 'push' label

["Rebecca Cran" <rebecca@bsdio.com>]

Talking about mailing lists, I'm still disappointed that we lost so much 
history of discussion and reviews around the project when the edk2-devel 
archive at lists.01.org was deleted.

I've sometimes wanted to go back and take a look at the review history 
of a certain commit only to find it's been lost.


-- 
Rebecca Cran


On 3/17/23 3:33 AM, Gerd Hoffmann wrote:
> On Thu, Mar 16, 2023 at 01:59:49PM -0600, Rebecca Cran wrote:
>> Is this still a requirement since Laszlo's departure from the project?
>>
>> I seem to recall it was him who made it a sticking point of moving to a
>> GitHub PR workflow originally with the requirement to have emails of
>> everything.
> I think it is very useful to have everything on the mailing list for
> a number of reasons:
>
>   (1) In my experience reviewing patches, especially more complex ones,
>       works better in email than in github PR workflows.
>   (2) github doesn't preserve stuff like a mail archive does.  When a
>       patch series goes through multiple revision github only preserves
>       the latest revision which was actually merged.
>   (3) Search engines seem to be better in indexing mail list archives
>       than github pull requests.
>
> Nevertheless I see some room for improvement in our current workflow.
> Developers often open a PR anyway for to run the CI.  So maybe we could
> automate sending the emails and also avoid running CI twice by avoiding
> both developer and maintainer opening a PR, with a workflow like this:
>
>   * developer opens a draft PR to run CI for the patch series.
>   * when the series passes CI and is ready un-draft the PR.
>   * github action sends the patch series to the edk2-devel list
>     for review (maybe only after CI passed ...).
>   * patch review happens on the list.
>   * in case the developer pushes updates to the branch in response to
>     review comments the github action posts v2/v3 of the series too.
>   * once review is done merge the PR.
>
> take care,
>    Gerd
>