From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mx.groups.io with SMTP id smtpd.web10.16252.1679050100360966249 for ; Fri, 17 Mar 2023 03:48:20 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm3 header.b=QtX8LjPf; spf=pass (domain: bsdio.com, ip: 64.147.123.20, mailfrom: rebecca@bsdio.com) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 58A6D3200201; Fri, 17 Mar 2023 06:48:17 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 17 Mar 2023 06:48:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1679050096; x=1679136496; bh=Fvhw0ngdomaPEZUN1JXNDluELuH3wF3t7QW 19L3DuEU=; b=QtX8LjPfNBFS1sjQOW63UcVNMs/XQY6yxz8HzyisUDiRQRGrPdD qjsH7G2CpuvDy/Pff3gOCXKia9PFwoa0WsfdI7Bn78sOEsFN4B4DsCA8vt4umtEZ d00dfx8mOmbg8wOMnSpI+7FUjDQd9rV+fP2kAuvoEXvxtCSw31vo9qEG07vh4tdB 4OESsNeNb3oFx1ulCKI0qGIfM2oMKbf7jJ3HiM9PGC7tIdVX3SOd94ppKfkz5jff 5b057JO9OIhrV96HWw31t5OR/zvYLcmzBOnjWkZmHeVo+d+6yAl3LSNCu+c0MbIg NPoShAe0eV/x/Or9QEr+aQbAqZLZKWAVFWw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1679050096; x=1679136496; bh=Fvhw0ngdomaPEZUN1JXNDluELuH3wF3t7QW 19L3DuEU=; b=uyOMWlWGZrDOyUEbqNtf5/M16pL/KoE9a4J6SFSCz7421Y/z9AN YxkfzCEn6jsKuamqSn4OKyssg0GVTTwahJBGjSCLhi1DN/kvHlrFQuFLMXVYWtCy apGFrBSMz2bsbK/xfsBH8KnhEq+6dWYlJeOtNZPQhes661r9MigN3UrUIkxUMdhs EEjCibFDUPUAfR+vLpD/QP9h9ZCRiyAt0w+ZVV8SLxoT3a/6anxL1ziTSuqfUWs9 Gww7CqfWO59xKSWOqWutYYF5oEXsJ3Sg7aBkJ+c9F/ANSrr0OJ58Byq7dtVZF4f7 9HBVVF+jTw/Og1CLVcbXkuPnGk9t/1HkJgw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdefvddgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefkffggfgfuvfevfhfhjggtgfesth ejredttdefjeenucfhrhhomheptfgvsggvtggtrgcuvehrrghnuceorhgvsggvtggtrges sghsughiohdrtghomheqnecuggftrfgrthhtvghrnhepgfdugeeiffegudfhjeejleeuvd eujeetieelheffffehvdfftdffudevkedvleelnecuffhomhgrihhnpedtuddrohhrghen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehrvggsvg gttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 17 Mar 2023 06:48:16 -0400 (EDT) Message-ID: <45969938-96c1-0fa6-b39f-61b7df2e0a03@bsdio.com> Date: Fri, 17 Mar 2023 04:48:15 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [edk2-devel] [edk2-platforms] Enable GitHub PR, protected branches, and 'push' label To: Gerd Hoffmann , devel@edk2.groups.io Cc: michael.d.kinney@intel.com, =?UTF-8?Q?Marvin_H=c3=a4user?= References: <1336.1678919068042837404@groups.io> <20230317093347.gi65s3qu5vzzilzn@sirius.home.kraxel.org> From: "Rebecca Cran" In-Reply-To: <20230317093347.gi65s3qu5vzzilzn@sirius.home.kraxel.org> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Talking about mailing lists, I'm still disappointed that we lost so much history of discussion and reviews around the project when the edk2-devel archive at lists.01.org was deleted. I've sometimes wanted to go back and take a look at the review history of a certain commit only to find it's been lost. -- Rebecca Cran On 3/17/23 3:33 AM, Gerd Hoffmann wrote: > On Thu, Mar 16, 2023 at 01:59:49PM -0600, Rebecca Cran wrote: >> Is this still a requirement since Laszlo's departure from the project? >> >> I seem to recall it was him who made it a sticking point of moving to a >> GitHub PR workflow originally with the requirement to have emails of >> everything. > I think it is very useful to have everything on the mailing list for > a number of reasons: > > (1) In my experience reviewing patches, especially more complex ones, > works better in email than in github PR workflows. > (2) github doesn't preserve stuff like a mail archive does. When a > patch series goes through multiple revision github only preserves > the latest revision which was actually merged. > (3) Search engines seem to be better in indexing mail list archives > than github pull requests. > > Nevertheless I see some room for improvement in our current workflow. > Developers often open a PR anyway for to run the CI. So maybe we could > automate sending the emails and also avoid running CI twice by avoiding > both developer and maintainer opening a PR, with a workflow like this: > > * developer opens a draft PR to run CI for the patch series. > * when the series passes CI and is ready un-draft the PR. > * github action sends the patch series to the edk2-devel list > for review (maybe only after CI passed ...). > * patch review happens on the list. > * in case the developer pushes updates to the branch in response to > review comments the github action posts v2/v3 of the series too. > * once review is done merge the PR. > > take care, > Gerd >