From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44])
 by mx.groups.io with SMTP id smtpd.web12.62815.1595875547893960419
 for <devel@edk2.groups.io>;
 Mon, 27 Jul 2020 11:45:48 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@broadcom.com header.s=google header.b=ZEREyQsq;
 spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: broadcom.com, ip: 209.85.167.44, mailfrom: vladimir.olovyannikov@broadcom.com)
Received: by mail-lf1-f44.google.com with SMTP id k13so9599477lfo.0
        for <devel@edk2.groups.io>; Mon, 27 Jul 2020 11:45:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=broadcom.com; s=google;
        h=from:references:in-reply-to:mime-version:thread-index:date
         :message-id:subject:to:cc;
        bh=rJHojIwD+6mBQVqIhm8Ctr36rQPaDf49MtXhuIECG74=;
        b=ZEREyQsq724Pg1Ue+ofIewb8pbvrcfWLj0tKvdHHaoh03vxKCZkyQCOOPxdz08SJJ6
         08PTgXd8SU78if3DLzvsNz7mg+GOF2kmeEca7cXDDG5HN6CWn/jUOSdY24hTTbgg/9/I
         bBHGCRT9a3vFGy4A4p6kSAJi4IyQBYkvHO04U=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:from:references:in-reply-to:mime-version
         :thread-index:date:message-id:subject:to:cc;
        bh=rJHojIwD+6mBQVqIhm8Ctr36rQPaDf49MtXhuIECG74=;
        b=BLM6DmKRr+mVo+v/0GDEDp0ZPili9I5uqbnjxHnA7uqR3KgOloIIm0TuCRc5c5uYpf
         ACl97JH+WcANRZLyLzm57iHAis18moRRZICXsNoz+zYYjvR1j0cXSqDZVCG8LL/T9f7L
         b0NwvZk4aOdLpAHEFLZefxfUULN940vcV7wsB8wIxLxLa0gzde9/OkKQ14eNcFfF5gre
         RiGN3pawZxqTBGLaI5iEbuV/EnohXRAnCzdsTNjIHw87Exf+pjdfI1gYifaEttbBbBbC
         CbqE1eVh1KKRvb6sYj61QpYLKrP4qP3VZWdaqnm/vy8LzhiaLNfCaFGQ1/q9H8GOrohM
         2kVQ==
X-Gm-Message-State: AOAM532KvPGgz6lUvcyEpelNDej27s1/XWM8AGyTmyuJiv3TbGuO6DJC
	nwkruiLvTkfk5mjePptGMveMgVYOg3J9HS9RFRYPeQ==
X-Google-Smtp-Source: ABdhPJwnNQOBHmsrdm6QZ8RFVv6c5nO67YevzGiGrhPd1ctn92th6q5EAiqlb+HajGbRsxjIZt+/oWQ7wzpDwWJd8II=
X-Received: by 2002:a05:6512:2082:: with SMTP id t2mr12831243lfr.142.1595875546027;
 Mon, 27 Jul 2020 11:45:46 -0700 (PDT)
From: "Vladimir Olovyannikov" <vladimir.olovyannikov@broadcom.com>
References: <20200727164830.25829-1-vladimir.olovyannikov@broadcom.com> <8b8f82b5-1744-e64d-a7dd-a020f5d70e25@redhat.com>
In-Reply-To: <8b8f82b5-1744-e64d-a7dd-a020f5d70e25@redhat.com>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQILIYHslp9C8beoIeXBb+C1khe8nAGT8KleqKWpRMA=
Date: Mon, 27 Jul 2020 11:45:43 -0700
Message-ID: <45980f067e3ef39b9a04efcea8b1f0b3@mail.gmail.com>
Subject: Re: [PATCH v5 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand
To: Laszlo Ersek <lersek@redhat.com>, devel@edk2.groups.io
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>, Zhichao Gao <zhichao.gao@intel.com>, 
	Maciej Rabeda <maciej.rabeda@linux.intel.com>, Jiaxin Wu <jiaxin.wu@intel.com>, 
	Siyuan Fu <siyuan.fu@intel.com>, Ray Ni <ray.ni@intel.com>, 
	Liming Gao <liming.gao@intel.com>, Nd <nd@arm.com>
Content-Type: text/plain; charset="UTF-8"

> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Monday, July 27, 2020 10:40 AM
> To: Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>;
> devel@edk2.groups.io
> Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Zhichao
> Gao <zhichao.gao@intel.com>; Maciej Rabeda
> <maciej.rabeda@linux.intel.com>; Jiaxin Wu <jiaxin.wu@intel.com>; Siyuan
> Fu <siyuan.fu@intel.com>; Ray Ni <ray.ni@intel.com>; Liming Gao
> <liming.gao@intel.com>; Nd <nd@arm.com>
> Subject: Re: [PATCH v5 0/1] ShellPkg/DynamicCommand: add
> HttpDynamicCommand
>
> On 07/27/20 18:48, Vladimir Olovyannikov wrote:
> > Signed-off-by: Vladimir Olovyannikov
> > <vladimir.olovyannikov@broadcom.com>
> > Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Zhichao Gao <zhichao.gao@intel.com>
> > Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> > Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> > Cc: Siyuan Fu <siyuan.fu@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Nd <nd@arm.com>
> >
> > This patchset introduces an http client utilizing EDK2 HTTP protocol,
> > to allow fast image downloading from http/https servers.
> > HTTP download speed is usually faster than tftp.
> > The client is based on the same approach as tftp dynamic command, and
> > uses the same UEFI Shell command line parameters. This makes it easy
> > integrating http into existing UEFI Shell scripts.
> > Note that to enable HTTP download, feature Pcd
> > gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections must be set to
> TRUE.
> >
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2860
> >
> > PATCH v5 changes:
> > Address Laszlo's comments on patch v4:
> >  - Remove -m option as it introduced TimerLib dependency;
> >  - Drop "Tested-by" flags.
>
> Thanks! As I mentioned under v4, I'll delay my testing until there's some
> reviewer feedback too.
Yes, this makes sense as there could be other modifications required.
I hope this patch can be reviewed by maintainers sometime soon...
>
> Cheers!
> Laszlo
Thank you,
Vladimir