Re: [edk2-devel] [PATCH EDK2 v1 0/1] MdeModulePkg/TerminalDxe:Adding a switch for Terminal

["wenyi,xie" <xiewenyi2@huawei.com>]

Hi, Mike

Thank you for your reply. We add a PCD because we want to dynamic disable the terminal through setupbrowser.
But as you said, the standard way is using console variables to manage it. We did not think about it before, we will have a try.

Thanks
Wenyi


On 2022/10/11 21:58, Kinney, Michael D wrote:
> Hi,
> 
> Why is this new PCD and new behavior required?
> 
> There are standard ways from the UEFI Spec to manage
> the set of active console output devices using console
> variables.
> 
> Thanks,
> 
> Mike
> 
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of wenyi,xie via groups.io
>> Sent: Tuesday, October 11, 2022 4:13 AM
>> To: devel@edk2.groups.io; Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Gao, Zhichao
>> <zhichao.gao@intel.com>; Ni, Ray <ray.ni@intel.com>
>> Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com
>> Subject: [edk2-devel] [PATCH EDK2 v1 0/1] MdeModulePkg/TerminalDxe:Adding a switch for Terminal
>>
>> Main Changes :
>> 1.Adding a new PCD to control ternimal.
>>
>> Wenyi Xie (1):
>>   MdeModulePkg/TerminalDxe:Adding a switch for Terminal
>>
>>  MdeModulePkg/MdeModulePkg.dec                              | 4 ++++
>>  MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf | 1 +
>>  MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c      | 4 ++++
>>  3 files changed, 9 insertions(+)
>>
>> --
>> 2.20.1.windows.1
>>
>>
>>
>> 
>>
>