From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mx.groups.io with SMTP id smtpd.web08.18001.1665566656772953899 for ; Wed, 12 Oct 2022 02:24:17 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: huawei.com, ip: 45.249.212.255, mailfrom: xiewenyi2@huawei.com) Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4MnRtg2qKcz1P74G; Wed, 12 Oct 2022 17:19:39 +0800 (CST) Received: from kwepemm600004.china.huawei.com (7.193.23.242) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 12 Oct 2022 17:24:13 +0800 Received: from [10.174.253.58] (10.174.253.58) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 12 Oct 2022 17:24:12 +0800 Subject: Re: [edk2-devel] [PATCH EDK2 v1 0/1] MdeModulePkg/TerminalDxe:Adding a switch for Terminal To: "Kinney, Michael D" , "devel@edk2.groups.io" , "Wang, Jian J" , "Gao, Liming" , "Gao, Zhichao" , "Ni, Ray" CC: "songdongkuang@huawei.com" References: <20221011111252.3382816-1-xiewenyi2@huawei.com> From: "wenyi,xie" Message-ID: <459815d6-462a-6986-79d5-734b31d07499@huawei.com> Date: Wed, 12 Oct 2022 17:24:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.0.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.174.253.58] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600004.china.huawei.com (7.193.23.242) X-CFilter-Loop: Reflected Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Hi, Mike Thank you for your reply. We add a PCD because we want to dynamic disable the terminal through setupbrowser. But as you said, the standard way is using console variables to manage it. We did not think about it before, we will have a try. Thanks Wenyi On 2022/10/11 21:58, Kinney, Michael D wrote: > Hi, > > Why is this new PCD and new behavior required? > > There are standard ways from the UEFI Spec to manage > the set of active console output devices using console > variables. > > Thanks, > > Mike > >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of wenyi,xie via groups.io >> Sent: Tuesday, October 11, 2022 4:13 AM >> To: devel@edk2.groups.io; Wang, Jian J ; Gao, Liming ; Gao, Zhichao >> ; Ni, Ray >> Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com >> Subject: [edk2-devel] [PATCH EDK2 v1 0/1] MdeModulePkg/TerminalDxe:Adding a switch for Terminal >> >> Main Changes : >> 1.Adding a new PCD to control ternimal. >> >> Wenyi Xie (1): >> MdeModulePkg/TerminalDxe:Adding a switch for Terminal >> >> MdeModulePkg/MdeModulePkg.dec | 4 ++++ >> MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf | 1 + >> MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c | 4 ++++ >> 3 files changed, 9 insertions(+) >> >> -- >> 2.20.1.windows.1 >> >> >> >> >> >