From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web11.14331.1605132337072624636 for ; Wed, 11 Nov 2020 14:05:37 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gTU9Tek6; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605132336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AyQAtG7KR1AxClexZf4eRL0KKQuQ+3qYzu0qVXA6p0k=; b=gTU9Tek6zA+W3cIHNSUfYp+oI84/gHhHBTB7AA20R7lZBrKnSiUCOLrPY5OPQNiFTV/G/k A7mOLS2B1L76Ci67/LurFpE6gGzGA4VQjuI3xoDO58WUXlPlS1kV4dNjIDlydKaWtLbYnN wOJpfFMVWfqJIxSt3/5RVu3UgeSlbE0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-230-AveHkIn3OyCPbdd0YdcaOw-1; Wed, 11 Nov 2020 17:05:33 -0500 X-MC-Unique: AveHkIn3OyCPbdd0YdcaOw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 527AA106B2BD; Wed, 11 Nov 2020 22:05:30 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-85.ams2.redhat.com [10.36.113.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1F84155792; Wed, 11 Nov 2020 22:05:27 +0000 (UTC) Subject: Re: [PATCH V3 07/12] OvmfPkg/OvmfPkgIa32.dsc: Enable MD5 while enable iSCSI To: Zhichao Gao , devel@edk2.groups.io Cc: Jordan Justen , Ard Biesheuvel References: <20201110173651.54036-1-zhichao.gao@intel.com> <20201110173651.54036-8-zhichao.gao@intel.com> From: "Laszlo Ersek" Message-ID: <45b91861-5770-45a7-3076-5a05943edb3a@redhat.com> Date: Wed, 11 Nov 2020 23:05:26 +0100 MIME-Version: 1.0 In-Reply-To: <20201110173651.54036-8-zhichao.gao@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/10/20 18:36, Zhichao Gao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3003 > > There is a plan to make MD5 disable as default. > The new MACRO ENABLE_MD5_DEPRECATED_INTERFACES > would be introduced to enable MD5. Make the > definition ahead of the change to avoid build > error after the MACRO changed. > > Enalbe iSCSI. (1) typo > > Signed-off-by: Zhichao Gao > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > --- > OvmfPkg/OvmfPkgIa32.dsc | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index 58d9f292f9..c0ddb0b375 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -42,6 +42,7 @@ > DEFINE NETWORK_IP6_ENABLE = FALSE > DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE > DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS = TRUE > + DEFINE NETWORK_ISCSI_ENABLE = TRUE > > !include NetworkPkg/NetworkDefines.dsc.inc > > @@ -86,6 +87,10 @@ > INTEL:*_*_*_CC_FLAGS = /D DISABLE_NEW_DEPRECATED_INTERFACES > GCC:*_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES > > +!if $(NETWORK_ISCSI_ENABLE) == TRUE > + *_*_*_CC_FLAGS = -D ENABLE_MD5_DEPRECATED_INTERFACES > +!endif > + (2) Please !include NetworkPkg/NetworkBuildOptions.dsc.inc instead. > [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] > GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 > XCODE:*_*_*_DLINK_FLAGS = -seg1addr 0x1000 -segalign 0x1000 > (3) The two comments above apply to the subsequent OvmfPkg patches in the series as well -- IA32X64, X64, Bhyve. (4) You missed the following DSC file: OvmfPkg/OvmfXen.dsc Please include a similar patch for that file too. Thanks! Laszlo