public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: "rebecca@bsdio.com" <rebecca@bsdio.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Sami Mujawar <sami.mujawar@arm.com>
Subject: [edk2-devel] SMBIOS BIOS ROM Size
Date: Thu, 30 May 2024 11:06:07 +0100	[thread overview]
Message-ID: <45c7db99-9b36-43c1-aceb-50705fe350dc@quicinc.com> (raw)

Hi Rebecca,

While reviewing https://github.com/tianocore/edk2/pull/5702, I found 
myself wondering "shouldn't this (doesn't apply to UEFI-based systems) 
be the case for the size field also?".

But the SMBIOS spec is quite clear that the size field refers to the 
size of the physical device the BIOS is stored on.

Currently, this field is hardwired to PcdFdSize in the smbios helper 
library. But that would only be accurate for platforms that use the edk2 
build system to generate the final flashable image to a fixed size.

This isn't really true for SbsaQemu, and I don't think it is for Mt. 
Jade. And those are the only two upstream platforms using this 
SmbiosMiscDxe.

Do we need to solve this by adding another function for OemMiscLib?

/
     Leif


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119385): https://edk2.groups.io/g/devel/message/119385
Mute This Topic: https://groups.io/mt/106385738/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



             reply	other threads:[~2024-05-30 10:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-30 10:06 Leif Lindholm [this message]
2024-05-30 11:58 ` [edk2-devel] SMBIOS BIOS ROM Size Rebecca Cran
2024-05-30 16:10   ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45c7db99-9b36-43c1-aceb-50705fe350dc@quicinc.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox