From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mx.groups.io with SMTP id smtpd.web10.7536.1681474387022178846 for ; Fri, 14 Apr 2023 05:13:07 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=NVEga6hj; spf=pass (domain: bsdio.com, ip: 66.111.4.28, mailfrom: rebecca@bsdio.com) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 56D335C019E; Fri, 14 Apr 2023 08:13:06 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 14 Apr 2023 08:13:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1681474386; x=1681560786; bh=nx9f6p9SfX9O7PR6oMhNfhtj9pAhpOia8lH 4bDzSmZ8=; b=NVEga6hjR8yf0CyKrmZNEX1btksah61zVL3JerpntiP2SgpLQiI Vhix/LMUf9RgKZufLi+GkBI5vHUP39fDDnXwS3zcl6Twq4FsA9ODTMgwMzyUqgx0 lGhSNAR2tRJMo2/gzqnZTcKFJmAVQfGUyIYsPtrq4aXO3nZVUzNnmf39xXqM0r/a OfFgsHv841IWldjPd4yaFEna6bo06F+wXOZGxf3QANO2TxKHIJquxuEHMQi8IVoP BX0eJMOwrQZYa0954Y/W4/ZimAVocOxw1cfkVIYLRr93k2TiM7zBXjDrgcZowT6K 8+inIdjrYd2DMrBoUz5qhhXEFwMXN4DOmFw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1681474386; x=1681560786; bh=nx9f6p9SfX9O7PR6oMhNfhtj9pAhpOia8lH 4bDzSmZ8=; b=GvBRUXPOCAmqxdQkL1m+BuTpVJo3yODeM3oaxb8I4Tdcn9taRPU W7s0U5wq/AJt6GcMCEW5rDlNLoPQZBq2d4A9thT84pwkSPCKL9NNm5Z6CC53mjMG gLE/T/Cn16H9bvyjuRO7RkXUvM/XlofxKQNwl6H3ExTCKY6bMekWwr3dKz+u6YZP KD2g1UFBP0OfymgKmSZ1JpvXnuR/6q7wnb+CfSbM8dy3Gh3XvV3P5T9ewN0LRxAh 28qyunsXF2ZpItSy6zaE+ygtMN1rgku+uNV0VOItuSHYT9lKIu7Nv4daLX81bNrC 6mSL4QdocF+75WrHrpg8gDs8u/+xkn1w5Dw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeltddggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpefgffefvdejgedvudffgfdvgfevtedvhedvteevjeelledtgfevteffvdej hefhhfenucffohhmrghinhepghhithhhuhgsrdgtohhmpdhgrhhouhhpshdrihhopdgush gtrdhinhgtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhho mheprhgvsggvtggtrgessghsughiohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 14 Apr 2023 08:13:04 -0400 (EDT) Message-ID: <45cf5684-fb48-abf7-a3d6-997f4b9c108d@bsdio.com> Date: Fri, 14 Apr 2023 06:13:03 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [edk2-devel] [PATCH v4 0/2] Set Firmware Version from build command line To: devel@edk2.groups.io, osteffen@redhat.com Cc: Anthony Perard , Ard Biesheuvel , Gerd Hoffmann , Jiewen Yao , Jordan Justen , Julien Grall , Leif Lindholm , Ray Ni , Sami Mujawar , Zhichao Gao References: <20230414083323.153731-1-osteffen@redhat.com> From: "Rebecca Cran" In-Reply-To: <20230414083323.153731-1-osteffen@redhat.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sorry for not commenting on this earlier. Would it be better to have people use the build `--pcd` option instead? e.g. build --pcd="gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString=edk2-stable202302". -- Rebecca Cran On 4/14/23 02:33, Oliver Steffen wrote: > ArmVirtXen.dsc allows setting the firmware version > string in gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString > via FIRMWARE_VER variable conveniently on the build command line. > > These two patches add this behavior to all .dsc files in ArmVirtPkg > and OvmfPkg. > > PR: https://github.com/tianocore/edk2/pull/4268 > > v4: > - Actually use the include file > > v3: > - Introduce common include file for OVMF .dsc files > https://edk2.groups.io/g/devel/message/102952 > > v2: > Address comments by Sami and Gerd: > - Only set PCD if FIRMWARE_VER is defined > - ArmVirt: move logic to ArmVirt.dsc.inc > https://edk2.groups.io/g/devel/message/95208 > > v1: > https://edk2.groups.io/g/devel/message/95057 > > Oliver Steffen (2): > OvmfPkg: allow setting Firmware Version from build command line > ArmVirtPkg: allow setting Firmware Version from build command line > > ArmVirtPkg/ArmVirt.dsc.inc | 4 ++++ > OvmfPkg/Include/Dsc/OvmfPkg.dsc.inc | 9 +++++++++ > ArmVirtPkg/ArmVirtXen.dsc | 1 - > OvmfPkg/OvmfPkgIa32.dsc | 2 ++ > OvmfPkg/OvmfPkgIa32X64.dsc | 2 ++ > OvmfPkg/OvmfPkgX64.dsc | 3 +++ > OvmfPkg/OvmfXen.dsc | 2 ++ > 7 files changed, 22 insertions(+), 1 deletion(-) > create mode 100644 OvmfPkg/Include/Dsc/OvmfPkg.dsc.inc >