From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web08.6084.1614220718897242484
 for <devel@edk2.groups.io>;
 Wed, 24 Feb 2021 18:38:39 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=FMAmsv3Z;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [10.124.238.202] (unknown [131.107.174.202])
	by linux.microsoft.com (Postfix) with ESMTPSA id 0FFC320B6C40;
	Wed, 24 Feb 2021 18:38:38 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 0FFC320B6C40
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1614220718;
	bh=4CsmbQp8JDG9/Mprx8RalD8newqO/or86H6kSQyC6nU=;
	h=Subject:To:Cc:References:From:Date:In-Reply-To:From;
	b=FMAmsv3ZVNA7xBVXYfTygEynkpV9zr6gGqOBfD6fyy3cqVNaTHLH+V2n25SZ6GR9q
	 AeH44OfzyYzal7KjMjfY1s+AHvztCLoL80N5yEMWwohJ0G4NF8lTTFP912Ci+qlq7W
	 yg+RINyCc7CfyAn0Bu0l8CUcJOjtRkPi7uCq71OY=
Subject: Re: [edk2-devel] Duplicate Files for StandaloneMmDriverEntryPoint.h
To: devel@edk2.groups.io, ardb@kernel.org, Laszlo Ersek <lersek@redhat.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>,
 Supreeth Venkatesh <supreeth.venkatesh@arm.com>,
 Ard Biesheuvel <ardb+tianocore@kernel.org>, Jiewen Yao <jiewen.yao@intel.com>
References: <b59eebc8-beb8-9e0e-e0d3-6bc07aa77276@linux.microsoft.com>
 <a6991160-035c-6726-79ad-34e7b272fefc@redhat.com>
 <CAMj1kXGqADJCwqw5T42+sGdd6+M826jZNiUuPCg1w7Q1C+T6Xg@mail.gmail.com>
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
Message-ID: <45cfee7b-2d09-70ca-a180-bae2df0600ce@linux.microsoft.com>
Date: Wed, 24 Feb 2021 18:38:38 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <CAMj1kXGqADJCwqw5T42+sGdd6+M826jZNiUuPCg1w7Q1C+T6Xg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Thanks for the background. I'll go ahead and send that patch.

On 2/23/2021 11:51 PM, Ard Biesheuvel wrote:
> On Tue, 23 Feb 2021 at 18:37, Laszlo Ersek <lersek@redhat.com> wrote:
>>
>> Hi Michael,
>>
>> On 02/22/21 23:11, Michael Kubacki wrote:
>>> Is there a particular reason two copies of
>>> StandaloneMmDriverEntryPoint.h exist in the edk2 repo?
>>>
>>> 1. MdePkg
>>> https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Library/StandaloneMmDriverEntryPoint.h
>>>
>>>
>>> 2. StandaloneMmPkg
>>> https://github.com/tianocore/edk2/blob/master/StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h
>>>
>>>
>>> The only substantial difference (apart from copyright and comment
>>> differences) is that the StandaloneMmPkg instance contains a function
>>> declaration for EfiMain().
>>
>> I believe this may have been an omission in commit d6253d2f9a33
>> ("StandaloneMmPkg: remove redundant StandaloneMmDriverEntryPoint
>> driver", 2019-03-11).
>>
>> At that point, both the library class & instance had been migrated to
>> MdePkg (commits 7df4764e6a81a and 5866d4992396).
>>
>> Can you propose a patch (unless I'm wrong, of course)?
>>
> 
> I think you are correct.
> 
> For a patch that deletes
> 
> StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h
> 
> and any stale references to it that may exist:
> 
> Acked-by: Ard Biesheuvel <ardb@kernel.org>
> 
> 
> 
>