From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.9843.1589195190377146449 for ; Mon, 11 May 2020 04:06:30 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 23D571FB; Mon, 11 May 2020 04:06:29 -0700 (PDT) Received: from [192.168.1.81] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C35BC3F305; Mon, 11 May 2020 04:06:27 -0700 (PDT) Subject: Re: [edk2-platforms][PATCH 1/1] RPi3: default DisplayDxe to just native mode To: Pete Batard , Andrei Warkentin , devel@edk2.groups.io Cc: leif@nuviainc.com, philmd@redhat.com References: <20200510213603.12741-1-andrey.warkentin@gmail.com> From: "Ard Biesheuvel" Message-ID: <45d9af40-7d74-91d5-6c12-acb2eea998c0@arm.com> Date: Mon, 11 May 2020 13:06:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 5/11/20 12:58 PM, Pete Batard wrote: > On 2020.05.10 22:36, Andrei Warkentin wrote: >> The scaled resolutions are useful, but are not the default expected >> by most users. Linux and BSDs don't set preferred resolution in >> their OS loader, so when booting via setup UI, the OS is left >> running at 800x600, not the native resolution. This looks crummy. >> >> Signed-off-by: Andrei Warkentin >> --- >> =C2=A0 Platform/RaspberryPi/RPi3/RPi3.dsc | 6 +++++- >> =C2=A0 Platform/RaspberryPi/RPi4/RPi4.dsc | 6 +++++- >> =C2=A0 2 files changed, 10 insertions(+), 2 deletions(-) >> >> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc=20 >> b/Platform/RaspberryPi/RPi3/RPi3.dsc >> index a138c874..8dd4cbff 100644 >> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc >> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc >> @@ -471,7 +471,11 @@ >> =C2=A0=C2=A0=C2=A0 # >> =C2=A0=C2=A0=C2=A0 # Display-related. >> =C2=A0=C2=A0=C2=A0 # >> - =20 >> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnabl= eScaledVModes"|gConfigDxeFormSetGuid|0x0|0x3f=20 >> >> + >> +=C2=A0 # >> +=C2=A0 # Just enable native resolution by default. >> +=C2=A0 # >> + =20 >> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnabl= eScaledVModes"|gConfigDxeFormSetGuid|0x0|0x20=20 >> >> =20 >> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableSShot|L"DisplayEnableSShot"= |gConfigDxeFormSetGuid|0x0|1=20 >> >> =C2=A0=C2=A0=C2=A0 # >> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc=20 >> b/Platform/RaspberryPi/RPi4/RPi4.dsc >> index 75867f03..9413fe66 100644 >> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc >> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc >> @@ -486,7 +486,11 @@ >> =C2=A0=C2=A0=C2=A0 # >> =C2=A0=C2=A0=C2=A0 # Display-related. >> =C2=A0=C2=A0=C2=A0 # >> - =20 >> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnabl= eScaledVModes"|gConfigDxeFormSetGuid|0x0|0x3f=20 >> >> + >> +=C2=A0 # >> +=C2=A0 # Just enable native resolution by default. >> +=C2=A0 # >> + =20 >> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnabl= eScaledVModes"|gConfigDxeFormSetGuid|0x0|0x20=20 >> >> =20 >> gRaspberryPiTokenSpaceGuid.PcdDisplayEnableSShot|L"DisplayEnableSShot"= |gConfigDxeFormSetGuid|0x0|1=20 >> >> =C2=A0=C2=A0=C2=A0 # >> >=20 > Reviewed-by: Pete Batard >=20 > For the series: > Tested-by: Pete Batard Thanks Pete. What do you mean by series? This is patch 1/1