From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 20 Jun 2019 08:14:12 -0700 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3AFD813AA9; Thu, 20 Jun 2019 15:13:56 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-226.ams2.redhat.com [10.36.117.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id A514D608D0; Thu, 20 Jun 2019 15:13:54 +0000 (UTC) Subject: Re: [edk2-devel] [RFC PATCH 1/3] Maintainers.txt: update for filesystem area descriptions To: devel@edk2.groups.io, leif.lindholm@linaro.org Cc: "Feng, Bob C" , Liming Gao , Andrew Fish , Michael D Kinney , "Wu, Hao A" References: <20190614202121.18952-2-leif.lindholm@linaro.org> From: "Laszlo Ersek" Message-ID: <45e43942-d64f-4155-fa41-3bc3d481f751@redhat.com> Date: Thu, 20 Jun 2019 17:13:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190614202121.18952-2-leif.lindholm@linaro.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 20 Jun 2019 15:13:56 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 06/14/19 22:21, Leif Lindholm wrote: > Add comment describing new F: and X: tags for associating maintainership > sections with specific filesystem paths, including wildcards. > > Add global section associating *all* code with devel@edk2.groups.io, > and add a magic '' F: tag directing all modifications that > do not hit a rule to the stewards. > > Also tag all files in top directory as maintained by the stewards. > > Signed-off-by: Leif Lindholm > --- > Maintainers.txt | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > > diff --git a/Maintainers.txt b/Maintainers.txt > index 762a68465979..cd32f9b00170 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -36,6 +36,20 @@ Descriptions of section entries: > Obsolete: Old code. Something tagged obsolete generally means > it has been replaced by a better system and you > should be using that. > + F: Files and directories with wildcard patterns. > + A trailing slash includes all files and subdirectory files. > + F: drivers/net/ all files in and below drivers/net > + F: drivers/net/* all files in drivers/net, but not below > + F: */net/* all files in "any top level directory"/net > + One pattern per line. Multiple F: lines per section acceptable. (1) Looks good, but I suggest updating the example pathnames so they feel more "native" to edk2 (use actual edk2 pathnames as examples?) > + X: Files and directories that are NOT maintained, same rules as F: > + Files exclusions are tested after file matches. > + Can be useful for excluding a specific subdirectory, for instance: > + F: NetworkPkg/ > + X: NetworkPkg/Ip6Dxe/ > + matches all files in and below NetworkPkg excluding NetworkPkgnet/Ip6Dxe/ Yep, this feels native. > + Magic filename "" denotes all files not caught by any F: rule should > + be sent. (2) drop "should be sent"? (Sorry if my English parser failed me.) With those updates: Reviewed-by: Laszlo Ersek Thanks! Laszlo