From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81])
 by mx.groups.io with SMTP id smtpd.web12.5586.1586423883188226224
 for <devel@edk2.groups.io>;
 Thu, 09 Apr 2020 02:18:03 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=J6+tNvri;
 spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1586423882;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9bw5QW38hucphWK6gg42hG5zO4KhWwaHRBiXHI9vJKQ=;
	b=J6+tNvri73srh4u9OhsAHcbzx8nJ9RYnot8UBT3ZS0bpyhwcUI68DIhAH4wApqpmcQb8pX
	wBXXasYcwvyxebSEMcGLmsZpilvKoslPRsHdfjGe61dTO4J+8WOGaRLFGPE3swq2JvL9Ft
	pVH4MwnS2ssJ9NM0KBTxtgTu6/1MO34=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-279-Dt768qN0PZeIiditYV8Oow-1; Thu, 09 Apr 2020 05:18:00 -0400
X-MC-Unique: Dt768qN0PZeIiditYV8Oow-1
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4B3F7801A00;
	Thu,  9 Apr 2020 09:17:59 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-213.ams2.redhat.com [10.36.112.213])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 56B065C1C5;
	Thu,  9 Apr 2020 09:17:58 +0000 (UTC)
Subject: Re: [PATCH v1 4/6] OvmfPkg: Add Platform CI and configuration for Core CI
To: michael.kubacki@outlook.com, devel@edk2.groups.io
Cc: Jordan Justen <jordan.l.justen@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@arm.com>
References: <20200408181327.4324-1-michael.kubacki@outlook.com>
 <MWHPR07MB3440F9BF189AC9EFEF4E7946E9C00@MWHPR07MB3440.namprd07.prod.outlook.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <45faebf7-f45f-4f65-e72a-4a01dc729a18@redhat.com>
Date: Thu, 9 Apr 2020 11:17:57 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <MWHPR07MB3440F9BF189AC9EFEF4E7946E9C00@MWHPR07MB3440.namprd07.prod.outlook.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

On 04/08/20 20:13, michael.kubacki@outlook.com wrote:
> From: Sean Brogan <sean.brogan@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570
> 
> Add new Azure Pipeline definitions to build and run OvmfPkg with:
>   * Ubuntu GCC5
>   * Windows VS2019
> Add PyTool based build of OvmfPkg
> Add extdep for managing the iasl dependency
> Add OvmfPkg.ci.yaml for Core CI
> Add README-pytools for details and instructions
> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Signed-off-by: Sean Brogan <sean.brogan@microsoft.com>
> ---
>  OvmfPkg/.azurepipelines/Ubuntu-GCC5.yml    | 133 +++++++++++
>  OvmfPkg/.azurepipelines/Windows-VS2019.yml | 138 +++++++++++
>  OvmfPkg/OvmfPkg.ci.yaml                    |  83 +++++++
>  OvmfPkg/PlatformBuild.py                   | 242 ++++++++++++++++++++
>  OvmfPkg/README-pytools.md                  | 238 +++++++++++++++++++
>  OvmfPkg/iasl_ext_dep.yaml                  |  21 ++
>  6 files changed, 855 insertions(+)

Same comments as for ArmVirtPkg; then I'm ready to ACK. Thanks!
Laszlo