From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7F98B7803E0 for ; Fri, 1 Mar 2024 14:32:55 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=JeBqYF7QvnUBbhvPYb8WyX/pFRk+tBU+jE/YvkfW/ws=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1709303574; v=1; b=vtllVeB3sO6m5AYiMd8eO6OEToie4lIi4ZUUGRfH3bj+9ryFMu8nJRtR2nMAmQEfPsMqIAgn 2bCq8wveedF+A/G7BmFLwLxO88TD2UWBXwmzKBcDtNjZUJ651mogImVuKEvzmZA5VzKWss3wZ2O cw3Ebqnpa5wMrlxl9wAFu2XE= X-Received: by 127.0.0.2 with SMTP id zgQ4YY7687511xOnvtF8o3Sp; Fri, 01 Mar 2024 06:32:54 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.24472.1709303573040607861 for ; Fri, 01 Mar 2024 06:32:53 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-93-kcGSFXWxMJ6Bji0j73iosQ-1; Fri, 01 Mar 2024 09:32:46 -0500 X-MC-Unique: kcGSFXWxMJ6Bji0j73iosQ-1 X-Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 457BE8828C0; Fri, 1 Mar 2024 14:32:46 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.121]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0F2AB20229D6; Fri, 1 Mar 2024 14:32:46 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id E27F218009DC; Fri, 1 Mar 2024 15:32:44 +0100 (CET) Date: Fri, 1 Mar 2024 15:32:44 +0100 From: "Gerd Hoffmann" To: Laszlo Ersek Cc: devel@edk2.groups.io, Jiewen Yao , Oliver Steffen , Michael Roth , Erdem Aktas , Min Xu , Ard Biesheuvel , Tom Lendacky Subject: Re: [edk2-devel] [PATCH v2 08/10] OvmfPkg/ResetVector: wire up 5-level paging for TDX Message-ID: <45ihkrcwr6dmt2zdjgugojt6m56kavbp2pynq7bfuwi6tjzylj@fmjawjybqexs> References: <20240301074402.98625-1-kraxel@redhat.com> <20240301074402.98625-9-kraxel@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: LMglg8JXKMCw3fHqxW2oPgPgx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=vtllVeB3; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, > Did you place the "CheckForSev:" label intentionally outside of the %if > scope? If it was intentional, then I'm OK with it. > > If it was unintended / an oversight, then next question: do you want me > to move the label into the %if's scope for you, upon merge? Or do you > like it better as written in your patch, after all? I've placed it at the start of the SEV block without realizing that we don't need it in the first place when compiling without 5-level support. Moving it is fine with me. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116258): https://edk2.groups.io/g/devel/message/116258 Mute This Topic: https://groups.io/mt/104660117/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-