public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: "Leif Lindholm" <leif.lindholm@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: devel@edk2.groups.io, Andrew Fish <afish@apple.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Ray Ni <ray.ni@intel.com>, Zhichao Gao <zhichao.gao@intel.com>,
	Leif Lindholm <leif@nuviainc.com>
Subject: Re: [PATCH 1/2] Maintainers.txt: update email address for Leif Lindholm
Date: Fri, 17 Jan 2020 09:17:07 +0100	[thread overview]
Message-ID: <462e9cea-bc9b-1eec-2f7d-69c2eda65010@redhat.com> (raw)
In-Reply-To: <20200116213441.GE20629@bivouac.eciton.net>

On 01/16/20 22:34, Leif Lindholm wrote:
> On Thu, Jan 16, 2020 at 19:54:43 +0100, Philippe Mathieu-Daudé wrote:
>>> Phil, would it make sense for us to ask Leif to post an update to
>>> ".mailmap"?
>>>
>>> For example, what happens if we run "git shortlog" over a period that
>>> contains patches authored by *both* of Leif's email addresses? Would
>>> those entries be merged into a single block? Would such a merging be
>>> desirable (that's for Leif to decide / propose)?
>>
>> One use of .mailmap is to clean/unify the NAME part.
>> In this case Leif isn't affected because his NAME is the same.
>>
>> The other use is to redirect email when a user switch email. When
>> fixing/referring old commit, some email tools might take the old commit
>> author/committer. In this case .mailmap helps. I think it is desirable in
>> Leif particular case.
> 
> The question is *why* we use the mailmap to begin with.
> It is not clear to me that there was an understanding at the point
> .mailmap was added that the intent was to provide a mapping of people
> to current email addresses in perpetuity.

It's one of the possible / nice-to-have goals, for "git shortlog".

It's absolutely *not* a requirement -- and I wanted to mention again
that such a cross-domain mapping is not something a maintainer can heap
on top at a push. Cross-domain generally implies cross-employer, and
companies might easily not be OK with that. So it's fully up to the
person to propose (post) such a mapping. If they don't, then there's not
going to be such a mapping; end of story :)

> Indeed, the initial commit message says:
> "The .mailmap git feature helps fixing commit mistakes (in name/email)."
> 
> The comment header in the file itself says:
> # This list is used by git-shortlog to fix a few botched name translations
> # in the git archive, either because the author's full name was messed up
> # and/or not always written the same way, making contributions from the
> # same person appearing not to be so or badly displayed.
> 
> Now, I'm not saying that providing a way to track individuals across
> employments, acquisitions, or other transitions is a bad idea. And
> using the .mailmap is a workable way of doing this, since it needs to
> be manually invoked outside of shortlog (it could be disastrous if it
> didn't, or the default git behaviour changes in the future).

I agree: ".mailmap" must not unsolicitedly collapse email addresses.

> *But* before we start treating it in this way, I would like to see the
> intended use of .mailmap documented (in the tree), and that change
> reviewed by at least a couple of stewards and enough others to be able
> to say we have a consensus.
> 
> If we do, I have no objections to the below patch being added at that
> point - but from my viewpoint, doing it before then would mean an
> unreviewed change to the process as some people understood when the
> file was first added.

I don't think we're actively proposing cross-domain mappings, as part of
the process. In my mind it's something everyone is "free to consider". I
just thought you might want to consider it.

I'm also not against formalizing this option, but I don't feel like
actively pursuing it.

Thanks!
Laszlo


  reply	other threads:[~2020-01-17  8:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-14 16:32 [PATCH edk2/eck2-platforms 0/2] Update email address for Leif Lindholm Leif Lindholm
2020-01-14 16:32 ` [PATCH 1/2] Maintainers.txt: update " Leif Lindholm
2020-01-14 20:27   ` Laszlo Ersek
2020-01-16 18:54     ` Philippe Mathieu-Daudé
2020-01-16 21:34       ` Leif Lindholm
2020-01-17  8:17         ` Laszlo Ersek [this message]
2020-01-14 16:32 ` [PATCH edk2-platforms 2/2] " Leif Lindholm
2020-01-17  5:42   ` Michael D Kinney
2020-01-17 20:47     ` Leif Lindholm
2020-01-14 16:37 ` [PATCH edk2/eck2-platforms 0/2] Update " Ard Biesheuvel
2020-01-14 19:04   ` [edk2-devel] " Philippe Mathieu-Daudé
2020-01-14 17:06 ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=462e9cea-bc9b-1eec-2f7d-69c2eda65010@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox