From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web11.1564.1579249038794344359 for ; Fri, 17 Jan 2020 00:17:18 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AuK4FL3d; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579249037; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V2Dj0qlwe0pA4NrUD9ueDwVz9HElyZnjSy98Gdf99xw=; b=AuK4FL3dgklxzzU/LspDhcizf7I/VxRoT4hJicnvfkrwVYunz856Munk6YsEbgfuSSMOKx 3yNPCWQTTshdbciD318T8QZabF1BOcud3QL4suqfRhzy1cIqbYmAotTO4tlF7qf+4j/KaL E9VlkXmKumXZSTCkRXtvojMbq5Agsqg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-354-t--FlGtINSaT0LQ8uGJeqg-1; Fri, 17 Jan 2020 03:17:15 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5AF158010CC; Fri, 17 Jan 2020 08:17:14 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-211.ams2.redhat.com [10.36.116.211]) by smtp.corp.redhat.com (Postfix) with ESMTP id B43DF845C0; Fri, 17 Jan 2020 08:17:08 +0000 (UTC) Subject: Re: [PATCH 1/2] Maintainers.txt: update email address for Leif Lindholm To: Leif Lindholm , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Cc: devel@edk2.groups.io, Andrew Fish , Ard Biesheuvel , Michael D Kinney , Ray Ni , Zhichao Gao , Leif Lindholm References: <20200114163255.10681-1-leif.lindholm@linaro.org> <20200114163255.10681-2-leif.lindholm@linaro.org> <119a8e77-6472-9be6-b12e-3bfe8e4e83b5@redhat.com> <9b4c40fe-b15c-2b44-c3f0-70a4b7f1dfc8@redhat.com> <20200116213441.GE20629@bivouac.eciton.net> From: "Laszlo Ersek" Message-ID: <462e9cea-bc9b-1eec-2f7d-69c2eda65010@redhat.com> Date: Fri, 17 Jan 2020 09:17:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200116213441.GE20629@bivouac.eciton.net> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: t--FlGtINSaT0LQ8uGJeqg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/16/20 22:34, Leif Lindholm wrote: > On Thu, Jan 16, 2020 at 19:54:43 +0100, Philippe Mathieu-Daud=C3=A9 wrote= : >>> Phil, would it make sense for us to ask Leif to post an update to >>> ".mailmap"? >>> >>> For example, what happens if we run "git shortlog" over a period that >>> contains patches authored by *both* of Leif's email addresses? Would >>> those entries be merged into a single block? Would such a merging be >>> desirable (that's for Leif to decide / propose)? >> >> One use of .mailmap is to clean/unify the NAME part. >> In this case Leif isn't affected because his NAME is the same. >> >> The other use is to redirect email when a user switch email. When >> fixing/referring old commit, some email tools might take the old commit >> author/committer. In this case .mailmap helps. I think it is desirable i= n >> Leif particular case. >=20 > The question is *why* we use the mailmap to begin with. > It is not clear to me that there was an understanding at the point > .mailmap was added that the intent was to provide a mapping of people > to current email addresses in perpetuity. It's one of the possible / nice-to-have goals, for "git shortlog". It's absolutely *not* a requirement -- and I wanted to mention again that such a cross-domain mapping is not something a maintainer can heap on top at a push. Cross-domain generally implies cross-employer, and companies might easily not be OK with that. So it's fully up to the person to propose (post) such a mapping. If they don't, then there's not going to be such a mapping; end of story :) > Indeed, the initial commit message says: > "The .mailmap git feature helps fixing commit mistakes (in name/email)." >=20 > The comment header in the file itself says: > # This list is used by git-shortlog to fix a few botched name translation= s > # in the git archive, either because the author's full name was messed up > # and/or not always written the same way, making contributions from the > # same person appearing not to be so or badly displayed. >=20 > Now, I'm not saying that providing a way to track individuals across > employments, acquisitions, or other transitions is a bad idea. And > using the .mailmap is a workable way of doing this, since it needs to > be manually invoked outside of shortlog (it could be disastrous if it > didn't, or the default git behaviour changes in the future). I agree: ".mailmap" must not unsolicitedly collapse email addresses. > *But* before we start treating it in this way, I would like to see the > intended use of .mailmap documented (in the tree), and that change > reviewed by at least a couple of stewards and enough others to be able > to say we have a consensus. >=20 > If we do, I have no objections to the below patch being added at that > point - but from my viewpoint, doing it before then would mean an > unreviewed change to the process as some people understood when the > file was first added. I don't think we're actively proposing cross-domain mappings, as part of the process. In my mind it's something everyone is "free to consider". I just thought you might want to consider it. I'm also not against formalizing this option, but I don't feel like actively pursuing it. Thanks! Laszlo