From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B1D25780091 for ; Fri, 10 Nov 2023 20:36:02 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=TOPjKjQQpxhyBE0ut/66LJwVRNqJnr+KyH+8Kq5adr8=; c=relaxed/simple; d=groups.io; h=Feedback-ID:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699648561; v=1; b=lY8EHG45srR1pafUX2bDaSqbfzD03XEPBqD4MhGaI9bpuFG2UzDprP0EK/uc90Kiu3OJ84yU Yvq0UR/McBv4E6Eg5Ht5keG4ybQoPjWLFRSszbHRu3TqI9RaG9V0JIszDlYezdwlfMKW5thj+AP ddv168tk6FztX6NVdY85+hHk= X-Received: by 127.0.0.2 with SMTP id z5ybYY7687511xFETp4O6a4N; Fri, 10 Nov 2023 12:36:01 -0800 X-Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mx.groups.io with SMTP id smtpd.web10.38436.1699648560341747212 for ; Fri, 10 Nov 2023 12:36:00 -0800 X-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 1DC605C0289; Fri, 10 Nov 2023 15:35:59 -0500 (EST) X-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 10 Nov 2023 15:35:59 -0500 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddvfedgudefiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomheptfgv sggvtggtrgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrf grthhtvghrnheptddtleefheduueehhfekieejgfeitdetteffgefgiefgtdetleelffff ledtvddvnecuffhomhgrihhnpehtihgrnhhotghorhgvrdhorhhgnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprhgvsggvtggtrgessghsughi ohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail X-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 10 Nov 2023 15:35:57 -0500 (EST) Message-ID: <4635d570-97d5-47ab-9e8e-65d273ae9f97@bsdio.com> Date: Fri, 10 Nov 2023 13:35:49 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v3 0/5] BaseTools/Scripts/GetMaintainer: Handle reviewer only case To: Leif Lindholm , devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao , Bob Feng , Yuwei Chen References: <20231110193053.673595-1-quic_llindhol@quicinc.com> From: "Rebecca Cran" In-Reply-To: <20231110193053.673595-1-quic_llindhol@quicinc.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@bsdio.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: OsqgspDOkiQQC1zFQn6emBhDx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=lY8EHG45; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io For the series: Acked-by: Rebecca Cran On 11/10/23 12:30, Leif Lindholm wrote: > OK, so this a bit of a backwards review, but I figured I might as > well show how I would prefer the split. I'm adding a patch that > changes internal returns to dictionaries instead of multiple return > values. > > There are no functional differences between the original submission > and this for 1-2,4-5/5, so I'm happy to give > Reviewed-by: Leif Lindholm > for those. 3/5 is new and requires review by someone else. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4593 > > Fix logic bug where maintainers was incorrectly added to lists. > > If a package only has reviewers and no maintainers, then also > return the maintainers. > > In order to detect this case, get_maintainers() is updated to > return maintainers, reviews, and lists separately instead of > a single merged list. This also allows this module to be used > by other scripts that need to distinguish between maintainers, > reviewers, and lists. > > Simplify logic that accumulates maintainers, reviewers, lists. > > Sort the list of output addresses alphabetically and use set() > instead of OrderedDict() to accumulate unique addresses. > > Changes since v2: > - Reworked internal return logic to use dictionaries. > - Reordered cleanup before new functionality. > Changes since v1: > - Split into patch series > > Cc: Rebecca Cran > Cc: Liming Gao > Cc: Bob Feng > Cc: Yuwei Chen > Cc: Michael D Kinney > > Leif Lindholm (1): > BaseTools/Scripts/GetMaintainer: refactor internal returns as dicts > > Michael D Kinney (4): > BaseTools/Scripts/GetMaintainer: Fix logic bug collecting maintainers > BaseTools/Scripts/GetMaintainer: Simplify logic > BaseTools/Scripts/GetMaintainer: Handle reviewer only case > BaseTools/Scripts/GetMaintainer: Sort output addresses > > BaseTools/Scripts/GetMaintainer.py | 43 +++++++++++++++++++----------- > 1 file changed, 27 insertions(+), 16 deletions(-) > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111070): https://edk2.groups.io/g/devel/message/111070 Mute This Topic: https://groups.io/mt/102513765/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-