Re: [PATCH v3 01/28] Ampere: Initial support for Ampere Altra processor and Mt. Jade platform

["Nhi Pham" <nhi@os.amperecomputing.com>]

On 16/09/2021 17:46, Leif Lindholm wrote:
> On Thu, Sep 16, 2021 at 11:40:45 +0100, Leif Lindholm wrote:
>> On Wed, Sep 15, 2021 at 22:55:00 +0700, Nhi Pham wrote:
>>> From: Vu Nguyen <vunguyen@os.amperecomputing.com>
>>>
>>> This commit adds the support for Ampere’s Altra processor-based Mt. Jade
>>> platform that provides up to 160 processor cores in a dual socket
>>> configuration. The essential modules are wired up enough to boot system
>>> to EDK2 UiApp.
>>>
>>> Cc: Thang Nguyen <thang@os.amperecomputing.com>
>>> Cc: Chuong Tran <chuong@os.amperecomputing.com>
>>> Cc: Phong Vo <phong@os.amperecomputing.com>
>>> Cc: Leif Lindholm <leif@nuviainc.com>
>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>>>
>>> Signed-off-by: Vu Nguyen <vunguyen@os.amperecomputing.com>
>> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
> Err, actually, no.
>
> You cannot give sign-off for Vu, but you need to sign off for
> yourself. So we will need a v4.
> If this patch in that set contains your Signed-off-by, and no-one
> elses, that can retain my reviewed-by.
Will fix it.
>
> Please address this situation for all other affected patches in the
> set. But don't send out v4 vefore v3 review is complete.

Yes, will fix for all patches violating the sign-off rule.

Thanks,

-Nhi

>
> Best Regards,
>
> Leif