From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.93]) by mx.groups.io with SMTP id smtpd.web11.9032.1631859586472830094 for ; Thu, 16 Sep 2021 23:19:46 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@os.amperecomputing.com header.s=selector2 header.b=tbViNPm1; spf=pass (domain: os.amperecomputing.com, ip: 40.107.220.93, mailfrom: nhi@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TxH1lH9XoPHvPOPRZEn7+A0H1f7oYRNlEquJ8lEj8tqedwy8IaqPeSmn2Lypo/fPQEJHee4KI1oMU6l+J9MXFVlvhi8KkG+bu9VNxlNg7ZPu7HgmGa4DG+9KXyIvs1b1XIS/cGeuZiPycb8AT8SKR57U8/2TC+thBhfeXiloa1JwzK6Y9j08UgHxDc9631RoG0y3u47cwN8bgA+GYzD/NmppPzYSmOaJ6uzosiriAEKyrk76CaItaOiF9RO4weVDiHAOfTBRw4ShfKpEZ0ocYTW1uvBGPnM2f0SdkcJ6gU8JBBKAxbGJbwOEOaKWeVBimyHSPk60bqQfykTbvbRBUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=tuM1IP3L2uOh64zZDvy5HqkWQh4Rzn9rJBcRshHyuOE=; b=f0PUYTgUr2G52io+5X2/Yac39B/5dLUxOpbHYHCADwyZ8m0LAvsk3OIm8mBwC8tpzyxRxenog1LD2bBX6/QXD+0nYAHwJhzr5V4CYFII/qZUrERMPAJS2yj9k/1jKPsgumEUqGakAjFAAB1Fy9H2MTE4FWX2kpy9EP10ReTdDVo9V/URPj1yn8e09bmoi/4FGZruntADbbKbXWF/Q0IQilEat0OeOiqXXK+PSbyoi2bzFM00stvevujOQFaNu+QMR7mewv3YORbFaGXlCbXW6TDyx8tAt9G3R8cYlBa9fjAhk/DKi8HB6tBLx02FvSWRF38zlL/Is9hZ6I9xKMmjcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tuM1IP3L2uOh64zZDvy5HqkWQh4Rzn9rJBcRshHyuOE=; b=tbViNPm1PgDmA+RV51ruwVgdQHj0GQJzSFR1gJ5ej0Z897l24WoVuHLDDQ3xEh4xEmgbb6ib5Oy/DOIhMhdeNUz2Yh3xnvcdYq3UpaxWlgAvbW2wxkIRB4YYFva/f3XZJy/9xtrExeoQd34lxcyDvgOjvkwQBeUfSzMd/1LefVc= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=os.amperecomputing.com; Received: from DM6PR01MB5849.prod.exchangelabs.com (2603:10b6:5:205::20) by DM8PR01MB6807.prod.exchangelabs.com (2603:10b6:8:22::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Fri, 17 Sep 2021 06:19:44 +0000 Received: from DM6PR01MB5849.prod.exchangelabs.com ([fe80::8eb:704f:2ba7:9bc3]) by DM6PR01MB5849.prod.exchangelabs.com ([fe80::8eb:704f:2ba7:9bc3%4]) with mapi id 15.20.4523.016; Fri, 17 Sep 2021 06:19:44 +0000 Subject: Re: [PATCH v3 01/28] Ampere: Initial support for Ampere Altra processor and Mt. Jade platform To: Leif Lindholm CC: devel@edk2.groups.io, patches@amperecomputing.com, vunguyen@os.amperecomputing.com, Thang Nguyen , Chuong Tran , Phong Vo , Michael D Kinney , Ard Biesheuvel , Nate DeSimone References: <20210915155527.8176-1-nhi@os.amperecomputing.com> <20210915155527.8176-2-nhi@os.amperecomputing.com> <20210916104045.73wihadbuxfg77e7@leviathan> <20210916104654.dxfri4polb6zcjrr@leviathan> From: "Nhi Pham" Message-ID: <46447d0e-57a5-a7c0-45ad-35b2c023cac2@os.amperecomputing.com> Date: Fri, 17 Sep 2021 13:19:34 +0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <20210916104654.dxfri4polb6zcjrr@leviathan> X-ClientProxiedBy: HK2PR02CA0180.apcprd02.prod.outlook.com (2603:1096:201:21::16) To DM6PR01MB5849.prod.exchangelabs.com (2603:10b6:5:205::20) Return-Path: nhi@os.amperecomputing.com MIME-Version: 1.0 Received: from [192.168.1.7] (116.110.42.117) by HK2PR02CA0180.apcprd02.prod.outlook.com (2603:1096:201:21::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Fri, 17 Sep 2021 06:19:41 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 50bcd909-68ea-4aaf-aa68-08d979a323d9 X-MS-TrafficTypeDiagnostic: DM8PR01MB6807: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3826; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1nMhMmZMoSqP8yfXQcbUB0KRwsW4LyMi56BW5exvA7KU9b/nAqjw6hYfLVf8PwfafOQASvJXyXa0u2aF55iKeqEzqg1U2jO+CJuF0lKofH55gBxv82kfzREdcb6hsdQdjDKE0l+fhHx9OqBDh/Xd95R7M4ZjdGAqGPf+2zeOsCKY5F/PfMyli50w8rcp72uV3rVNfziwBL3cTPlVPAySX0z+RlivbxmprGCfc8KawlnXzfwyMYAqcwxLxqdaXLOKq7ECQJiBL9EEQimS7/JgeQLG9RoFSUWiCSP9r49YHQz0ybMJs6kryVxU4cmg3IAXE9+igPvxoJADD/NMz75UBNXXd1JpKmpC/G8DdHExsv0udG+B/0kfmKIlBIr3KEuuBtKdAB5m68l6QqFn3+kbcXTQEjRzaGBYZZMNqfC4QgoHYTvZJMy5ccCI3QPoWSmgQcn6O2/gAod9yYn4dRz0nhIKV6167dNhW/UMETaXeWNBDOUnY4E/cHX3qqVT0WW6SSJ98qq9BFyAKf642yh0Dt2mK3MQsJKqzz3d4r+m8dfy5K5OM+613UmHSnSR7pgxvr4ccJNgB5FH2qjzqskXn8H9NlZgG4bZcSultjS3fig+azPt1N/1AMa/Pdj1fhvW5MD5DStVl4mkbjwZWGthkZldbcEL9tjOhFVLgaNyZ13GuDfA5XFb1CjG4hOn/fVz6C6BUcALA2/6CbWv5DYQ+Vv7RJTqdrh4qAI98V6R6Up7LkhOPr0IJ8smVc4iZ5GUOur0BV9L4OEg457qhCmBMA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR01MB5849.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(136003)(396003)(366004)(39850400004)(4326008)(2906002)(53546011)(186003)(54906003)(478600001)(6486002)(2616005)(6666004)(956004)(31696002)(66556008)(66946007)(66476007)(8676002)(31686004)(86362001)(316002)(8936002)(52116002)(38100700002)(38350700002)(6916009)(16576012)(5660300002)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?knEK2ZqJfiRi3AUbpt9p3D86N1tYBJfTIJLfByZmWAsxURqlDEFqvzd9ox+j?= =?us-ascii?Q?9ZrIp+utA8JXfev7mtHmwA/oztHtr8HhRD8dWYUo+Nd+cXQ3/5msGrcYcxLX?= =?us-ascii?Q?p37MMNiI0r0OzwLibZjowTbn5wwdtxePJeHzVt38EM82l+gFO1DFagcJSMfe?= =?us-ascii?Q?pFlNuPJBdr3p1bONyjMCsUrgm9WzBgWId8S5k1jmEO9Qnzd7nbrFIZCuhfCu?= =?us-ascii?Q?qZQUvt+dd9L8mtSAXw9wwnkZ1IA0Aqq6Qhyd6oU0AGjlLCdbIxIdpgbPQOPH?= =?us-ascii?Q?j2N37SunZtRGBSlrONUTHfHs7OSLe0lBgRofxQW0xXve/KFhRSP5EVHe9l1l?= =?us-ascii?Q?+iODXf9xxRHBv8rMO6sxP9jYjFqAqPxkz/9yzN2VfCs8B0Vtj6CWoCwjPhm+?= =?us-ascii?Q?pdHMh4X3VpbUN0fnuBv0qYcY0hib7jb+10SVHO3eaRnqEN2eTcP1nmiWl6W5?= =?us-ascii?Q?ltj1YJFmdfu4JNO4ff3gAbpxG27MP5eQkTy2nNSszoS1GYw4sVJR73rHqvPZ?= =?us-ascii?Q?peFzUZNzR1NllJn59ME/KOPVKzVE+s1RmQo6bhcalZK8xEe+LEOnUIXa6hKB?= =?us-ascii?Q?XH7D8sOlHcFVFoqrIYZ4syzB3t5cJLpfy+dD73M/LV0baGXloDudoHkPAmzt?= =?us-ascii?Q?BnKi3OK1azpQKjmg3UOzRO4Lb6Pn0MLlxkK6inE3yRd8B5M09S2J2TCZ1cOB?= =?us-ascii?Q?0G4Wi+/n1jiyaxfJo2fivox1kRU9PMHjeqQbQEl0T4Fk0CDCCC/lPN6d00ct?= =?us-ascii?Q?txEljwiFxfMKrwh5Sf3oibT/60jjOKfYbZywSaG0SMsDEf9Tq50sQwNuJ48J?= =?us-ascii?Q?jpUtdOSNi7uoV+95VmEjHtsP7XOC/fhiKXKhq1ufbxSq+d3nnKRmMjLBnECa?= =?us-ascii?Q?RhKwomm/DrINYMT37QWIoRP0+hqJhnPbXqOSQWb0fq0aTNoyW3YeH1RAnRvm?= =?us-ascii?Q?jBNWXkKlBMmFdcUSt0xWYXE8H1mBG+DqeTl+29bXE+NI9fK5eg2uZB6896zM?= =?us-ascii?Q?L14Wzx9dEUpTPMeiRrWKsPiMF743juvcYEd9i3dH8emF+qSn2VS8FgyyCCre?= =?us-ascii?Q?SIp2hbtB8TDeAyNRvEVf1KpUtUD7a2gVoeJboQocAW9T7I9nNQTNf7RdL48Y?= =?us-ascii?Q?15Qothna6PLl4pJ8djku6hKFu+qJvZl+0QTVRL+NTJtc46ADu7S4at1jurpz?= =?us-ascii?Q?UIZ4Zy/A2dPuNSOF1HHWb/cVFTdePMI6M7N52IQLqM/Cs7n0UpMVxrt7Z85Z?= =?us-ascii?Q?C3ZbWAtrZmKWgSP322lMstpzyfrQF3LS+kf0KvMezk5qhoX8ZJzDyais2z5E?= =?us-ascii?Q?XI5+xvzs3pf365j86D8f0pzA?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50bcd909-68ea-4aaf-aa68-08d979a323d9 X-MS-Exchange-CrossTenant-AuthSource: DM6PR01MB5849.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2021 06:19:44.0232 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZismFSvlmtv4QxgnKPDHlJqgcV43YWZw+RxyA+XHXMzpFJQvfqoOCcoPKC4cDwojw5soS1L5H1+wo/UDAz/PjYJxfOAdzqMDfK9ECkywgSk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR01MB6807 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US On 16/09/2021 17:46, Leif Lindholm wrote: > On Thu, Sep 16, 2021 at 11:40:45 +0100, Leif Lindholm wrote: >> On Wed, Sep 15, 2021 at 22:55:00 +0700, Nhi Pham wrote: >>> From: Vu Nguyen >>> >>> This commit adds the support for Ampere=E2=80=99s Altra processor-based= Mt. Jade >>> platform that provides up to 160 processor cores in a dual socket >>> configuration. The essential modules are wired up enough to boot system >>> to EDK2 UiApp. >>> >>> Cc: Thang Nguyen >>> Cc: Chuong Tran >>> Cc: Phong Vo >>> Cc: Leif Lindholm >>> Cc: Michael D Kinney >>> Cc: Ard Biesheuvel >>> Cc: Nate DeSimone >>> >>> Signed-off-by: Vu Nguyen >> Reviewed-by: Leif Lindholm > Err, actually, no. > > You cannot give sign-off for Vu, but you need to sign off for > yourself. So we will need a v4. > If this patch in that set contains your Signed-off-by, and no-one > elses, that can retain my reviewed-by. Will fix it. > > Please address this situation for all other affected patches in the > set. But don't send out v4 vefore v3 review is complete. Yes, will fix for all patches violating the sign-off rule. Thanks, -Nhi > > Best Regards, > > Leif