Re: [PATCH 0/3] BaseTools,EmbeddedPkg,Maintainers.txt: Obsolete some drivers

["Ard Biesheuvel" <ard.biesheuvel@arm.com>]

On 4/29/20 9:53 PM, Leif Lindholm wrote:
> On Wed, Apr 29, 2020 at 19:51:12 +0200, Ard Biesheuvel wrote:
>> On 4/29/20 6:36 PM, Leif Lindholm wrote:
>>> We keep seeing new users (and copies) of EmbeddedPkg:s MmcDxe, which
>>> while it predates the MdeModulePkg SD/(E)MMCsupport is in effect
>>> unmaintained and also duplicates core industry standard definitions.
>>>
>>> Since we now have GetMaintainers.py to parse Maintainers.txt for us,
>>> extend its functionality to warn about less supported code.
>>>
>>> Then as an indication of its unsuitability for reference (or use), set
>>> its Status flag in Maintainers.txt to Obsolete.
>>>
>>> Once this is done, follow up and do the same with the hardware drivers
>>> (not the software ones) still left in EmbeddedPkg/Drivers. They were
>>> added back when not using the UEFI driver model was still cool, or
>>> simply before edk2-platforms existed.
>>> They should move to edk2-platforms, but most of them require some
>>> level of rewriting before that.
>>>
>>> 1/3 adds a warning printout to GetMaintainer.py
>>>
>>> 2/3 obsoletes EmbeddedPkg/Universal/MmcDxe/
>>>
>>> 3/3 obsoletes remaining hw drivers in EmbeddedPkg/Drivers
>>> Cc: Andrew Fish <afish@apple.com>
>>>
>>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>>> Cc: Bob Feng <bob.c.feng@intel.com>
>>> Cc: Laszlo Ersek <lersek@redhat.com>
>>> Cc: Liming Gao <liming.gao@intel.com>
>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>>
>>> Leif Lindholm (3):
>>>     BaseTools: add handling for 'S:' flag to GetMaintainer.py
>>>     Maintainers.txt: mark EmbeddedPkg MmcDxe as Obsolete
>>>     Maintainers.txt: mark EmbeddedPkg hw drivers as bsolete
>>>
>>
>> Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
>>
>> I am mostly concerned about the use of MmcDxe in new platforms. The other
>> bits I'm not too worried about, and I think it would be fine to move those
>> into Platform/ARM/VExpressPkg in edk2-platforms, instead of hoping that
>> someone will turn up and turn them into driver model drivers.
> 
> We could, although I would prefer not adding code to edk2-platforms
> that would not be accepted was it submitted as a new contribution.
> The SATA controller, I would ideally re-review and merge properly.
> 
> If we do include the other drivers in platform-specific directories, I
> want them to come with ... strongly worded readmes.
> 

Right.

Should we have some format for that? A way to log shortcomings along 
with the code?

>> One thing I'd like to do in the short term is renaming
>> gEfiMmcHostProtocolGuid, given that it violates the naming rules, and move
>> the PL180 driver to edk2-platforms.
> 
> I did think about moving PL180 as well. I'm not opposed to moving
> it. I don't think it's widely used.
> 
>> Any thoughts about DwEmmcDxe? Only HiKey uses that at the moment,
>> given that socfpga apparently switched to the generic version.
> 
> Well, if nothing else it might be a useful scream test. Same comment
> on strongly worded readme.
> 

OK