From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 89558941866 for ; Mon, 8 Jan 2024 12:22:12 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ebRPhUkhigkNDLxmaarBQy+cGhDwgs2liHqL5T3mCc0=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704716531; v=1; b=cKj8ZNz2YigUm8r7OoHX2wIx44edbEVZnw/6suU/xcGvJlxjZ/7GE37fua7GNBiufCPcD73S KyjLX1lczYLPgtojx3IlXGqLf5g+UfCu9Qk1IHyeqiEVsQClhrhhEyZSygIlU5wBrnyDwq5t4F3 Zq1lcwAAyYnfmX+n/Zx8vhBM= X-Received: by 127.0.0.2 with SMTP id FLqSYY7687511xoEF4aaKwNX; Mon, 08 Jan 2024 04:22:11 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.5345.1704716530641276434 for ; Mon, 08 Jan 2024 04:22:10 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-558-8NifMVCpMsKNypLWhbt-GA-1; Mon, 08 Jan 2024 07:22:03 -0500 X-MC-Unique: 8NifMVCpMsKNypLWhbt-GA-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1AE23835146; Mon, 8 Jan 2024 12:22:03 +0000 (UTC) X-Received: from [10.39.192.221] (unknown [10.39.192.221]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B19791121306; Mon, 8 Jan 2024 12:22:02 +0000 (UTC) Message-ID: <464c3901-e6b6-309a-6c86-d7c0b47342d6@redhat.com> Date: Mon, 8 Jan 2024 13:22:01 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [Patch V3 0/2] Change the usage of input parameter ProcessorNumber in MpInitLibGetProcessorInfo() of MpInitLibUp To: devel@edk2.groups.io, dun.tan@intel.com References: <20240108050804.1718-1-dun.tan@intel.com> From: "Laszlo Ersek" In-Reply-To: <20240108050804.1718-1-dun.tan@intel.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 4sT6UalUBVrmg4efvJ9k38ssx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=cKj8ZNz2; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/8/24 06:08, duntan wrote: > Please ignore the V2 PATCH set. No other change except adding BaseMemoryL= ib headfile and lib instance in .inf to pass build since ZeroMem() is used.= =20 Reviewed-by: Laszlo Ersek >=20 > Comparing to the V1 patch set: > In "set EXTENDED_PROCESSOR_INFORMATION to 0", set EXTENDED_PROCESSOR_INFO= RMATION to 0 in API MpInitLibGetProcessorInfo() of MpInitLibUp. This commit= use ZeroMem() to set all fileds in output EFI_PROCESSOR_INFORMATION to 0 b= efore StatusFlag field is reassigned. >=20 > In "Check lower 24 bits of ProcessorNumber", use BIT24 instead of CPU_V2_= EXTENDED_TOPOLOGY to clearly tell that processor number only occupies the l= ower 24 bits. >=20 > Dun Tan (2): > UefiCpuPkg: set EXTENDED_PROCESSOR_INFORMATION to 0 > UefiCpuPkg: Check lower 24 bits of ProcessorNumber >=20 > UefiCpuPkg/Include/Library/MpInitLib.h | 2 ++ > UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 ++ > UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.c | 20 ++++++++++++-------- > UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.inf | 1 + > 4 files changed, 17 insertions(+), 8 deletions(-) >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113388): https://edk2.groups.io/g/devel/message/113388 Mute This Topic: https://groups.io/mt/103592277/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-