Re: [PATCH v2 edk2-platforms 2/3] Platform/ARM/BdsLib: drop unused functions

[Laszlo Ersek <lersek@redhat.com>]

On 11/23/18 09:44, Ard Biesheuvel wrote:
> Clean up BdsLib (which is deprecated and should not be used for future
> development) by removing all the pieces that are not being used at the
> moment.
> 
> After this patch, only BdsLoadImage() remains, and the pieces it relies
> upon. This function is used by FdtPlatformDxe to load device tree
> binaries from device paths.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  Platform/ARM/Include/Library/BdsLib.h       | 186 -------------
>  Platform/ARM/Library/BdsLib/BdsAppLoader.c  | 253 ------------------
>  Platform/ARM/Library/BdsLib/BdsFilePath.c   |  83 +-----
>  Platform/ARM/Library/BdsLib/BdsHelper.c     | 122 ---------
>  Platform/ARM/Library/BdsLib/BdsInternal.h   |  15 +-
>  Platform/ARM/Library/BdsLib/BdsLib.inf      |   2 -
>  Platform/ARM/Library/BdsLib/BdsLoadOption.c | 272 --------------------
>  7 files changed, 13 insertions(+), 920 deletions(-)

Heh, this diffstat is a bit beyond my willingness to review in detail :)
I do see it only removes lines, so if it compiles, it must be good.
Also, BdsConnectDevicePath() in particular is removed:

> -/**
> -  Connect a Device Path and return the handle of the driver that support this DevicePath
> -
> -  @param  DevicePath            Device Path of the File to connect
> -  @param  Handle                Handle of the driver that support this DevicePath
> -  @param  RemainingDevicePath   Remaining DevicePath nodes that do not match the driver DevicePath
> -
> -  @retval EFI_SUCCESS           A driver that matches the Device Path has been found
> -  @retval EFI_NOT_FOUND         No handles match the search.
> -  @retval EFI_INVALID_PARAMETER DevicePath or Handle is NULL
> -
> -**/
> -EFI_STATUS
> -BdsConnectDevicePath (
> -  IN  EFI_DEVICE_PATH_PROTOCOL* DevicePath,
> -  OUT EFI_HANDLE                *Handle,
> -  OUT EFI_DEVICE_PATH_PROTOCOL  **RemainingDevicePath
> -  )
> -{
> -  return BdsConnectAndUpdateDevicePath (&DevicePath, Handle, RemainingDevicePath);
> -}

Hence:

Acked-by: Laszlo Ersek <lersek@redhat.com>

Thanks
Laszlo