From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 43A6F21191F34 for ; Fri, 23 Nov 2018 04:39:36 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BF4D5308339C; Fri, 23 Nov 2018 12:39:35 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-112.rdu2.redhat.com [10.10.120.112]) by smtp.corp.redhat.com (Postfix) with ESMTP id EA45A194AE; Fri, 23 Nov 2018 12:39:34 +0000 (UTC) To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: nariman.poushin@linaro.org References: <20181123084406.27192-1-ard.biesheuvel@linaro.org> <20181123084406.27192-3-ard.biesheuvel@linaro.org> From: Laszlo Ersek Message-ID: <464eecf8-6300-ba21-25fd-301ea8f49014@redhat.com> Date: Fri, 23 Nov 2018 13:39:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181123084406.27192-3-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Fri, 23 Nov 2018 12:39:35 +0000 (UTC) Subject: Re: [PATCH v2 edk2-platforms 2/3] Platform/ARM/BdsLib: drop unused functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Nov 2018 12:39:36 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/23/18 09:44, Ard Biesheuvel wrote: > Clean up BdsLib (which is deprecated and should not be used for future > development) by removing all the pieces that are not being used at the > moment. > > After this patch, only BdsLoadImage() remains, and the pieces it relies > upon. This function is used by FdtPlatformDxe to load device tree > binaries from device paths. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > Platform/ARM/Include/Library/BdsLib.h | 186 ------------- > Platform/ARM/Library/BdsLib/BdsAppLoader.c | 253 ------------------ > Platform/ARM/Library/BdsLib/BdsFilePath.c | 83 +----- > Platform/ARM/Library/BdsLib/BdsHelper.c | 122 --------- > Platform/ARM/Library/BdsLib/BdsInternal.h | 15 +- > Platform/ARM/Library/BdsLib/BdsLib.inf | 2 - > Platform/ARM/Library/BdsLib/BdsLoadOption.c | 272 -------------------- > 7 files changed, 13 insertions(+), 920 deletions(-) Heh, this diffstat is a bit beyond my willingness to review in detail :) I do see it only removes lines, so if it compiles, it must be good. Also, BdsConnectDevicePath() in particular is removed: > -/** > - Connect a Device Path and return the handle of the driver that support this DevicePath > - > - @param DevicePath Device Path of the File to connect > - @param Handle Handle of the driver that support this DevicePath > - @param RemainingDevicePath Remaining DevicePath nodes that do not match the driver DevicePath > - > - @retval EFI_SUCCESS A driver that matches the Device Path has been found > - @retval EFI_NOT_FOUND No handles match the search. > - @retval EFI_INVALID_PARAMETER DevicePath or Handle is NULL > - > -**/ > -EFI_STATUS > -BdsConnectDevicePath ( > - IN EFI_DEVICE_PATH_PROTOCOL* DevicePath, > - OUT EFI_HANDLE *Handle, > - OUT EFI_DEVICE_PATH_PROTOCOL **RemainingDevicePath > - ) > -{ > - return BdsConnectAndUpdateDevicePath (&DevicePath, Handle, RemainingDevicePath); > -} Hence: Acked-by: Laszlo Ersek Thanks Laszlo