From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120])
 by mx.groups.io with SMTP id smtpd.web12.11905.1582883615858386088
 for <devel@edk2.groups.io>;
 Fri, 28 Feb 2020 01:53:36 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DiaOP14b;
 spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1582883614;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=myZhmC6i/eeO0Wo6T6dTt3sxBRMHXjE+KM5yKmIdkPU=;
	b=DiaOP14bWF8N/rQR0jafedWZ/HkEr9LHDPgFOB3Mig76ASFq4pBamzxlxbvwIpcwXkXiTa
	bPPFPUk31G5aaJgbjXLeYjwvL7KcnEscFDtWDR3vRnCsQVXhYbMphBLGmOm5/+xbIoGeNI
	sZH5Mkh3O9VRae2w/Jr6iEUap7i2yKM=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-382-3eB0Oi0CPm-QR2H7sT7-uA-1; Fri, 28 Feb 2020 04:53:31 -0500
X-MC-Unique: 3eB0Oi0CPm-QR2H7sT7-uA-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C54A68017CC;
	Fri, 28 Feb 2020 09:53:29 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-243.ams2.redhat.com [10.36.116.243])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 10D906E3EE;
	Fri, 28 Feb 2020 09:53:27 +0000 (UTC)
Subject: Re: [PATCH v2 09/13] OvmfPkg/MptScsiDxe: Open PciIo protocol for later use
From: "Laszlo Ersek" <lersek@redhat.com>
To: Nikita Leshenko <nikita.leshchenko@oracle.com>, devel@edk2.groups.io
Cc: liran.alon@oracle.com, aaron.young@oracle.com, jordan.l.justen@intel.com,
 ard.biesheuvel@linaro.org
References: <20200226164151.125182-1-nikita.leshchenko@oracle.com>
 <20200226164151.125182-10-nikita.leshchenko@oracle.com>
 <3f352fe2-fec1-d827-dc32-b95e5bea8c1f@redhat.com>
Message-ID: <465290b3-8af3-838a-c026-0c339c6cd042@redhat.com>
Date: Fri, 28 Feb 2020 10:53:27 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <3f352fe2-fec1-d827-dc32-b95e5bea8c1f@redhat.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

On 02/28/20 10:50, Laszlo Ersek wrote:

> In particular, in patch "OvmfPkg/MptScsiDxe: Install stubbed
> EXT_SCSI_PASS_THRU", the pattern should be laid out like this:
> 
> -----------
>   Status = gBS->InstallProtocolInterface (...);
>   if (EFI_ERROR (Status)) {
>     goto FreeDev;
>   }
>   return EFI_SUCCESS;
> 
> FreeDev:
>   FreePool (Dev);
> 
>   return Status;
> -----------
> 
> and then the rest of the patches should build upon that -- introduce new
> labels always at the top of the existent "stack" of labels.

If it's OK with you, I'd like to stop reviewing version 2 at this point.
I'm going to be tripped up continuously by the mixing of goto +
conditional release.

I'll make an effort to review v3 reasonably quickly once you post it.

Thanks,
Laszlo