From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (NAM02-BN1-obe.outbound.protection.outlook.com [40.107.212.135]) by mx.groups.io with SMTP id smtpd.web10.34379.1683765590510584361 for ; Wed, 10 May 2023 17:39:50 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="no key for verify" header.i=@amperemail.onmicrosoft.com header.s=selector1-amperemail-onmicrosoft-com header.b=kDEbrWkB; spf=pass (domain: os.amperecomputing.com, ip: 40.107.212.135, mailfrom: minhnguyen1@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HM8YKIS58H8e1GJRSUh66v3rdortqvpCQSlnwOp8zMkrpExEDCQe1yKR40X0M7qzlMjFvFPbvuGY2If2Fi+vigNfwWsbZsvr3/9x9SAe11Bmvpreah87jS1MTEL4QuG1K5RdrGv2rLHS0zTwimo5OBNTm21zhl5BT35TVhN0qrAhD0tYUQ9s+T1MfuJRjL1DN24EKHXI6UoE/+Ow04h3r2tG+n4G8CUcZ2t5waX63mMvnz6VmNh/cA/+ockCtHzb5iRJx+ID/SNpoqGkJWgi+WUgz/d+sGtDVe4mtODvZ9MQiMlLDNMs0Yz9svymQMrshqwaPb2KkpRnox3hUzK9lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DG+IUBJ2AWnaTi0b+IElRHH6kW2xGOzsrcuMhZ2DDns=; b=Utwwue54MiMq+AGOOpWF2dbMKaHozHMTNN0E0CpPxV2HjeE/HrbdLoAJ03gICUHmNICO/l63C1XfywD9r7PGoc0cGSzh3OwarliUx99Q4Ckn8A7CffUtPSi0EtF7Cyu5WWb/Y+bqyLK0yD4xEZ81MsmwW0d1FUbg6Hftdhu/M0XNkqF5lvjfRkjmHNUZNUa0jzMbNkHHAKY75G4N7nM0dFt970UxBUVmorUVXjf5mC7SMsBGTb+7WroZvuLuCsex3UdJV9ErbENsKiON0zWwSUEtwO1WYNQRpn6GfKZ3vslyeZIdnXQleXh1Z0GfFrqEZNkFaLSjDVjAtaHAPtsf/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=amperemail.onmicrosoft.com; dkim=pass header.d=amperemail.onmicrosoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amperemail.onmicrosoft.com; s=selector1-amperemail-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DG+IUBJ2AWnaTi0b+IElRHH6kW2xGOzsrcuMhZ2DDns=; b=kDEbrWkBgtKAIbNJxPSqsmf3uCEQrFOiswBAWNvF0xqNNPqT1k2faOkPLH2B9HLMH4elDg3i5q7m32yGVKXWilP3VQD4NJxt7gfNwbRLVEwDd/HzjJZuBDd0pj9S7Y9mtWJgW0dbAV/wXnXbcvuJ4y6Jwou4xaOe/WOg91AKhVs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amperemail.onmicrosoft.com; Received: from PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) by SN6PR01MB5053.prod.exchangelabs.com (2603:10b6:805:cd::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Thu, 11 May 2023 00:39:28 +0000 Received: from PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1]) by PH0PR01MB8048.prod.exchangelabs.com ([fe80::bbdb:b58c:140e:c4e1%6]) with mapi id 15.20.6387.019; Thu, 11 May 2023 00:39:27 +0000 Message-ID: <465ae064-f69f-e4a7-50e8-bcf1bc401840@amperemail.onmicrosoft.com> Date: Thu, 11 May 2023 07:39:18 +0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [edk2-devel][edk2-platforms][PATCH 0/2] Support for PCIe Auto Bifurcation feature To: Ard Biesheuvel , "nhi@os.amperecomputing.com" CC: Minh Nguyen , quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, devel@edk2.groups.io, patches@amperecomputing.com, thang@os.amperecomputing.com, tinhnguyen@os.amperecomputing.com References: <20230505024918.1447433-1-minhnguyen1@os.amperecomputing.com> From: Minh Nguyen In-Reply-To: X-ClientProxiedBy: SI1PR02CA0054.apcprd02.prod.outlook.com (2603:1096:4:1f5::13) To PH0PR01MB8048.prod.exchangelabs.com (2603:10b6:510:280::7) Return-Path: minhnguyen1@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB8048:EE_|SN6PR01MB5053:EE_ X-MS-Office365-Filtering-Correlation-Id: ab1a8453-7552-4009-b526-08db51b82cb3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sL3DZpDNJsQ8MiPY58SnYhhB5nw3X/hizZjA71vWtFa7lmTppuRosBm4Q6+RmxTaDkOeb7kJGkHaZFMGqnx0VToMb19zmC8SxcRNELtBTMp+l1waXb8wGWdQ3ZGRmSwpCwFE8H6KzVFGUxXDHNhTufQebHRQTfCgiXezvyRrniw9pQIqgsNluOniGtzSXHBRUwmDpTcfADto2bvcoC5uEV2fTphE1f60NEukf9oW5j1CkfRLTgIRaQUGcOwUahO+MqpTfNIVmcGzJRuQIOJLVSbN2NvPSMOU3L3u7U+bZyegp2gCG9yWcbyt9nVVoWOL1X2UFGxR0Byzppravb/K5S9ZqaQZmhzVBPBzKQCSzywURYkmENE+qTdVRrqrGKnVD/Hx30Q4FpayibBuGecqt/eDsU2JiMh2Vul2fKPSJj8V+MVEEh0+08FLKVCVP5eYBIjA1o+xfp2wnTVU5d2orvGM9YCTQTywpcCe3IAuEztv9/Ww6t7s0CwOWp7Ko4THUwTa4bsjoXFLY7EUPnqWCYOwJEq+44Kuhkd5Fx4hJO2yZ1Ot6w/NbJy0P5mGeoku7mhfIxCFgE0hv2SHbgwZIOuOy8I1A+2hCn4QIbl3BpwA2rJtJywfzC5K1kUJvgBZ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR01MB8048.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(366004)(346002)(136003)(39860400002)(376002)(451199021)(53546011)(31686004)(316002)(110136005)(6486002)(8936002)(6666004)(5660300002)(41300700001)(8676002)(66946007)(26005)(66556008)(478600001)(66476007)(4326008)(6512007)(6506007)(107886003)(186003)(2906002)(83380400001)(42882007)(2616005)(83170400001)(31696002)(38100700002)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YJRdDl0ea5ndGWNAKR1p2V+F4rRt/pn9ydZuM8s1EWSyUUKfIuQ6wt4g2RmY?= =?us-ascii?Q?QRQPj9nx1DS0x4CUMAvyLXuxvI1ai12DAA3QcDQSj1e4UyECBSFdtaq1FAKX?= =?us-ascii?Q?szxR3VduION/gps3YhLHxFg1blgFss4rOkZumHIIwdz7Is0AF3NErF88U97M?= =?us-ascii?Q?m2dhw1Wp0KJieYzJ2VqILwM5Aui73RPlSr5XVBOsOOS7QqNSQMKKcdommjyH?= =?us-ascii?Q?FlRywYWwS25HieqRdGCYfD0X40H1JAsDHoZHN794CpLAcaMdpVspGPZPqdyS?= =?us-ascii?Q?5cq2StA5hL8CHv2o5yw1+SXExC9siecaZL8tg4mtrqHLncJDLr9jDbqwe8YM?= =?us-ascii?Q?SrjCWiL+9kF3fTXiJhT5Gy0j38cxRu0PxdARakMEc+uLMTadNNZo7sfv70wD?= =?us-ascii?Q?0h0BSOsijIxrMQ+WXDr5YYizvsKBpyb91gbdNrOVA7uM1v9ElrC4aIPSsnSu?= =?us-ascii?Q?+maAFFr4tXyXyG5nnCg8Vsy1ohiXG4N5iNMrytFMIcgKxPtDR2qqow3Q8VQJ?= =?us-ascii?Q?bPbUGIb4L2Xjg9SpMnRuCtHgv5t2TGEcHS2f1z5/U/ZyEhWzVu+mVJU2E/X6?= =?us-ascii?Q?Q/dcFPJzvfURHNOA05+jWkFOQUMwnggMDRcdm98Nx/TZj49jS0NzgN4bLssy?= =?us-ascii?Q?4n/fVB2eB2VnGfMGYv4qc+0yJLWol02Eb2AL7AFnsKywbbiZQl5NH8iaHQqx?= =?us-ascii?Q?VB5JJEcyZ5K7p/Vz3L33r6wRQGAsSSrxZofKrZEsw5EvciV0rOwB+J7r0iqx?= =?us-ascii?Q?z/ljp+ObenSMsjYtDevSlh+eYBNED0DEcHcRApbw9BDniqZrl1wWpzuJ1uU0?= =?us-ascii?Q?Rw9FUB/rWoX6jxQi9sSOIDgGdrAj8kH4fdBx1c6Ah6nW1fdPcOLamEUrnc6J?= =?us-ascii?Q?edFzuHN0F0eJDjasoh77g9XnimVUQUI9fhKiTlVb427KARvgqn+fFdDCrHl+?= =?us-ascii?Q?7Lhy8NHSGnqEQ9TZHn2mG0P+Z8RpwippdbUjcU4YPj4BeqXzV2q49ZghySdc?= =?us-ascii?Q?8kHrWTzwOfz8K1/LxekHFTI6wTDKS4Q5hZRGv2l1wDyIteLbQtLj1Mjz+c78?= =?us-ascii?Q?IThrdY2EvOUjpJsKzohCwvWCq209TnJQ2TQdXeU6P7Hx1OMxyPMgqip1Hgyj?= =?us-ascii?Q?3MIpYAANQ4fxE/EJITkdaFoRH5XGwEdO478RjUkMiIPgx84LfkxkYUXReFyx?= =?us-ascii?Q?q8/ND+N7wwQtfKAAXRD8Cp7ALS16Dr82rb2keAY+wBrbJCeW4nxSa34K6QZW?= =?us-ascii?Q?PeIjgFVFsqADesZtBbBvon2HTgK9I7iMDY4DeUWRjoThoJK2PQvsNM27RxfF?= =?us-ascii?Q?JxdafvzEudfQCFauext2rUwSLzroj/1omMscS57SeTSbwtmhQCVRCjXKlF9t?= =?us-ascii?Q?nfwW+pN/2R7k8Ea88Lmb8oHRi3aIGqWy/PbaPhMfr/IRFzkYldSCoPbl64Qn?= =?us-ascii?Q?J2CMUl7X8oDgX7rShenM2YFbnyWohFpBay69a2CMJ2Tds23FysNYXKoFwsay?= =?us-ascii?Q?ZBej5Fbjn+weuh5w0+ks3dOVgET70/jIB8HmXGsnmVgXqbNc8E+uj0WdOl3H?= =?us-ascii?Q?Tn26lf0DKgD0u3LAk3nhbuHnyWK6ahH8Rpk9Yft/awtIzJkAeuAenDibFl7m?= =?us-ascii?Q?lqNazHK/5uKTdu12CUnqBpg=3D?= X-OriginatorOrg: amperemail.onmicrosoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab1a8453-7552-4009-b526-08db51b82cb3 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB8048.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2023 00:39:27.3515 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: atSqqsKNpc7cjPh/rzQwp/F2nP/G1BxwFZ1j9mTNwamEM3Ej5ffsdwDqwdvopSwXAnTXAb4QpPO03UWDJ6qWnk/b+I0CQwea+diNY6JNS505gN4uwNfG4uUl9gqpQvTu X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR01MB5053 Content-Language: en-CA Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi all, =C2=A0Thanks a lot for reviewing these patches Thanks, Minh Nguyen On 5/10/2023 1:11 PM, Ard Biesheuvel wrote: > On Wed, 10 May 2023 at 07:59, Nhi Pham w= rote: >> Thanks Minh for this series. It looks good to me. >> >> Reviewed-by: Nhi Pham >> >> Hi Leif, Ard - Could you please help merge this series? >> > Pushed as 7ac91ec277db..c91f8862ae87 > > Thanks all > > >> On 5/5/2023 9:49 AM, Minh Nguyen wrote: >>> These patches support for PCIe Auto Bifurcation feature of Ampere >>> silicon (Altra and Altra Max). >>> >>> Vu Nguyen (2): >>> AmpereAltraPkg: Add support for PCIe Auto Bifurcation >>> AmpereAltraPkg: Enable auto bifurcation via BoardSetting >>> >>> Silicon/Ampere/AmpereAltraPkg/Drivers/PcieInitPei/RootComplexNVParam= .h | 4 +- >>> Silicon/Ampere/AmpereAltraPkg/Include/Guid/RootComplexInfoHob.h = | 5 +- >>> Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.h = | 5 + >>> Silicon/Ampere/AmpereAltraPkg/Drivers/PcieInitPei/RootComplexNVParam= .c | 14 +- >>> Silicon/Ampere/AmpereAltraPkg/Drivers/RootComplexConfigDxe/RootCompl= exConfigDxe.c | 19 +- >>> Silicon/Ampere/AmpereAltraPkg/Library/Ac01PcieLib/PcieCore.c = | 344 +++++++++++++++++++- >>> Silicon/Ampere/AmpereAltraPkg/Drivers/RootComplexConfigDxe/RootCompl= exConfigDxe.uni | 3 +- >>> 7 files changed, 383 insertions(+), 11 deletions(-) >>>