Re: [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec: drop bogus semicolon from GUID def

[Laszlo Ersek <lersek@redhat.com>]

On 11/17/16 13:04, Yao, Jiewen wrote:
> Reviewed-by: Jiewen.yao@intel.com

Thanks! Commit 2048ab4b3ec9.

Laszlo

> 
>> -----Original Message-----
>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>> Laszlo Ersek
>> Sent: Thursday, November 17, 2016 6:37 PM
>> To: edk2-devel-01 <edk2-devel@ml01.01.org>
>> Cc: Yao, Jiewen <jiewen.yao@intel.com>
>> Subject: [edk2] [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec: drop bogus
>> semicolon from GUID def
>>
>> The DEC spec doesn't allow the trailing semicolon:
>>
>>   2.6 [Guids] Usage
>>
>>   GuidCName = {C Format Guid Value} # Comment
>>
>> Cc: Giri P Mudusuru <giri.p.mudusuru@intel.com>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>>  IntelSiliconPkg/IntelSiliconPkg.dec | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/IntelSiliconPkg/IntelSiliconPkg.dec
>> b/IntelSiliconPkg/IntelSiliconPkg.dec
>> index 4a51d0a547da..8819cb8fed6b 100644
>> --- a/IntelSiliconPkg/IntelSiliconPkg.dec
>> +++ b/IntelSiliconPkg/IntelSiliconPkg.dec
>> @@ -26,7 +26,7 @@ [Includes]
>>  [Guids]
>>    ## GUID for Package token space
>>    # {A9F8D54E-1107-4F0A-ADD0-4587E7A4A735}
>> -  gIntelSiliconPkgTokenSpaceGuid  = { 0xa9f8d54e, 0x1107, 0x4f0a, { 0xad,
>> 0xd0, 0x45, 0x87, 0xe7, 0xa4, 0xa7, 0x35 } };
>> +  gIntelSiliconPkgTokenSpaceGuid  = { 0xa9f8d54e, 0x1107, 0x4f0a,
>> { 0xad, 0xd0, 0x45, 0x87, 0xe7, 0xa4, 0xa7, 0x35 } }
>>
>>    ## HOB GUID to publish SMBIOS data records from PEI phase
>>    # HOB data format is same as SMBIOS records defined in SMBIOS spec or
>> OEM defined types
>> --
>> 2.9.2
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel