From: "Mudusuru, Giri P" <giri.p.mudusuru@intel.com>
To: "Fan, Jeff" <jeff.fan@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"Tian, Feng" <feng.tian@intel.com>,
Laszlo Ersek <lersek@redhat.com>
Subject: Re: [Patch v5 02/48] UefiCpuPkg/MpInitLib: Add microcode definitions defined in IA32 SDM
Date: Tue, 2 Aug 2016 15:20:20 +0000 [thread overview]
Message-ID: <4666AEFED60F8E4198B42BB01DCEABDF76E9D2D0@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <1470128388-17960-3-git-send-email-jeff.fan@intel.com>
Reviewed-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
> -----Original Message-----
> From: Fan, Jeff
> Sent: Tuesday, August 2, 2016 1:59 AM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Tian, Feng
> <feng.tian@intel.com>; Mudusuru, Giri P <giri.p.mudusuru@intel.com>; Laszlo
> Ersek <lersek@redhat.com>
> Subject: [Patch v5 02/48] UefiCpuPkg/MpInitLib: Add microcode definitions
> defined in IA32 SDM
>
> Add microcode definitions defined in Intel(R) 64 and IA-32 Architectures
> Software Developer's Manual Volume 3A, Section 9.11.
>
> v4:
> 1. ProcessorSignature type changed to
> CPU_MICROCODE_PROCESSOR_SIGNATURE
> 2. Add pack(1) for structure CPU_MICROCODE_HEADER and
> CPU_MICROCODE_EXTENDED_TABLE.
> v3:
> 1. Update SDM date to June, 2016
> 2. Mention BCD format in CPU_MICROCODE_DATE
> 3. Rename ProcessorChecksum to Checksum to match SDM.
>
> Cc: Michael Kinney <michael.d.kinney@intel.com>
> Cc: Feng Tian <feng.tian@intel.com>
> Cc: Giri P Mudusuru <giri.p.mudusuru@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jeff Fan <jeff.fan@intel.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> ---
> UefiCpuPkg/Include/Register/Microcode.h | 200
> ++++++++++++++++++++++++++++++++
> 1 file changed, 200 insertions(+)
> create mode 100644 UefiCpuPkg/Include/Register/Microcode.h
>
> diff --git a/UefiCpuPkg/Include/Register/Microcode.h
> b/UefiCpuPkg/Include/Register/Microcode.h
> new file mode 100644
> index 0000000..94529a1
> --- /dev/null
> +++ b/UefiCpuPkg/Include/Register/Microcode.h
> @@ -0,0 +1,200 @@
> +/** @file
> + Microcode Definitions.
> +
> + Microcode Definitions based on contents of the
> + Intel(R) 64 and IA-32 Architectures Software Developer's Manual
> + Volume 3A, Section 9.11 Microcode Definitions
> +
> + Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
> + This program and the accompanying materials
> + are licensed and made available under the terms and conditions of the BSD
> License
> + which accompanies this distribution. The full text of the license may be found
> at
> + http://opensource.org/licenses/bsd-license.php
> +
> + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
> BASIS,
> + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> EXPRESS OR IMPLIED.
> +
> + @par Specification Reference:
> + Intel(R) 64 and IA-32 Architectures Software Developer's Manual, Volume 3A,
> + June 2016, Chapter 9 Processor Management and Initialization, Section 9-11.
> +
> +**/
> +
> +#ifndef __MICROCODE_H__
> +#define __MICROCODE_H__
> +
> +///
> +/// CPU Microcode Date in BCD format
> +///
> +typedef union {
> + struct {
> + UINT32 Year:16;
> + UINT32 Day:8;
> + UINT32 Month:8;
> + } Bits;
> + UINT32 Uint32;
> +} CPU_MICROCODE_DATE;
> +
> +///
> +/// CPU Microcode Processor Signature format
> +///
> +typedef union {
> + struct {
> + UINT32 Stepping:4;
> + UINT32 Model:4;
> + UINT32 Family:4;
> + UINT32 Type:2;
> + UINT32 Reserved1:2;
> + UINT32 ExtendedModel:4;
> + UINT32 ExtendedFamily:8;
> + UINT32 Reserved2:4;
> + } Bits;
> + UINT32 Uint32;
> +} CPU_MICROCODE_PROCESSOR_SIGNATURE;
> +
> +#pragma pack (1)
> +
> +///
> +/// Microcode Update Format definition
> +///
> +typedef struct {
> + ///
> + /// Version number of the update header
> + ///
> + UINT32 HeaderVersion;
> + ///
> + /// Unique version number for the update, the basis for the update
> + /// signature provided by the processor to indicate the current update
> + /// functioning within the processor. Used by the BIOS to authenticate
> + /// the update and verify that the processor loads successfully. The
> + /// value in this field cannot be used for processor stepping identification
> + /// alone. This is a signed 32-bit number.
> + ///
> + UINT32 UpdateRevision;
> + ///
> + /// Date of the update creation in binary format: mmddyyyy (e.g.
> + /// 07/18/98 is 07181998H).
> + ///
> + CPU_MICROCODE_DATE Date;
> + ///
> + /// Extended family, extended model, type, family, model, and stepping
> + /// of processor that requires this particular update revision (e.g.,
> + /// 00000650H). Each microcode update is designed specifically for a
> + /// given extended family, extended model, type, family, model, and
> + /// stepping of the processor.
> + /// The BIOS uses the processor signature field in conjunction with the
> + /// CPUID instruction to determine whether or not an update is
> + /// appropriate to load on a processor. The information encoded within
> + /// this field exactly corresponds to the bit representations returned by
> + /// the CPUID instruction.
> + ///
> + CPU_MICROCODE_PROCESSOR_SIGNATURE ProcessorSignature;
> + ///
> + /// Checksum of Update Data and Header. Used to verify the integrity of
> + /// the update header and data. Checksum is correct when the
> + /// summation of all the DWORDs (including the extended Processor
> + /// Signature Table) that comprise the microcode update result in
> + /// 00000000H.
> + ///
> + UINT32 Checksum;
> + ///
> + /// Version number of the loader program needed to correctly load this
> + /// update. The initial version is 00000001H
> + ///
> + UINT32 LoaderRevision;
> + ///
> + /// Platform type information is encoded in the lower 8 bits of this 4-
> + /// byte field. Each bit represents a particular platform type for a given
> + /// CPUID. The BIOS uses the processor flags field in conjunction with
> + /// the platform Id bits in MSR (17H) to determine whether or not an
> + /// update is appropriate to load on a processor. Multiple bits may be set
> + /// representing support for multiple platform IDs.
> + ///
> + UINT32 ProcessorFlags;
> + ///
> + /// Specifies the size of the encrypted data in bytes, and must be a
> + /// multiple of DWORDs. If this value is 00000000H, then the microcode
> + /// update encrypted data is 2000 bytes (or 500 DWORDs).
> + ///
> + UINT32 DataSize;
> + ///
> + /// Specifies the total size of the microcode update in bytes. It is the
> + /// summation of the header size, the encrypted data size and the size of
> + /// the optional extended signature table. This value is always a multiple
> + /// of 1024.
> + ///
> + UINT32 TotalSize;
> + ///
> + /// Reserved fields for future expansion.
> + ///
> + UINT8 Reserved[12];
> +} CPU_MICROCODE_HEADER;
> +
> +///
> +/// Extended Signature Table Header Field Definitions
> +///
> +typedef struct {
> + ///
> + /// Specifies the number of extended signature structures (Processor
> + /// Signature[n], processor flags[n] and checksum[n]) that exist in this
> + /// microcode update
> + ///
> + UINT32 ExtendedSignatureCount;
> + ///
> + /// Checksum of update extended processor signature table. Used to
> + /// verify the integrity of the extended processor signature table.
> + /// Checksum is correct when the summation of the DWORDs that
> + /// comprise the extended processor signature table results in
> + /// 00000000H.
> + ///
> + UINT32 ExtendedChecksum;
> + ///
> + /// Reserved fields.
> + ///
> + UINT8 Reserved[12];
> +} CPU_MICROCODE_EXTENDED_TABLE_HEADER;
> +
> +///
> +/// Extended Signature Table Field Definitions
> +///
> +typedef struct {
> + ///
> + /// Extended family, extended model, type, family, model, and stepping
> + /// of processor that requires this particular update revision (e.g.,
> + /// 00000650H). Each microcode update is designed specifically for a
> + /// given extended family, extended model, type, family, model, and
> + /// stepping of the processor.
> + /// The BIOS uses the processor signature field in conjunction with the
> + /// CPUID instruction to determine whether or not an update is
> + /// appropriate to load on a processor. The information encoded within
> + /// this field exactly corresponds to the bit representations returned by
> + /// the CPUID instruction.
> + ///
> + CPU_MICROCODE_PROCESSOR_SIGNATURE ProcessorSignature;
> + ///
> + /// Platform type information is encoded in the lower 8 bits of this 4-
> + /// byte field. Each bit represents a particular platform type for a given
> + /// CPUID. The BIOS uses the processor flags field in conjunction with
> + /// the platform Id bits in MSR (17H) to determine whether or not an
> + /// update is appropriate to load on a processor. Multiple bits may be set
> + /// representing support for multiple platform IDs.
> + ///
> + UINT32 ProcessorFlag;
> + ///
> + /// Used by utility software to decompose a microcode update into
> + /// multiple microcode updates where each of the new updates is
> + /// constructed without the optional Extended Processor Signature
> + /// Table.
> + /// To calculate the Checksum, substitute the Primary Processor
> + /// Signature entry and the Processor Flags entry with the
> + /// corresponding Extended Patch entry. Delete the Extended Processor
> + /// Signature Table entries. The Checksum is correct when the
> + /// summation of all DWORDs that comprise the created Extended
> + /// Processor Patch results in 00000000H.
> + ///
> + UINT32 Checksum;
> +} CPU_MICROCODE_EXTENDED_TABLE;
> +
> +#pragma pack ()
> +
> +#endif
> --
> 2.7.4.windows.1
next prev parent reply other threads:[~2016-08-02 15:20 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 8:59 [Patch v5 00/48] MP Initialize Library Jeff Fan
2016-08-02 8:59 ` [Patch v5 01/48] UefiCpuPkg/LocalApic.h: Remove duplicated/conflicted definitions Jeff Fan
2016-08-02 17:17 ` Kinney, Michael D
2016-08-02 8:59 ` [Patch v5 02/48] UefiCpuPkg/MpInitLib: Add microcode definitions defined in IA32 SDM Jeff Fan
2016-08-02 15:20 ` Mudusuru, Giri P [this message]
2016-08-02 8:59 ` [Patch v5 03/48] UefiCpuPkg/CpuS3DataDxe: Move StartupVector allocation to EndOfDxe() Jeff Fan
2016-08-02 8:59 ` [Patch v5 04/48] UefiCpuPkg/MpInitLib: Add MP Initialize library class definition Jeff Fan
2016-08-02 8:59 ` [Patch v5 05/48] UefiCpuPkg/MpInitLib: Add two instances PeiMpInitLib and DxeMpInitLib Jeff Fan
2016-08-02 8:59 ` [Patch v5 06/48] UefiCpuPkg/MpInitLib: Add AP assembly code and MP_CPU_EXCHANGE_INFO Jeff Fan
2016-08-02 8:59 ` [Patch v5 07/48] UefiCpuPkg/MpInitLib: Fix typo and clean up the code Jeff Fan
2016-08-02 8:59 ` [Patch v5 08/48] UefiCpuPkg/MpInitLib: Add EnableExecuteDisable in MP_CPU_EXCHANGE_INFO Jeff Fan
2016-08-02 8:59 ` [Patch v5 09/48] UefiCpuPkg/MpInitLib: Add AsmRelocateApLoop() assembly code Jeff Fan
2016-08-02 8:59 ` [Patch v5 10/48] UefiCpuPkg/MpInitLib: Add MP_ASSEMBLY_ADDRESS_MAP Jeff Fan
2016-08-02 8:59 ` [Patch v5 11/48] UefiCpuPkg/MpInitLib: Get ApLoopMode and MointorFilter size Jeff Fan
2016-08-02 8:59 ` [Patch v5 12/48] UefiCpuPkg/MpInitLib: Allocate and initialize memory of MP Data buffer Jeff Fan
2016-08-02 8:59 ` [Patch v5 13/48] UefiCpuPkg/MpInitLib: Initialize CPU_AP_DATA for CPU APs Jeff Fan
2016-08-02 8:59 ` [Patch v5 14/48] UefiCpuPkg/MpInitLib: Add CPU_VOLATILE_REGISTERS & worker functions Jeff Fan
2016-08-02 8:59 ` [Patch v5 15/48] UefiCpuPkg/MpInitLib: Add MicrocodeDetect() and load microcode on BSP Jeff Fan
2016-08-02 8:59 ` [Patch v5 16/48] UefiCpuPkg/MpInitLib: Save CPU MP Data pointer Jeff Fan
2016-08-02 8:59 ` [Patch v5 17/48] UefiCpuPkg/MpInitLib: Register one End of PEI callback function Jeff Fan
2016-08-02 8:59 ` [Patch v5 18/48] UefiCpuPkg/MpInitLib: Register one period event to check APs status Jeff Fan
2016-08-02 8:59 ` [Patch v5 19/48] UefiCpuPkg/MpInitLib: Allocate AP reset vector buffer under 1MB Jeff Fan
2016-08-02 8:59 ` [Patch v5 20/48] UefiCpuPkg/MpInitLib: Add ApWakeupFunction() executed by assembly code Jeff Fan
2016-08-02 8:59 ` [Patch v5 21/48] UefiCpuPkg/MpInitLib: Fill MP_CPU_EXCHANGE_INFO fields Jeff Fan
2016-08-02 8:59 ` [Patch v5 22/48] UefiCpuPkg/MpInitLib: Add WakeUpAP() Jeff Fan
2016-08-02 8:59 ` [Patch v5 23/48] UefiCpuPkg/MpInitLib: Send INIT-SIPI-SIPI to get processor count Jeff Fan
2016-08-02 8:59 ` [Patch v5 24/48] UefiCpuPkg/MpInitLib: Enable x2APIC mode on BSP/APs Jeff Fan
2016-08-02 8:59 ` [Patch v5 25/48] UefiCpuPkg/MpInitLib: Sort processor by ascending order of APIC ID Jeff Fan
2016-08-02 8:59 ` [Patch v5 26/48] UefiCpuPkg/MpInitLib: Skip collect processor count if GUIDed HOB exist Jeff Fan
2016-08-02 8:59 ` [Patch v5 27/48] UefiCpuPkg/MpInitLib: Implementation of MpInitLibGetNumberOfProcessors() Jeff Fan
2016-08-02 8:59 ` [Patch v5 28/48] UefiCpuPkg/MpInitLib: Implementation of MpInitLibGetProcessorInfo() Jeff Fan
2016-08-02 8:59 ` [Patch v5 29/48] UefiCpuPkg/MpInitLib: Implementation of MpInitLibWhoAmI() Jeff Fan
2016-08-02 8:59 ` [Patch v5 30/48] UefiCpuPkg/MpInitLib: Implementation of MpInitLibSwitchBSP() Jeff Fan
2016-08-02 8:59 ` [Patch v5 31/48] UefiCpuPkg/MpInitLib: Implementation of MpInitLibEnableDisableAP() Jeff Fan
2016-08-02 8:59 ` [Patch v5 32/48] UefiCpuPkg/MpInitLib: Check APs Status and update APs status Jeff Fan
2016-08-02 8:59 ` [Patch v5 33/48] UefiCpuPkg/MpInitLib: Implementation of MpInitLibStartupThisAP() Jeff Fan
2016-08-02 8:59 ` [Patch v5 34/48] UefiCpuPkg/MpInitLib: Implementation of MpInitLibStartupAllAPs() Jeff Fan
2016-08-02 8:59 ` [Patch v5 35/48] UefiCpuPkg/MpInitLib: Place APs in safe loop before hand-off to OS Jeff Fan
2016-08-02 8:59 ` [Patch v5 36/48] OvmfPkg: Add MpInitLib reference in DSC files Jeff Fan
2016-08-02 11:39 ` Laszlo Ersek
2016-08-02 8:59 ` [Patch v5 37/48] QuarkPlatformPkg: " Jeff Fan
2016-08-02 8:59 ` [Patch v5 38/48] UefiCpuPkg/CpuMpPei: Consume MpInitLib to produce CPU MP PPI services Jeff Fan
2016-08-02 8:59 ` [Patch v5 39/48] UefiCpuPkg/CpuMpPei: Remove unused files and codes Jeff Fan
2016-08-02 8:59 ` [Patch v5 40/48] UefiCpuPkg/CpuMpPei: Delete PeiMpServices.c and PeiMpServices.h Jeff Fan
2016-08-02 8:59 ` [Patch v5 41/48] UefiCpuPkg/CpuDxe: Consume MpInitLib to produce CPU MP Protocol services Jeff Fan
2016-08-02 8:59 ` [Patch v5 42/48] UefiCpuPkg/CpuDxe: Move SetMtrrsFromBuffer() location Jeff Fan
2016-08-02 8:59 ` [Patch v5 43/48] UefiCpuPkg/CpuDxe: Remove unused codes and files Jeff Fan
2016-08-02 8:59 ` [Patch v5 44/48] UefiCpuPkg/CpuDxe: Remove PcdCpuMaxLogicalProcessorNumber consuming Jeff Fan
2016-08-02 8:59 ` [Patch v5 45/48] MdePkg/MpService.h: Fixed typo in function header to match PI spec Jeff Fan
2016-08-02 8:59 ` [Patch v5 46/48] MdePkg/MpService.h: Trim whitespace at end of line Jeff Fan
2016-08-02 8:59 ` [Patch v5 47/48] UefiCpuPkg/CpuDxe: Fixed typo in function header to match PI spec Jeff Fan
2016-08-02 8:59 ` [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency Jeff Fan
2016-08-19 1:19 ` Laszlo Ersek
2016-08-19 2:00 ` Fan, Jeff
2016-08-19 2:26 ` Laszlo Ersek
2016-08-19 2:45 ` Zeng, Star
2016-08-19 2:57 ` Zeng, Star
2016-08-19 13:19 ` Laszlo Ersek
2016-08-23 15:33 ` Laszlo Ersek
2016-08-24 2:39 ` Zeng, Star
2016-08-24 3:27 ` Laszlo Ersek
[not found] ` <ea6bfac6-1f9c-a0f6-c4ce-0b147136f34e@intel.com>
2016-08-24 8:16 ` Zeng, Star
2016-08-24 11:53 ` Laszlo Ersek
2016-08-24 13:42 ` Zeng, Star
2016-08-25 8:00 ` Fan, Jeff
2016-08-30 13:45 ` Laszlo Ersek
2016-09-01 1:11 ` Fan, Jeff
2016-09-01 17:46 ` Laszlo Ersek
2016-09-02 0:49 ` Fan, Jeff
2016-08-19 14:28 ` Laszlo Ersek
2016-08-02 18:55 ` [Patch v5 00/48] MP Initialize Library Kinney, Michael D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4666AEFED60F8E4198B42BB01DCEABDF76E9D2D0@ORSMSX113.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox