public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Mudusuru, Giri P" <giri.p.mudusuru@intel.com>
To: "Ma, Maurice" <maurice.ma@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>
Subject: Re: [PATCH] IntelFsp2Pkg: Only include required header files in FspEas.h
Date: Fri, 5 Aug 2016 05:44:14 +0000	[thread overview]
Message-ID: <4666AEFED60F8E4198B42BB01DCEABDF76EA08B7@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <c6e7ebb4cc163a054cf4fb20c3e3156242be05ca.1470370785.git.maurice.ma@intel.com>

Reviewed-by: Giri P Mudusuru <giri.p.mudusuru@intel.com> 

> -----Original Message-----
> From: Ma, Maurice
> Sent: Thursday, August 4, 2016 9:20 PM
> To: edk2-devel@lists.01.org
> Cc: Ma, Maurice <maurice.ma@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>; Mudusuru, Giri P <giri.p.mudusuru@intel.com>
> Subject: [edk2] [PATCH] IntelFsp2Pkg: Only include required header files in
> FspEas.h
> 
> Current FspEas.h file includes Uefi.h which also refers to lots of other
> UEFI header files not used by FSP consumer. It caused many unnecessary
> header file overhead for a bootloader that consumes FSP, such as coreboot.
> This change reduces the required header file number down to 3.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Giri P Mudusuru <giri.p.mudusuru@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Maurice Ma <maurice.ma@intel.com>
> ---
>  IntelFsp2Pkg/Include/FspEas.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/IntelFsp2Pkg/Include/FspEas.h b/IntelFsp2Pkg/Include/FspEas.h
> index 79bb0b8e8efc..00098a392699 100644
> --- a/IntelFsp2Pkg/Include/FspEas.h
> +++ b/IntelFsp2Pkg/Include/FspEas.h
> @@ -16,7 +16,7 @@
>  #ifndef _FSP_EAS_H_
>  #define _FSP_EAS_H_
> 
> -#include <Uefi.h>
> +#include <Uefi/UefiBaseType.h>
>  #include <Guid/GuidHobFspEas.h>
>  #include <Guid/FspHeaderFile.h>
>  #include <FspEas/FspApi.h>
> --
> 1.9.5.msysgit.0



      reply	other threads:[~2016-08-05  5:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-05  4:20 [PATCH] IntelFsp2Pkg: Only include required header files in FspEas.h Maurice Ma
2016-08-05  5:44 ` Mudusuru, Giri P [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4666AEFED60F8E4198B42BB01DCEABDF76EA08B7@ORSMSX113.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox