* [PATCH] IntelFsp2Pkg: Only include required header files in FspEas.h
@ 2016-08-05 4:20 Maurice Ma
2016-08-05 5:44 ` Mudusuru, Giri P
0 siblings, 1 reply; 2+ messages in thread
From: Maurice Ma @ 2016-08-05 4:20 UTC (permalink / raw)
To: edk2-devel; +Cc: Maurice Ma, Jiewen Yao, Giri P Mudusuru
Current FspEas.h file includes Uefi.h which also refers to lots of other
UEFI header files not used by FSP consumer. It caused many unnecessary
header file overhead for a bootloader that consumes FSP, such as coreboot.
This change reduces the required header file number down to 3.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Giri P Mudusuru <giri.p.mudusuru@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Maurice Ma <maurice.ma@intel.com>
---
IntelFsp2Pkg/Include/FspEas.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/IntelFsp2Pkg/Include/FspEas.h b/IntelFsp2Pkg/Include/FspEas.h
index 79bb0b8e8efc..00098a392699 100644
--- a/IntelFsp2Pkg/Include/FspEas.h
+++ b/IntelFsp2Pkg/Include/FspEas.h
@@ -16,7 +16,7 @@
#ifndef _FSP_EAS_H_
#define _FSP_EAS_H_
-#include <Uefi.h>
+#include <Uefi/UefiBaseType.h>
#include <Guid/GuidHobFspEas.h>
#include <Guid/FspHeaderFile.h>
#include <FspEas/FspApi.h>
--
1.9.5.msysgit.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] IntelFsp2Pkg: Only include required header files in FspEas.h
2016-08-05 4:20 [PATCH] IntelFsp2Pkg: Only include required header files in FspEas.h Maurice Ma
@ 2016-08-05 5:44 ` Mudusuru, Giri P
0 siblings, 0 replies; 2+ messages in thread
From: Mudusuru, Giri P @ 2016-08-05 5:44 UTC (permalink / raw)
To: Ma, Maurice, edk2-devel@lists.01.org; +Cc: Yao, Jiewen
Reviewed-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
> -----Original Message-----
> From: Ma, Maurice
> Sent: Thursday, August 4, 2016 9:20 PM
> To: edk2-devel@lists.01.org
> Cc: Ma, Maurice <maurice.ma@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>; Mudusuru, Giri P <giri.p.mudusuru@intel.com>
> Subject: [edk2] [PATCH] IntelFsp2Pkg: Only include required header files in
> FspEas.h
>
> Current FspEas.h file includes Uefi.h which also refers to lots of other
> UEFI header files not used by FSP consumer. It caused many unnecessary
> header file overhead for a bootloader that consumes FSP, such as coreboot.
> This change reduces the required header file number down to 3.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Giri P Mudusuru <giri.p.mudusuru@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Maurice Ma <maurice.ma@intel.com>
> ---
> IntelFsp2Pkg/Include/FspEas.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/IntelFsp2Pkg/Include/FspEas.h b/IntelFsp2Pkg/Include/FspEas.h
> index 79bb0b8e8efc..00098a392699 100644
> --- a/IntelFsp2Pkg/Include/FspEas.h
> +++ b/IntelFsp2Pkg/Include/FspEas.h
> @@ -16,7 +16,7 @@
> #ifndef _FSP_EAS_H_
> #define _FSP_EAS_H_
>
> -#include <Uefi.h>
> +#include <Uefi/UefiBaseType.h>
> #include <Guid/GuidHobFspEas.h>
> #include <Guid/FspHeaderFile.h>
> #include <FspEas/FspApi.h>
> --
> 1.9.5.msysgit.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-05 5:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-05 4:20 [PATCH] IntelFsp2Pkg: Only include required header files in FspEas.h Maurice Ma
2016-08-05 5:44 ` Mudusuru, Giri P
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox