From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 340781A1E05 for ; Mon, 29 Aug 2016 16:43:46 -0700 (PDT) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP; 29 Aug 2016 16:43:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,253,1470726000"; d="scan'208";a="2538149" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by orsmga004.jf.intel.com with ESMTP; 29 Aug 2016 16:43:30 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.118]) by ORSMSX107.amr.corp.intel.com ([169.254.1.26]) with mapi id 14.03.0248.002; Mon, 29 Aug 2016 16:43:29 -0700 From: "Mudusuru, Giri P" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: "Yao, Jiewen" , "Ma, Maurice" , "Yarlagadda, Satya P" Thread-Topic: [edk2] [PATCH 3/3] IntelFsp2WrapperPkg: Update pragma to use push and pop Thread-Index: AQHSAiEqF1Cvc0i9W0yquYKIkUED2aBgu/6A///d2gA= Date: Mon, 29 Aug 2016 23:43:29 +0000 Message-ID: <4666AEFED60F8E4198B42BB01DCEABDF76EC11A0@ORSMSX113.amr.corp.intel.com> References: In-Reply-To: Accept-Language: en-US, hi-IN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Subject: Re: [PATCH 3/3] IntelFsp2WrapperPkg: Update pragma to use push and pop X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Aug 2016 23:43:46 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Mike, sent updated patch v2 removing the push, pop change. Thanks, -Giri > -----Original Message----- > From: Kinney, Michael D > Sent: Monday, August 29, 2016 11:45 AM > To: Mudusuru, Giri P ; edk2-devel@lists.01.org= ; > Kinney, Michael D > Cc: Yao, Jiewen ; Ma, Maurice > ; Yarlagadda, Satya P > > Subject: RE: [edk2] [PATCH 3/3] IntelFsp2WrapperPkg: Update pragma to use > push and pop >=20 > Giri, >=20 > Just leave this as #pragma pack(1) and #pragma pack() to follow the > style used everywhere else. >=20 > EDK II sources assume the default packing is natural packing. The compile= r > Configuration in tools_def.txt need to make sure natural packing is the d= efault. >=20 > Mike >=20 > > -----Original Message----- > > From: Mudusuru, Giri P > > Sent: Monday, August 29, 2016 11:14 AM > > To: edk2-devel@lists.01.org > > Cc: Yao, Jiewen ; Ma, Maurice > ; Yarlagadda, > > Satya P ; Kinney, Michael D > > > Subject: [edk2] [PATCH 3/3] IntelFsp2WrapperPkg: Update pragma to use p= ush > and pop > > > > Cc: Jiewen Yao > > Cc: Maurice Ma > > Cc: Satya Yarlagadda > > Cc: Michael Kinney > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Giri P Mudusuru > > --- > > .../Library/BaseFspWrapperApiLib/X64/DispatchExecute.c = | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git > a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/DispatchExecute.c > > > b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/DispatchExecute.c > > index 061d381..5f4b75e 100644 > > --- > a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/DispatchExecute.c > > +++ > b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/DispatchExecute.c > > @@ -18,7 +18,7 @@ > > #include > > #include > > > > -#pragma pack(1) > > +#pragma pack(push, 1) > > typedef union { > > struct { > > UINT32 LimitLow : 16; > > @@ -37,7 +37,7 @@ typedef union { > > } Bits; > > UINT64 Uint64; > > } IA32_GDT; > > -#pragma pack() > > +#pragma pack(pop) > > > > GLOBAL_REMOVE_IF_UNREFERENCED IA32_GDT mGdtEntries[] =3D { > > {{0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}}, /* 0x0= : reserve */ > > -- > > 2.9.0.windows.1