From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F2DDD1A1E73 for ; Wed, 12 Oct 2016 18:56:22 -0700 (PDT) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP; 12 Oct 2016 18:56:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,338,1473145200"; d="scan'208";a="19499555" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by orsmga004.jf.intel.com with ESMTP; 12 Oct 2016 18:56:22 -0700 Received: from orsmsx154.amr.corp.intel.com (10.22.226.12) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 12 Oct 2016 18:56:22 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.161]) by ORSMSX154.amr.corp.intel.com ([10.22.226.12]) with mapi id 14.03.0248.002; Wed, 12 Oct 2016 18:56:22 -0700 From: "Mudusuru, Giri P" To: "Ma, Maurice" , "edk2-devel@lists.01.org" CC: "Yao, Jiewen" Thread-Topic: [edk2] [PATCH] IntelFsp2Pkg/FspSecCore: Make FSP funcitons position independent Thread-Index: AQHSJO2aju6UUF0mFE+cjW5xSnDj4aCln9Gw Date: Thu, 13 Oct 2016 01:56:21 +0000 Message-ID: <4666AEFED60F8E4198B42BB01DCEABDF76F11BA7@ORSMSX113.amr.corp.intel.com> References: <7ea97596e527f44a8d69170d0481c21ff087c565.1476320550.git.maurice.ma@intel.com> In-Reply-To: <7ea97596e527f44a8d69170d0481c21ff087c565.1476320550.git.maurice.ma@intel.com> Accept-Language: en-US, hi-IN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Subject: Re: [PATCH] IntelFsp2Pkg/FspSecCore: Make FSP funcitons position independent X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Oct 2016 01:56:23 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for fixing the bug Maurice. Please fix the typo funcitons in the tit= le during checkin Reviewed-by: Giri P Mudusuru =20 > -----Original Message----- > From: Ma, Maurice > Sent: Wednesday, October 12, 2016 6:03 PM > To: edk2-devel@lists.01.org > Cc: Ma, Maurice ; Yao, Jiewen > ; Mudusuru, Giri P > Subject: [edk2] [PATCH] IntelFsp2Pkg/FspSecCore: Make FSP funcitons posit= ion > independent >=20 > The current AsmGetFspInfoHeader function in FspHeader.nasm is > position dependent code since it uses absolute address. Change > to use relative address instead to make it position independent. >=20 > Cc: Jiewen Yao > Cc: Giri P Mudusuru > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Maurice Ma > --- > IntelFsp2Pkg/FspSecCore/Ia32/FspHelper.nasm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspHelper.nasm > b/IntelFsp2Pkg/FspSecCore/Ia32/FspHelper.nasm > index a848dcbc0298..ad631943e32d 100644 > --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspHelper.nasm > +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspHelper.nasm > @@ -31,7 +31,7 @@ ASM_PFX(NextInstruction): > pop eax > sub eax, ASM_PFX(NextInstruction) > add eax, ASM_PFX(AsmGetFspInfoHeader) > - sub eax, dword [ASM_PFX(FspInfoHeaderRelativeOff)] > + sub eax, dword [eax - ASM_PFX(AsmGetFspInfoHeader) + > ASM_PFX(FspInfoHeaderRelativeOff)] > ret >=20 > global ASM_PFX(AsmGetFspInfoHeaderNoStack) > -- > 1.9.5.msysgit.0