From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C51EA1A1EC5 for ; Thu, 13 Oct 2016 22:31:19 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP; 13 Oct 2016 22:31:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,491,1473145200"; d="scan'208";a="179716448" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by fmsmga004.fm.intel.com with ESMTP; 13 Oct 2016 22:31:20 -0700 Received: from orsmsx163.amr.corp.intel.com (10.22.240.88) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 13 Oct 2016 22:31:18 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.161]) by ORSMSX163.amr.corp.intel.com ([10.22.240.88]) with mapi id 14.03.0248.002; Thu, 13 Oct 2016 22:31:18 -0700 From: "Mudusuru, Giri P" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Yao, Jiewen" Thread-Topic: [edk2] [PATCH] IntelSiliconPkg: Add Intel Firmware Version Info (FVI) definitions Thread-Index: AQHSJPcQZ/IRPayC9U+bvGfLMww4O6Cn0UwA//+bgEA= Date: Fri, 14 Oct 2016 05:31:17 +0000 Message-ID: <4666AEFED60F8E4198B42BB01DCEABDF76F128A6@ORSMSX113.amr.corp.intel.com> References: <3cbf3973c2ebfc9eaabec01bc3e8454df55b3f76.1476324515.git.giri.p.mudusuru@intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103958B71F@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103958B71F@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US, hi-IN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Subject: Re: [PATCH] IntelSiliconPkg: Add Intel Firmware Version Info (FVI) definitions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Oct 2016 05:31:20 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes Star thanks for catching the merge issue. Will fix it before check-in. Thanks, -Giri > -----Original Message----- > From: Zeng, Star > Sent: Thursday, October 13, 2016 9:25 PM > To: Mudusuru, Giri P ; edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Yao, Jiewen > ; Zeng, Star > Subject: RE: [edk2] [PATCH] IntelSiliconPkg: Add Intel Firmware Version I= nfo > (FVI) definitions >=20 > Shouldn't > +#include SmBios.h > be > +#include > ? >=20 > Thanks, > Star > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Gi= ri P > Mudusuru > Sent: Thursday, October 13, 2016 10:11 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Yao, Jiewen > > Subject: [edk2] [PATCH] IntelSiliconPkg: Add Intel Firmware Version Info = (FVI) > definitions >=20 > Adding Intel Firmware Version Info (FVI) related defines & structures. > FVI enables reporting the Firmware Versions using SMBIOS OEM Type. >=20 > Cc: Jiewen Yao > Cc: Michael Kinney > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Giri P Mudusuru > --- > .../Include/IndustryStandard/FirmwareVersionInfo.h | 60 > ++++++++++++++++++++++ > 1 file changed, 60 insertions(+) > create mode 100644 > IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h >=20 > diff --git a/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo= .h > b/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h > new file mode 100644 > index 0000000..4ac5e27 > --- /dev/null > +++ b/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h > @@ -0,0 +1,60 @@ > +/** @file > + Intel Firmware Version Info (FVI) related definitions. > + > + @todo: update document/spec reference > + > + Copyright (c) 2016, Intel Corporation. All rights reserved.
This > + program and the accompanying materials are licensed and made > + available under the terms and conditions of the BSD License which > + accompanies this distribution. The full text of the license may be > + found at http://opensource.org/licenses/bsd-license.php > + > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > + > +@par Specification Reference: > + System Management BIOS (SMBIOS) Reference Specification v3.0.0 dated > +2015-Feb-12 > + > +http://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.0 > +.0.pdf > + > +**/ > + > +#ifndef __FIRMWARE_VERSION_INFO_H__ > +#define __FIRMWARE_VERSION_INFO_H__ > + > +#include SmBios.h > + > +#define INTEL_FIRMWARE_VERSION_INFO_GROUP_NAME "Firmware > Version Info" > + > +#pragma pack(1) > + > +/// > +/// Firmware Version Structure > +/// > +typedef struct { > + UINT8 MajorVersion; > + UINT8 MinorVersion; > + UINT8 Revision; > + UINT16 BuildNumber; > +} INTEL_FIRMWARE_VERSION; > + > +/// > +/// Firmware Version Info (FVI) Structure /// typedef struct { > + SMBIOS_TABLE_STRING ComponentName; ///< String Index of > Component Name > + SMBIOS_TABLE_STRING VersionString; ///< String Index of Versi= on String > + INTEL_FIRMWARE_VERSION Version; ///< Firmware version > +} INTEL_FIRMWARE_VERSION_INFO; > + > +/// > +/// SMBIOS OEM Type Intel Firmware Version Info (FVI) Structure /// > +typedef struct { > + SMBIOS_STRUCTURE Header; ///< SMBIOS structure head= er > + UINT8 Count; ///< Number of FVI entries= in this structure > + INTEL_FIRMWARE_VERSION_INFO Fvi[1]; ///< FVI structure(s) > +} SMBIOS_TABLE_TYPE_OEM_INTEL_FVI; > + > +#pragma pack() > + > +#endif > -- > 2.9.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel