From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AE1691A1E05 for ; Tue, 18 Oct 2016 06:55:51 -0700 (PDT) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP; 18 Oct 2016 06:55:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,362,1473145200"; d="scan'208";a="774081777" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by FMSMGA003.fm.intel.com with ESMTP; 18 Oct 2016 06:55:51 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.161]) by ORSMSX108.amr.corp.intel.com ([169.254.2.106]) with mapi id 14.03.0248.002; Tue, 18 Oct 2016 06:55:50 -0700 From: "Mudusuru, Giri P" To: "Yao, Jiewen" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Gao, Liming" Thread-Topic: [edk2] [PATCH] MdePkg: Add ACPI Low Power Idle Table (LPIT) definitions Thread-Index: AQHSKTJRymkYCNKviUmiFNkLe7QwxaCuqnuA//+RkkA= Date: Tue, 18 Oct 2016 13:55:49 +0000 Message-ID: <4666AEFED60F8E4198B42BB01DCEABDF76F17149@ORSMSX113.amr.corp.intel.com> References: <4be670ac09a39bcdcb50989e88fe0924382bd6b4.1476789783.git.giri.p.mudusuru@intel.com> <74D8A39837DF1E4DA445A8C0B3885C50386B3161@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C50386B3161@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US, hi-IN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Subject: Re: [PATCH] MdePkg: Add ACPI Low Power Idle Table (LPIT) definitions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2016 13:55:51 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Agree Jiewen will update it before pushing the patch. Thanks,=20 -Giri > -----Original Message----- > From: Yao, Jiewen > Sent: Tuesday, October 18, 2016 6:30 AM > To: Mudusuru, Giri P ; edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > > Subject: RE: [edk2] [PATCH] MdePkg: Add ACPI Low Power Idle Table (LPIT) > definitions >=20 > HI > I recommend we just use #include . > Acpi.h includes all ACPI version. There is no need to include Acpi61.h. >=20 > With this change, reviewed-by: Jiewen.yao@intel.com >=20 >=20 > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Giri P Mudusuru > > Sent: Tuesday, October 18, 2016 7:25 PM > > To: edk2-devel@lists.01.org > > Cc: Kinney, Michael D ; Yao, Jiewen > > ; Gao, Liming > > Subject: [edk2] [PATCH] MdePkg: Add ACPI Low Power Idle Table (LPIT) > > definitions > > > > ACPI Low Power Idle Table (LPIT) Revision 001, dated July 2014 > > http://www.uefi.org/sites/default/files/resources/ACPI_Low_Power_Idle_T > > able.pdf > > > > Cc: Michael Kinney > > Cc: Liming Gao > > Cc: Jiewen Yao > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Giri P Mudusuru > > --- > > .../Include/IndustryStandard/LowPowerIdleTable.h | 82 > > ++++++++++++++++++++++ > > 1 file changed, 82 insertions(+) > > create mode 100644 > > MdePkg/Include/IndustryStandard/LowPowerIdleTable.h > > > > diff --git a/MdePkg/Include/IndustryStandard/LowPowerIdleTable.h > > b/MdePkg/Include/IndustryStandard/LowPowerIdleTable.h > > new file mode 100644 > > index 0000000..b29db04 > > --- /dev/null > > +++ b/MdePkg/Include/IndustryStandard/LowPowerIdleTable.h > > @@ -0,0 +1,82 @@ > > +/** @file > > + ACPI Low Power Idle Table (LPIT) definitions > > + > > + Copyright (c) 2016, Intel Corporation. All rights reserved.
> > + This program and the accompanying materials > > + are licensed and made available under the terms and conditions of th= e > > BSD License > > + which accompanies this distribution. The full text of the license m= ay be > > found at > > + http://opensource.org/licenses/bsd-license.php > > + > > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > > BASIS, > > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > > EXPRESS OR IMPLIED. > > + > > + @par Revision Reference: > > + - ACPI Low Power Idle Table (LPIT) Revision 001, dated July 2014 > > + > > http://www.uefi.org/sites/default/files/resources/ACPI_Low_Power_Idle_T > > able.pdf > > + > > + @par Glossary: > > + - GAS - Generic Address Structure > > + - LPI - Low Power Idle > > +**/ > > +#ifndef _LOW_POWER_IDLE_TABLE_H_ > > +#define _LOW_POWER_IDLE_TABLE_H_ > > + > > +#include > > + > > +#pragma pack(1) > > + > > +/// > > +/// LPI Structure Types > > +/// > > +#define ACPI_LPI_STRUCTURE_TYPE_NATIVE_CSTATE 0x00 > > + > > +/// > > +/// Low Power Idle (LPI) State Flags > > +/// > > +typedef union { > > + struct { > > + UINT32 Disabled : 1; ///< If set, LPI state is not used > > + /** > > + If set, Residency counter is not available for this LPI state an= d > > + Residency Counter Frequency is invalid > > + **/ > > + UINT32 CounterUnavailable : 1; > > + UINT32 Reserved : 30; ///< Reserved for future use. Must > > be zero > > + } Bits; > > + UINT32 Data32; > > +} ACPI_LPI_STATE_FLAGS; > > + > > +/// > > +/// Low Power Idle (LPI) structure with Native C-state instruction ent= ry > > trigger descriptor > > +/// > > +typedef struct { > > + UINT32 Type; ///< LPI State > > descriptor Type 0 > > + UINT32 Length; ///< Length of > > LPI state Descriptor Structure > > + /// > > + /// Unique LPI state identifier: zero based, monotonically increasin= g > > identifier > > + /// > > + UINT16 UniqueId; > > + UINT8 Reserved[2]; ///< > > Must be Zero > > + ACPI_LPI_STATE_FLAGS Flags; ///< LPI > > state flags > > + /** > > + The LPI entry trigger, matching an existing _CST.Register object, > > represented as a > > + Generic Address Structure. All processors must request this state = or > > deeper to trigger. > > + **/ > > + EFI_ACPI_6_1_GENERIC_ADDRESS_STRUCTURE EntryTrigger; > > + UINT32 Residency; ///< > > Minimum residency or break-even in uSec > > + UINT32 Latency; ///< > > Worst case exit latency in uSec > > + /** > > + [optional] Residency counter, represented as a Generic Address > > Structure. > > + If not present, Flags[1] bit should be set. > > + **/ > > + EFI_ACPI_6_1_GENERIC_ADDRESS_STRUCTURE ResidencyCounter; > > + /** > > + [optional] Residency counter frequency in cycles per second. Value= 0 > > indicates that > > + counter runs at TSC frequency. Valid only if Residency Counter is > > present. > > + **/ > > + UINT64 > > ResidencyCounterFrequency; > > +} ACPI_LPI_NATIVE_CSTATE_DESCRIPTOR; > > + > > +#pragma pack() > > + > > +#endif > > -- > > 2.9.0.windows.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel