Re: [PATCH] IntelFsp2Pkg: Removing FSP Data Table

["Mudusuru, Giri P" <giri.p.mudusuru@intel.com>]

Reviewed-by: Giri P Mudusuru <giri.p.mudusuru@intel.com> 

> -----Original Message-----
> From: Yarlagadda, Satya P
> Sent: Thursday, October 20, 2016 5:46 PM
> To: edk2-devel@lists.01.org
> Cc: Ma, Maurice <maurice.ma@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>; Mudusuru, Giri P <giri.p.mudusuru@intel.com>
> Subject: [PATCH] IntelFsp2Pkg: Removing FSP Data Table
> 
> FSP Base address is part of FSP_INFO_HEADER and we don't need additional
> table to report the base address of FSP components. we expect Boot
> loaders to parse the FSP INFO Header to get the base address. Also, this
> the FSP_DATA_TABLE is not defined in the FSP EAS and we don't see a need
> for it.
> 
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Giri P Mudusuru <giri.p.mudusuru@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Satya Yarlagadda <satya.p.yarlagadda@intel.com>
> ---
>  IntelFsp2Pkg/Include/FspDataTable.h                | 32 ----------------------
>  .../Library/BaseFspCommonLib/FspCommonLib.c        |  1 -
>  2 files changed, 33 deletions(-)
>  delete mode 100644 IntelFsp2Pkg/Include/FspDataTable.h
> 
> diff --git a/IntelFsp2Pkg/Include/FspDataTable.h
> b/IntelFsp2Pkg/Include/FspDataTable.h
> deleted file mode 100644
> index 3c79f34..0000000
> --- a/IntelFsp2Pkg/Include/FspDataTable.h
> +++ /dev/null
> @@ -1,32 +0,0 @@
> -/** @file
> -  The header file of FSP data table
> -
> -  Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
> -  This program and the accompanying materials
> -  are licensed and made available under the terms and conditions of the BSD
> License
> -  which accompanies this distribution.  The full text of the license may be found
> at
> -  http://opensource.org/licenses/bsd-license.php.
> -
> -  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
> BASIS,
> -  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> EXPRESS OR IMPLIED.
> -
> -**/
> -
> -#ifndef _FSP_DATA_TABLE_H_
> -#define _FSP_DATA_TABLE_H_
> -
> -#pragma pack(1)
> -
> -#define FSP_DATA_SIGNATURE  SIGNATURE_32 ('F', 'S', 'P', 'D')
> -
> -typedef struct  {
> -  UINT32  Signature;
> -  UINT32  Length;
> -  UINT32  FsptBase;
> -  UINT32  FspmBase;
> -  UINT32  FspsBase;
> -} FSP_DATA_TABLE;
> -
> -#pragma pack()
> -
> -#endif
> diff --git a/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
> b/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
> index a9c8da6..2f2981c 100644
> --- a/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
> +++ b/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
> @@ -17,7 +17,6 @@
>  #include <Library/PcdLib.h>
>  #include <FspGlobalData.h>
>  #include <FspEas.h>
> -#include <FspDataTable.h>
>  #include <Library/FspSwitchStackLib.h>
> 
>  #pragma pack(1)
> --
> 2.10.0.windows.1