From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E7FAE1A1E34 for ; Thu, 20 Oct 2016 19:04:44 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP; 20 Oct 2016 19:04:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,374,1473145200"; d="scan'208";a="1073497890" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by fmsmga002.fm.intel.com with ESMTP; 20 Oct 2016 19:04:45 -0700 Received: from orsmsx155.amr.corp.intel.com (10.22.240.21) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 20 Oct 2016 19:04:43 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.50]) by ORSMSX155.amr.corp.intel.com ([10.22.240.21]) with mapi id 14.03.0248.002; Thu, 20 Oct 2016 19:04:43 -0700 From: "Mudusuru, Giri P" To: "Yarlagadda, Satya P" , "edk2-devel@lists.01.org" CC: "Ma, Maurice" , "Yao, Jiewen" Thread-Topic: [PATCH] IntelFsp2Pkg: Removing FSP Data Table Thread-Index: AQHSKzSWj6Li28MYMk6xLFJXesGs+6CyKHRw Date: Fri, 21 Oct 2016 02:04:42 +0000 Message-ID: <4666AEFED60F8E4198B42BB01DCEABDF76F26483@ORSMSX113.amr.corp.intel.com> References: <20161021004555.15076-1-satya.p.yarlagadda@intel.com> In-Reply-To: <20161021004555.15076-1-satya.p.yarlagadda@intel.com> Accept-Language: en-US, hi-IN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Subject: Re: [PATCH] IntelFsp2Pkg: Removing FSP Data Table X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2016 02:04:45 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Giri P Mudusuru =20 > -----Original Message----- > From: Yarlagadda, Satya P > Sent: Thursday, October 20, 2016 5:46 PM > To: edk2-devel@lists.01.org > Cc: Ma, Maurice ; Yao, Jiewen > ; Mudusuru, Giri P > Subject: [PATCH] IntelFsp2Pkg: Removing FSP Data Table >=20 > FSP Base address is part of FSP_INFO_HEADER and we don't need additional > table to report the base address of FSP components. we expect Boot > loaders to parse the FSP INFO Header to get the base address. Also, this > the FSP_DATA_TABLE is not defined in the FSP EAS and we don't see a need > for it. >=20 > Cc: Maurice Ma > Cc: Jiewen Yao > Cc: Giri P Mudusuru > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Satya Yarlagadda > --- > IntelFsp2Pkg/Include/FspDataTable.h | 32 ----------------= ------ > .../Library/BaseFspCommonLib/FspCommonLib.c | 1 - > 2 files changed, 33 deletions(-) > delete mode 100644 IntelFsp2Pkg/Include/FspDataTable.h >=20 > diff --git a/IntelFsp2Pkg/Include/FspDataTable.h > b/IntelFsp2Pkg/Include/FspDataTable.h > deleted file mode 100644 > index 3c79f34..0000000 > --- a/IntelFsp2Pkg/Include/FspDataTable.h > +++ /dev/null > @@ -1,32 +0,0 @@ > -/** @file > - The header file of FSP data table > - > - Copyright (c) 2016, Intel Corporation. All rights reserved.
> - This program and the accompanying materials > - are licensed and made available under the terms and conditions of the = BSD > License > - which accompanies this distribution. The full text of the license may= be found > at > - http://opensource.org/licenses/bsd-license.php. > - > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > - > -**/ > - > -#ifndef _FSP_DATA_TABLE_H_ > -#define _FSP_DATA_TABLE_H_ > - > -#pragma pack(1) > - > -#define FSP_DATA_SIGNATURE SIGNATURE_32 ('F', 'S', 'P', 'D') > - > -typedef struct { > - UINT32 Signature; > - UINT32 Length; > - UINT32 FsptBase; > - UINT32 FspmBase; > - UINT32 FspsBase; > -} FSP_DATA_TABLE; > - > -#pragma pack() > - > -#endif > diff --git a/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c > b/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c > index a9c8da6..2f2981c 100644 > --- a/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c > +++ b/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c > @@ -17,7 +17,6 @@ > #include > #include > #include > -#include > #include >=20 > #pragma pack(1) > -- > 2.10.0.windows.1