From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4F81E1A1DF5 for ; Sun, 23 Oct 2016 06:47:17 -0700 (PDT) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP; 23 Oct 2016 06:47:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,388,1473145200"; d="scan'208";a="22753560" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by orsmga005.jf.intel.com with ESMTP; 23 Oct 2016 06:47:17 -0700 Received: from orsmsx156.amr.corp.intel.com (10.22.240.22) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 23 Oct 2016 06:47:16 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.50]) by ORSMSX156.amr.corp.intel.com ([10.22.240.22]) with mapi id 14.03.0248.002; Sun, 23 Oct 2016 06:47:15 -0700 From: "Mudusuru, Giri P" To: "Yao, Jiewen" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Zeng, Star" Thread-Topic: [edk2] [PATCH] IntelSiliconPkg: Add GUIDs for SMBIOS data HOB and VBT data Thread-Index: AQHSK7a5Mu+KJFMqAUaMq8HO6XwqpqC0B4SAgAIGcuA= Date: Sun, 23 Oct 2016 13:47:15 +0000 Message-ID: <4666AEFED60F8E4198B42BB01DCEABDF76F28B16@ORSMSX113.amr.corp.intel.com> References: <74D8A39837DF1E4DA445A8C0B3885C50386B5703@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C50386B5703@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US, hi-IN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Subject: Re: [PATCH] IntelSiliconPkg: Add GUIDs for SMBIOS data HOB and VBT data X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Oct 2016 13:47:17 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for the feedback Jiewen, Star. Sure will send separate patches. The cosmetic change was to indent it at odd columns so it aligns with tabs = (two spaces) will skip this for now. Will add description to the VBT. This is FFS GUID to store the GOP VBT data= in RAW format.=20 Thanks, -Giri > -----Original Message----- > From: Yao, Jiewen > Sent: Friday, October 21, 2016 4:43 PM > To: Mudusuru, Giri P ; edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Zeng, Star > ; Yao, Jiewen > Subject: RE: [edk2] [PATCH] IntelSiliconPkg: Add GUIDs for SMBIOS data HO= B > and VBT data >=20 > Thanks for the patch. I have 2 minor comments: >=20 > 1) below update seems unnecessary. It makes me confused. We did not chang= e > anything right? Can we skip it? > - DEC_SPECIFICATION =3D 0x00010005 > - PACKAGE_NAME =3D IntelSiliconPkg > - PACKAGE_GUID =3D F7A58914-FA0E-4F71-BD6A-220FDF824A4= 9 > - PACKAGE_VERSION =3D 0.1 > + DEC_SPECIFICATION =3D 0x00010005 > + PACKAGE_NAME =3D IntelSiliconPkg > + PACKAGE_GUID =3D F7A58914-FA0E-4F71-BD6A-220FDF824A= 49 > + PACKAGE_VERSION =3D 0.1 >=20 > 2) Can we add one line to describe the VBT in more detail? If this is FFS= GUID, or > HOB GUID, PROTOCOL GUID? How is produced and consumed? > > + ## GUID for Graphics Video BIOS Table (VBT) Data > > + gIntelGraphicsVbtDataGuid =3D { 0x56752da9, 0xde6b, 0x4895, > > { 0x88, 0x19, 0x19, 0x45, 0xb6, 0xb7, 0x6c, 0x22 }} >=20 > I think below example is much better: > > + ## HOB GUID to publish SMBIOS data records from PEI phase > > + # Generic DXE Library / Driver can locate HOB(s) and add SMBIOS reco= rds > > into SMBIOS table > > + gIntelSmbiosDataHobGuid =3D { 0x798e722e, 0x15b2, 0x4e13, > > { 0x8a, 0xe9, 0x6b, 0xa3, 0x0f, 0xf7, 0xf1, 0x67 }} >=20 >=20 >=20 > Thank you > Yao Jiewen >=20 >=20 > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Giri P Mudusuru > > Sent: Saturday, October 22, 2016 12:18 AM > > To: edk2-devel@lists.01.org > > Cc: Kinney, Michael D ; Yao, Jiewen > > ; Zeng, Star > > Subject: [edk2] [PATCH] IntelSiliconPkg: Add GUIDs for SMBIOS data HOB > > and VBT data > > > > Add gIntelSmbiosDataHobGuid and gIntelGraphicsVbtDataGuid GUIDs > > > > Cc: Jiewen Yao > > Cc: Star Zeng > > Cc: Michael Kinney > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Giri P Mudusuru > > --- > > IntelSiliconPkg/IntelSiliconPkg.dec | 19 ++++++++++++++----- > > 1 file changed, 14 insertions(+), 5 deletions(-) > > > > diff --git a/IntelSiliconPkg/IntelSiliconPkg.dec > > b/IntelSiliconPkg/IntelSiliconPkg.dec > > index e42dbad..556fe76 100644 > > --- a/IntelSiliconPkg/IntelSiliconPkg.dec > > +++ b/IntelSiliconPkg/IntelSiliconPkg.dec > > @@ -1,5 +1,5 @@ > > ## @file > > -# IntelSilicon Package > > +# Intel Silicon Package > > # > > # This package provides common open source Intel silicon modules. > > # > > @@ -15,10 +15,19 @@ > > ## > > > > [Defines] > > - DEC_SPECIFICATION =3D 0x00010005 > > - PACKAGE_NAME =3D IntelSiliconPkg > > - PACKAGE_GUID =3D > > F7A58914-FA0E-4F71-BD6A-220FDF824A49 > > - PACKAGE_VERSION =3D 0.1 > > + DEC_SPECIFICATION =3D 0x00010005 > > + PACKAGE_NAME =3D IntelSiliconPkg > > + PACKAGE_GUID =3D > > F7A58914-FA0E-4F71-BD6A-220FDF824A49 > > + PACKAGE_VERSION =3D 0.1 > > > > [Includes] > > Include > > + > > +[Guids] > > + ## GUID for Graphics Video BIOS Table (VBT) Data > > + gIntelGraphicsVbtDataGuid =3D { 0x56752da9, 0xde6b, 0x4895, > > { 0x88, 0x19, 0x19, 0x45, 0xb6, 0xb7, 0x6c, 0x22 }} > > + > > + ## HOB GUID to publish SMBIOS data records from PEI phase > > + # Generic DXE Library / Driver can locate HOB(s) and add SMBIOS reco= rds > > into SMBIOS table > > + gIntelSmbiosDataHobGuid =3D { 0x798e722e, 0x15b2, 0x4e13, > > { 0x8a, 0xe9, 0x6b, 0xa3, 0x0f, 0xf7, 0xf1, 0x67 }} > > + > > -- > > 2.9.0.windows.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel