From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BD2461A1DF5 for ; Sun, 23 Oct 2016 07:28:21 -0700 (PDT) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP; 23 Oct 2016 07:28:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,388,1473145200"; d="scan'208";a="776492600" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by FMSMGA003.fm.intel.com with ESMTP; 23 Oct 2016 07:28:21 -0700 Received: from orsmsx154.amr.corp.intel.com (10.22.226.12) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 23 Oct 2016 07:28:20 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.50]) by ORSMSX154.amr.corp.intel.com ([10.22.226.12]) with mapi id 14.03.0248.002; Sun, 23 Oct 2016 07:28:20 -0700 From: "Mudusuru, Giri P" To: "Yao, Jiewen" , Laszlo Ersek , "Justen, Jordan L" , Andrew Fish CC: "Kinney, Michael D" , edk2-devel-01 , "Gao, Liming" , Leif Lindholm , Ard Biesheuvel Thread-Topic: [edk2] [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files Thread-Index: AQHSK9KY0UGfB5g5pEKi4OX5ngSnG6CzyMEAgAAGLICAAAU3gIAABn8AgAAS5QCAAAXjAIAAC7AAgAIYEaA= Date: Sun, 23 Oct 2016 14:28:19 +0000 Message-ID: <4666AEFED60F8E4198B42BB01DCEABDF76F28B73@ORSMSX113.amr.corp.intel.com> References: <147707992484.13791.10042868456965197315@jljusten-ivb> <147708236992.14194.656313834108120082@jljusten-ivb> <147708782254.15094.11260195572460159641@jljusten-ivb> <32ac0268-7b31-5a41-358a-b876ad6ae8cd@redhat.com> <74D8A39837DF1E4DA445A8C0B3885C50386B5630@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C50386B5630@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US, hi-IN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Subject: Re: [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Oct 2016 14:28:21 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable A combination of Jordon's and Andrews proposal would be better so we have o= ne flag and also scalable. Level of deprecated interfaces can be controlled= by each platform. EDK2 master platforms should not define this flag to eli= minate the usage of deprecated interfaces while UDK2015 can define and set = the value to 2015 for compatibility.=20 ENABLE_UDK_DEPRECATED_INTERFACES=3D2014 or 2015 or 2017 (UDK versions) Thanks, -Giri > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ya= o, > Jiewen > Sent: Friday, October 21, 2016 4:13 PM > To: Laszlo Ersek ; Justen, Jordan L > ; Andrew Fish > Cc: Kinney, Michael D ; edk2-devel-01 devel@ml01.01.org>; Gao, Liming ; Leif Lindholm > ; Ard Biesheuvel > Subject: Re: [edk2] [Bug 164] Add the build option "/D > DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files >=20 > I remember our deprecation process is: >=20 > 1) Core defines DISABLE_NEW_DEPRECATED_INTERFACES and puts a > deprecated content in it. (Platform does not use > DISABLE_NEW_DEPRECATED_INTERFACES and deprecated function can still be > used at this moment. But we strongly recommend a platform doing clean up = at > same time.) >=20 > 2) Platform defines DISABLE_NEW_DEPRECATED_INTERFACES and > deprecated function cannot be used after the clean up work. >=20 > 3) Core removes the deprecated content and > DISABLE_NEW_DEPRECATED_INTERFACES, if we can make sure no platform > using it. >=20 > 4) Platform may remove DISABLE_NEW_DEPRECATED_INTERFACES. >=20 > We do not want to remove a function directly, to break lots of platforms.= We > just want to give a buffer to let platform do code cleanup. >=20 > Thank you > Yao Jiewen >=20 > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of La= szlo > Ersek > Sent: Saturday, October 22, 2016 6:31 AM > To: Justen, Jordan L ; Andrew Fish > > Cc: Kinney, Michael D ; edk2-devel-01 devel@ml01.01.org>; Leif Lindholm ; Gao, Liming > ; Ard Biesheuvel > Subject: Re: [edk2] [Bug 164] Add the build option "/D > DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files >=20 > On 10/22/16 00:10, Jordan Justen wrote: > > On 2016-10-21 14:02:44, Laszlo Ersek wrote: >=20 > >> Honestly, I imagined that DISABLE_NEW_DEPRECATED_INTERFACES would > be > >> temporary in the edk2 tree. That is, it's a means so we can gradually > >> transition with all the in-tree stuff to a deprecationless code base. > >> Once that's done -- i.e., *all* platform DSCs within the edk2 tree > >> specify this feature test macro under their respective [BuildOptions] > >> sections --, then whatever the macro excises from the core packages ca= n > >> be removed permanently, together with those platform [BuildOptions]. > >> > > > > That could be reasonable, although I'd argue that we could flip it > > around. Opt-in to the deprecated interfaces on all platforms, and then > > start marking deprecated interfaces. Finally we could clean up > > platforms and removed the override. >=20 > That's a valid idea, IMO. >=20 > > But ... I think DISABLE_NEW_DEPRECATED_INTERFACES was first added in: > > > > commit bf4a3dbd4751b6411bdfc98bf3ac2c4f928bdfdf > > Author: ydong10 > > Date: Wed May 30 07:36:00 2012 +0000 > > > > So, I guess it is not going to be removed anytime soon. :( >=20 > I believe we just need to make progress with the individual platforms > (and their dependencies from other Pkgs). It's not a lot of fun, but the > BZs exist (well, they can be filed) now, and then we can address them... >=20 > I mean, I didn't care (or, really, know) about > DISABLE_NEW_DEPRECATED_INTERFACES until the ArmVirtPkg / OvmfPkg BZs > got > filed. Bugzilla is great. I like the attention that it gets, from others > and from myself. >=20 > Thanks > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel