public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Mudusuru, Giri P" <giri.p.mudusuru@intel.com>
To: Laszlo Ersek <lersek@redhat.com>, edk2-devel-01 <edk2-devel@ml01.01.org>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>
Subject: Re: [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec: drop bogus semicolon from GUID def
Date: Thu, 17 Nov 2016 14:27:27 +0000	[thread overview]
Message-ID: <4666AEFED60F8E4198B42BB01DCEABDF76F5B3DD@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <20161117103649.15110-1-lersek@redhat.com>

Thank you for fixing it.
Reviewed-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>


> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Thursday, November 17, 2016 2:37 AM
> To: edk2-devel-01 <edk2-devel@ml01.01.org>
> Cc: Mudusuru, Giri P <giri.p.mudusuru@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>
> Subject: [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec: drop bogus semicolon from
> GUID def
> 
> The DEC spec doesn't allow the trailing semicolon:
> 
>   2.6 [Guids] Usage
> 
>   GuidCName = {C Format Guid Value} # Comment
> 
> Cc: Giri P Mudusuru <giri.p.mudusuru@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  IntelSiliconPkg/IntelSiliconPkg.dec | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/IntelSiliconPkg/IntelSiliconPkg.dec
> b/IntelSiliconPkg/IntelSiliconPkg.dec
> index 4a51d0a547da..8819cb8fed6b 100644
> --- a/IntelSiliconPkg/IntelSiliconPkg.dec
> +++ b/IntelSiliconPkg/IntelSiliconPkg.dec
> @@ -26,7 +26,7 @@ [Includes]
>  [Guids]
>    ## GUID for Package token space
>    # {A9F8D54E-1107-4F0A-ADD0-4587E7A4A735}
> -  gIntelSiliconPkgTokenSpaceGuid  = { 0xa9f8d54e, 0x1107, 0x4f0a, { 0xad,
> 0xd0, 0x45, 0x87, 0xe7, 0xa4, 0xa7, 0x35 } };
> +  gIntelSiliconPkgTokenSpaceGuid  = { 0xa9f8d54e, 0x1107, 0x4f0a, { 0xad,
> 0xd0, 0x45, 0x87, 0xe7, 0xa4, 0xa7, 0x35 } }
> 
>    ## HOB GUID to publish SMBIOS data records from PEI phase
>    # HOB data format is same as SMBIOS records defined in SMBIOS spec or OEM
> defined types
> --
> 2.9.2



  parent reply	other threads:[~2016-11-17 14:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-17 10:36 [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec: drop bogus semicolon from GUID def Laszlo Ersek
2016-11-17 12:04 ` Yao, Jiewen
2016-11-17 13:51   ` Laszlo Ersek
2016-11-17 14:27 ` Mudusuru, Giri P [this message]
2016-11-17 16:01   ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4666AEFED60F8E4198B42BB01DCEABDF76F5B3DD@ORSMSX113.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox