From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <giri.p.mudusuru@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 3EDAE81E9E
 for <edk2-devel@ml01.01.org>; Thu, 17 Nov 2016 06:27:24 -0800 (PST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga105.fm.intel.com with ESMTP; 17 Nov 2016 06:27:29 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,506,1473145200"; d="scan'208";a="902497307"
Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5])
 by orsmga003.jf.intel.com with ESMTP; 17 Nov 2016 06:27:28 -0800
Received: from orsmsx160.amr.corp.intel.com (10.22.226.43) by
 ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Thu, 17 Nov 2016 06:27:28 -0800
Received: from orsmsx113.amr.corp.intel.com ([169.254.9.63]) by
 ORSMSX160.amr.corp.intel.com ([10.22.226.43]) with mapi id 14.03.0248.002;
 Thu, 17 Nov 2016 06:27:28 -0800
From: "Mudusuru, Giri P" <giri.p.mudusuru@intel.com>
To: Laszlo Ersek <lersek@redhat.com>, edk2-devel-01 <edk2-devel@ml01.01.org>
CC: "Yao, Jiewen" <jiewen.yao@intel.com>
Thread-Topic: [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec: drop bogus
 semicolon from GUID def
Thread-Index: AQHSQL6RZ/Apm0y+dU+zlvgkSwNyxaDdO9aA
Date: Thu, 17 Nov 2016 14:27:27 +0000
Message-ID: <4666AEFED60F8E4198B42BB01DCEABDF76F5B3DD@ORSMSX113.amr.corp.intel.com>
References: <20161117103649.15110-1-lersek@redhat.com>
In-Reply-To: <20161117103649.15110-1-lersek@redhat.com>
Accept-Language: en-US, hi-IN
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.22.254.140]
MIME-Version: 1.0
Subject: Re: [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec: drop bogus semicolon from GUID def
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Nov 2016 14:27:24 -0000
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Thank you for fixing it.
Reviewed-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>


> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Thursday, November 17, 2016 2:37 AM
> To: edk2-devel-01 <edk2-devel@ml01.01.org>
> Cc: Mudusuru, Giri P <giri.p.mudusuru@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>
> Subject: [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec: drop bogus semicolo=
n from
> GUID def
>=20
> The DEC spec doesn't allow the trailing semicolon:
>=20
>   2.6 [Guids] Usage
>=20
>   GuidCName =3D {C Format Guid Value} # Comment
>=20
> Cc: Giri P Mudusuru <giri.p.mudusuru@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  IntelSiliconPkg/IntelSiliconPkg.dec | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/IntelSiliconPkg/IntelSiliconPkg.dec
> b/IntelSiliconPkg/IntelSiliconPkg.dec
> index 4a51d0a547da..8819cb8fed6b 100644
> --- a/IntelSiliconPkg/IntelSiliconPkg.dec
> +++ b/IntelSiliconPkg/IntelSiliconPkg.dec
> @@ -26,7 +26,7 @@ [Includes]
>  [Guids]
>    ## GUID for Package token space
>    # {A9F8D54E-1107-4F0A-ADD0-4587E7A4A735}
> -  gIntelSiliconPkgTokenSpaceGuid  =3D { 0xa9f8d54e, 0x1107, 0x4f0a, { 0x=
ad,
> 0xd0, 0x45, 0x87, 0xe7, 0xa4, 0xa7, 0x35 } };
> +  gIntelSiliconPkgTokenSpaceGuid  =3D { 0xa9f8d54e, 0x1107, 0x4f0a, { 0x=
ad,
> 0xd0, 0x45, 0x87, 0xe7, 0xa4, 0xa7, 0x35 } }
>=20
>    ## HOB GUID to publish SMBIOS data records from PEI phase
>    # HOB data format is same as SMBIOS records defined in SMBIOS spec or =
OEM
> defined types
> --
> 2.9.2