* [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec: drop bogus semicolon from GUID def
@ 2016-11-17 10:36 Laszlo Ersek
2016-11-17 12:04 ` Yao, Jiewen
2016-11-17 14:27 ` Mudusuru, Giri P
0 siblings, 2 replies; 5+ messages in thread
From: Laszlo Ersek @ 2016-11-17 10:36 UTC (permalink / raw)
To: edk2-devel-01; +Cc: Giri P Mudusuru, Jiewen Yao
The DEC spec doesn't allow the trailing semicolon:
2.6 [Guids] Usage
GuidCName = {C Format Guid Value} # Comment
Cc: Giri P Mudusuru <giri.p.mudusuru@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
IntelSiliconPkg/IntelSiliconPkg.dec | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/IntelSiliconPkg/IntelSiliconPkg.dec b/IntelSiliconPkg/IntelSiliconPkg.dec
index 4a51d0a547da..8819cb8fed6b 100644
--- a/IntelSiliconPkg/IntelSiliconPkg.dec
+++ b/IntelSiliconPkg/IntelSiliconPkg.dec
@@ -26,7 +26,7 @@ [Includes]
[Guids]
## GUID for Package token space
# {A9F8D54E-1107-4F0A-ADD0-4587E7A4A735}
- gIntelSiliconPkgTokenSpaceGuid = { 0xa9f8d54e, 0x1107, 0x4f0a, { 0xad, 0xd0, 0x45, 0x87, 0xe7, 0xa4, 0xa7, 0x35 } };
+ gIntelSiliconPkgTokenSpaceGuid = { 0xa9f8d54e, 0x1107, 0x4f0a, { 0xad, 0xd0, 0x45, 0x87, 0xe7, 0xa4, 0xa7, 0x35 } }
## HOB GUID to publish SMBIOS data records from PEI phase
# HOB data format is same as SMBIOS records defined in SMBIOS spec or OEM defined types
--
2.9.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec: drop bogus semicolon from GUID def
2016-11-17 10:36 [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec: drop bogus semicolon from GUID def Laszlo Ersek
@ 2016-11-17 12:04 ` Yao, Jiewen
2016-11-17 13:51 ` Laszlo Ersek
2016-11-17 14:27 ` Mudusuru, Giri P
1 sibling, 1 reply; 5+ messages in thread
From: Yao, Jiewen @ 2016-11-17 12:04 UTC (permalink / raw)
To: Laszlo Ersek, edk2-devel-01
Reviewed-by: Jiewen.yao@intel.com
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Thursday, November 17, 2016 6:37 PM
> To: edk2-devel-01 <edk2-devel@ml01.01.org>
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [edk2] [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec: drop bogus
> semicolon from GUID def
>
> The DEC spec doesn't allow the trailing semicolon:
>
> 2.6 [Guids] Usage
>
> GuidCName = {C Format Guid Value} # Comment
>
> Cc: Giri P Mudusuru <giri.p.mudusuru@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> IntelSiliconPkg/IntelSiliconPkg.dec | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/IntelSiliconPkg/IntelSiliconPkg.dec
> b/IntelSiliconPkg/IntelSiliconPkg.dec
> index 4a51d0a547da..8819cb8fed6b 100644
> --- a/IntelSiliconPkg/IntelSiliconPkg.dec
> +++ b/IntelSiliconPkg/IntelSiliconPkg.dec
> @@ -26,7 +26,7 @@ [Includes]
> [Guids]
> ## GUID for Package token space
> # {A9F8D54E-1107-4F0A-ADD0-4587E7A4A735}
> - gIntelSiliconPkgTokenSpaceGuid = { 0xa9f8d54e, 0x1107, 0x4f0a, { 0xad,
> 0xd0, 0x45, 0x87, 0xe7, 0xa4, 0xa7, 0x35 } };
> + gIntelSiliconPkgTokenSpaceGuid = { 0xa9f8d54e, 0x1107, 0x4f0a,
> { 0xad, 0xd0, 0x45, 0x87, 0xe7, 0xa4, 0xa7, 0x35 } }
>
> ## HOB GUID to publish SMBIOS data records from PEI phase
> # HOB data format is same as SMBIOS records defined in SMBIOS spec or
> OEM defined types
> --
> 2.9.2
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec: drop bogus semicolon from GUID def
2016-11-17 12:04 ` Yao, Jiewen
@ 2016-11-17 13:51 ` Laszlo Ersek
0 siblings, 0 replies; 5+ messages in thread
From: Laszlo Ersek @ 2016-11-17 13:51 UTC (permalink / raw)
To: Yao, Jiewen, edk2-devel-01
On 11/17/16 13:04, Yao, Jiewen wrote:
> Reviewed-by: Jiewen.yao@intel.com
Thanks! Commit 2048ab4b3ec9.
Laszlo
>
>> -----Original Message-----
>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>> Laszlo Ersek
>> Sent: Thursday, November 17, 2016 6:37 PM
>> To: edk2-devel-01 <edk2-devel@ml01.01.org>
>> Cc: Yao, Jiewen <jiewen.yao@intel.com>
>> Subject: [edk2] [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec: drop bogus
>> semicolon from GUID def
>>
>> The DEC spec doesn't allow the trailing semicolon:
>>
>> 2.6 [Guids] Usage
>>
>> GuidCName = {C Format Guid Value} # Comment
>>
>> Cc: Giri P Mudusuru <giri.p.mudusuru@intel.com>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>> IntelSiliconPkg/IntelSiliconPkg.dec | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/IntelSiliconPkg/IntelSiliconPkg.dec
>> b/IntelSiliconPkg/IntelSiliconPkg.dec
>> index 4a51d0a547da..8819cb8fed6b 100644
>> --- a/IntelSiliconPkg/IntelSiliconPkg.dec
>> +++ b/IntelSiliconPkg/IntelSiliconPkg.dec
>> @@ -26,7 +26,7 @@ [Includes]
>> [Guids]
>> ## GUID for Package token space
>> # {A9F8D54E-1107-4F0A-ADD0-4587E7A4A735}
>> - gIntelSiliconPkgTokenSpaceGuid = { 0xa9f8d54e, 0x1107, 0x4f0a, { 0xad,
>> 0xd0, 0x45, 0x87, 0xe7, 0xa4, 0xa7, 0x35 } };
>> + gIntelSiliconPkgTokenSpaceGuid = { 0xa9f8d54e, 0x1107, 0x4f0a,
>> { 0xad, 0xd0, 0x45, 0x87, 0xe7, 0xa4, 0xa7, 0x35 } }
>>
>> ## HOB GUID to publish SMBIOS data records from PEI phase
>> # HOB data format is same as SMBIOS records defined in SMBIOS spec or
>> OEM defined types
>> --
>> 2.9.2
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec: drop bogus semicolon from GUID def
2016-11-17 10:36 [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec: drop bogus semicolon from GUID def Laszlo Ersek
2016-11-17 12:04 ` Yao, Jiewen
@ 2016-11-17 14:27 ` Mudusuru, Giri P
2016-11-17 16:01 ` Laszlo Ersek
1 sibling, 1 reply; 5+ messages in thread
From: Mudusuru, Giri P @ 2016-11-17 14:27 UTC (permalink / raw)
To: Laszlo Ersek, edk2-devel-01; +Cc: Yao, Jiewen
Thank you for fixing it.
Reviewed-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Thursday, November 17, 2016 2:37 AM
> To: edk2-devel-01 <edk2-devel@ml01.01.org>
> Cc: Mudusuru, Giri P <giri.p.mudusuru@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>
> Subject: [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec: drop bogus semicolon from
> GUID def
>
> The DEC spec doesn't allow the trailing semicolon:
>
> 2.6 [Guids] Usage
>
> GuidCName = {C Format Guid Value} # Comment
>
> Cc: Giri P Mudusuru <giri.p.mudusuru@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> IntelSiliconPkg/IntelSiliconPkg.dec | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/IntelSiliconPkg/IntelSiliconPkg.dec
> b/IntelSiliconPkg/IntelSiliconPkg.dec
> index 4a51d0a547da..8819cb8fed6b 100644
> --- a/IntelSiliconPkg/IntelSiliconPkg.dec
> +++ b/IntelSiliconPkg/IntelSiliconPkg.dec
> @@ -26,7 +26,7 @@ [Includes]
> [Guids]
> ## GUID for Package token space
> # {A9F8D54E-1107-4F0A-ADD0-4587E7A4A735}
> - gIntelSiliconPkgTokenSpaceGuid = { 0xa9f8d54e, 0x1107, 0x4f0a, { 0xad,
> 0xd0, 0x45, 0x87, 0xe7, 0xa4, 0xa7, 0x35 } };
> + gIntelSiliconPkgTokenSpaceGuid = { 0xa9f8d54e, 0x1107, 0x4f0a, { 0xad,
> 0xd0, 0x45, 0x87, 0xe7, 0xa4, 0xa7, 0x35 } }
>
> ## HOB GUID to publish SMBIOS data records from PEI phase
> # HOB data format is same as SMBIOS records defined in SMBIOS spec or OEM
> defined types
> --
> 2.9.2
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec: drop bogus semicolon from GUID def
2016-11-17 14:27 ` Mudusuru, Giri P
@ 2016-11-17 16:01 ` Laszlo Ersek
0 siblings, 0 replies; 5+ messages in thread
From: Laszlo Ersek @ 2016-11-17 16:01 UTC (permalink / raw)
To: Mudusuru, Giri P, edk2-devel-01; +Cc: Yao, Jiewen
On 11/17/16 15:27, Mudusuru, Giri P wrote:
> Thank you for fixing it.
> Reviewed-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
Thanks! I was eager and already committed it with Jiewen's R-b.
Cheers!
Laszlo
>> -----Original Message-----
>> From: Laszlo Ersek [mailto:lersek@redhat.com]
>> Sent: Thursday, November 17, 2016 2:37 AM
>> To: edk2-devel-01 <edk2-devel@ml01.01.org>
>> Cc: Mudusuru, Giri P <giri.p.mudusuru@intel.com>; Yao, Jiewen
>> <jiewen.yao@intel.com>
>> Subject: [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec: drop bogus semicolon from
>> GUID def
>>
>> The DEC spec doesn't allow the trailing semicolon:
>>
>> 2.6 [Guids] Usage
>>
>> GuidCName = {C Format Guid Value} # Comment
>>
>> Cc: Giri P Mudusuru <giri.p.mudusuru@intel.com>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>> IntelSiliconPkg/IntelSiliconPkg.dec | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/IntelSiliconPkg/IntelSiliconPkg.dec
>> b/IntelSiliconPkg/IntelSiliconPkg.dec
>> index 4a51d0a547da..8819cb8fed6b 100644
>> --- a/IntelSiliconPkg/IntelSiliconPkg.dec
>> +++ b/IntelSiliconPkg/IntelSiliconPkg.dec
>> @@ -26,7 +26,7 @@ [Includes]
>> [Guids]
>> ## GUID for Package token space
>> # {A9F8D54E-1107-4F0A-ADD0-4587E7A4A735}
>> - gIntelSiliconPkgTokenSpaceGuid = { 0xa9f8d54e, 0x1107, 0x4f0a, { 0xad,
>> 0xd0, 0x45, 0x87, 0xe7, 0xa4, 0xa7, 0x35 } };
>> + gIntelSiliconPkgTokenSpaceGuid = { 0xa9f8d54e, 0x1107, 0x4f0a, { 0xad,
>> 0xd0, 0x45, 0x87, 0xe7, 0xa4, 0xa7, 0x35 } }
>>
>> ## HOB GUID to publish SMBIOS data records from PEI phase
>> # HOB data format is same as SMBIOS records defined in SMBIOS spec or OEM
>> defined types
>> --
>> 2.9.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-11-17 16:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-17 10:36 [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec: drop bogus semicolon from GUID def Laszlo Ersek
2016-11-17 12:04 ` Yao, Jiewen
2016-11-17 13:51 ` Laszlo Ersek
2016-11-17 14:27 ` Mudusuru, Giri P
2016-11-17 16:01 ` Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox